Commit Graph

  • 64b90fef10
    Fix: ignore bulk upload rows which contain whitespace only (#1587) SamSeed-Softwire 2023-04-25 14:02:11 +0100
  • e778c09e4c test: ensure row as a whole is not blank in 'blank field' tests Sam Seed 2023-04-25 12:31:02 +0100
  • 6254f118fe fix: ignore BU rows which contain whitespace only Sam Seed 2023-04-25 11:02:06 +0100
  • e56ef83172 CLDC-2056 Add absorbing organisation question Jack S 2023-04-24 17:59:10 +0100
  • b9f38eaec6 fix specs Phil Lee 2023-04-25 12:13:01 +0100
  • d1f21a5890
    CLDC-2031 Sales bulk upload (#1574) kosiakkatrina 2023-04-25 12:01:17 +0100
  • 5a7d511356 chore: lint Sam Seed 2023-04-20 15:29:20 +0100
  • 22284e3bc5 test: update 2022 csv parser tests to work like 2023 Sam Seed 2023-04-20 15:26:52 +0100
  • 0e2c282d45 refactor: check fields/columns count within csv parser, not validator Sam Seed 2023-04-20 14:45:41 +0100
  • 25c7244ae7 test: ensure context descriptions start with "when" Sam Seed 2023-04-19 18:59:32 +0100
  • 982e1de587 chore: lint Sam Seed 2023-04-19 18:59:11 +0100
  • 7d4456f9dc test: simplify 2022/2023 logic and improve layout Sam Seed 2023-04-19 18:27:14 +0100
  • f8feed6c08 test: for validator 2022 as well as 2023 Sam Seed 2023-04-19 18:10:51 +0100
  • 8b845c2109 feat: update 2022 csv parser to have col flexibility like 2023 Sam Seed 2023-04-19 18:09:41 +0100
  • 9cc1ee4fa6 refactor: remove redundant headers definition Sam Seed 2023-04-19 17:23:11 +0100
  • df182a358e refactor: define number of valid 2022 fields in one place Sam Seed 2023-04-19 17:20:46 +0100
  • e918bc3072 feat: update 2022 csv_parser to work with new validations Sam Seed 2023-04-19 17:20:15 +0100
  • 8ab62c903d test: remove tests from csv_parser_spec that were moved to validator_spec Sam Seed 2023-04-19 16:48:43 +0100
  • ee01b4d555 chore: lint Sam Seed 2023-04-19 16:48:28 +0100
  • 34acc24933 test: add/update tests in validator_spec Sam Seed 2023-04-19 16:46:52 +0100
  • 78c51e8c38 test: explicitly set year of bulk upload to be 2022 Sam Seed 2023-04-19 16:44:07 +0100
  • 9f2d6038e4 feat: add leniency to max cols count (in case of 1 extra col) Sam Seed 2023-04-19 12:29:43 +0100
  • 3812ec34c7 fix: convert numbers to strings in default_field_numbers Sam Seed 2023-04-18 16:55:58 +0100
  • 6e98eaa5ea feat: add validation that max col count not exceeded when no headers Sam Seed 2023-04-18 16:55:20 +0100
  • fd815cf8bc refactor: rename validate_fields_count and wrong_field_count Sam Seed 2023-04-18 16:54:17 +0100
  • 820c2efa3a test: that adding a valid field label increases count by 1 Sam Seed 2023-04-18 12:29:00 +0100
  • 1debbece47 test: that removing a valid field label reduces count by 1 Sam Seed 2023-04-18 12:26:12 +0100
  • 97d297628f test: that extra invalid field labels don't cause issues Sam Seed 2023-04-18 12:25:55 +0100
  • 2978f3cfbd test: add functions to generate custom field labels/values Sam Seed 2023-04-18 12:25:22 +0100
  • 0f3e48f80c refactor: rename non_blank_fields_count to valid_field_numbers_count Sam Seed 2023-04-18 12:24:59 +0100
  • 1d0632cd15 feat: remove validations for number of columns Sam Seed 2023-04-05 17:36:15 +0100
  • 94f29df0ce feat: check field labels are numbers Sam Seed 2023-04-05 17:35:55 +0100
  • 55b84e7aaf feat: add validation for number of field labels Sam Seed 2023-04-05 17:34:58 +0100
  • 1f0516217f bulk upload duplicates discounts hidden logs Phil Lee 2023-04-12 16:20:16 +0100
  • bb37d3bc21 memoize #valid? method call Phil Lee 2023-04-12 11:35:58 +0100
  • 789505761d tweak bulk upload duplicate feature toggle Phil Lee 2023-04-12 10:47:49 +0100
  • 138641ce6d memoize expensive method call Phil Lee 2023-04-12 10:32:48 +0100
  • 21db4ddcb1 fix test Phil Lee 2023-04-11 17:35:52 +0100
  • 05faa6efed refactor: simplify owning/managing org logic in 23/24 row parser Sam Seed 2023-03-30 19:03:52 +0100
  • f146629095 feat: put duplicate logs check feature behind toggle Sam Seed 2023-03-30 18:52:43 +0100
  • f68d60a292 test: add feature toggle to tests Sam Seed 2023-03-30 18:38:10 +0100
  • e4e91143d5 feat: add feature toggle for duplicate log check Sam Seed 2023-03-30 18:37:33 +0100
  • eb6f8f0d1d fix: don't include errors param in send_correct_and_upload_again_mail Sam Seed 2023-03-30 18:34:03 +0100
  • 1906359dca refactor: write 'duplicate' instead of 'duplicity' Sam Seed 2023-03-30 18:16:50 +0100
  • f6a26d2747 feat: add duplicate log check for 23/24 Sam Seed 2023-03-30 18:10:53 +0100
  • 7d282c1cd5 style: remove empty lines between errors being added Sam Seed 2023-03-30 18:10:32 +0100
  • c265bbf58a fix: update test to not mention specific CSV errors Sam Seed 2023-03-30 17:31:09 +0100
  • 7b3bae7059 fix: remove any_setup_sections_incomplete Sam Seed 2023-03-30 17:30:15 +0100
  • e42b005999 chore: lint Sam Seed 2023-03-07 12:13:59 +0000
  • f5a5426836 fix: ensure random field id is in correct range Sam Seed 2023-03-07 12:04:05 +0000
  • dcd574424b feat: add postcode and location to fields which determine duplicates Sam Seed 2023-03-07 11:04:15 +0000
  • 00d222b4b6 handle duplicates for bulk upload Sam Seed 2023-02-06 12:02:16 +0000
  • 5862e02d1b
    bulk upload declaration validated as setup field (#1583) v0.3.17 Phil Lee 2023-04-25 10:40:20 +0100
  • 8e1a4e08b2
    CLDC-2226 Update UPRN validations in bulk upload (#1524) SamSeed-Softwire 2023-04-25 10:23:20 +0100
  • fe7282c8ea
    Bump sidekiq from 7.0.5 to 7.0.8 dependabot[bot] 2023-04-24 20:47:56 +0000
  • e83116ef21 refactor: lint natdeanlewissoftwire 2023-04-24 17:45:13 +0100
  • 35b9832fec feat: update pluralisation natdeanlewissoftwire 2023-04-24 17:38:50 +0100
  • 222d512c60 feat: update validations natdeanlewissoftwire 2023-04-24 16:26:29 +0100
  • 6b4337e217 feat: add blank compound invalid fields methods natdeanlewissoftwire 2023-04-24 16:26:20 +0100
  • de8bbae9d0 feat: add correct pluralisation to warning message natdeanlewissoftwire 2023-04-24 16:25:47 +0100
  • bfe56e243d fix: add :after_log context to uprn validation Sam Seed 2023-04-24 15:45:28 +0100
  • 44bd2363d1 fix: add .presence to question.header and remove & before .downcase Sam Seed 2023-04-24 12:43:07 +0100
  • ae42147dd8 chore: lint Sam Seed 2023-04-24 12:13:04 +0100
  • c0a5a8748f feat: output "this question" if qu has no header or check_answer_label Sam Seed 2023-04-24 12:10:52 +0100
  • 9902d16fb8 test: ensure one other non-blank field exists in row Sam Seed 2023-04-24 11:56:51 +0100
  • 7a88d11afa test: fix typo in test description Sam Seed 2023-04-24 11:56:31 +0100
  • 7a4b189c04 test: put test within context block for clarity Sam Seed 2023-04-24 11:56:19 +0100
  • ff69200d97 Revert "test: attempt to stub setup question to have nil check_answer_label" Sam Seed 2023-04-24 11:51:00 +0100
  • f5b3f6179b test: attempt to stub setup question to have nil check_answer_label Sam Seed 2023-04-24 11:49:09 +0100
  • 18817d3044 bulk upload declaration validated as setup field Phil Lee 2023-04-24 10:48:44 +0100
  • 5d31277bee refactor: standardise check for presence of needs type Sam Seed 2023-04-20 18:31:31 +0100
  • 07489f9b55 test: that errors added to address fields too when uprn & address fields all null Sam Seed 2023-04-13 17:31:48 +0100
  • 02bf25add0 test: improve test descriptions Sam Seed 2023-04-13 17:31:20 +0100
  • 17e8a3904b test: make UPRN being missing explicit Sam Seed 2023-04-13 17:28:47 +0100
  • 5f826e132d fix: update uprn validation logic Sam Seed 2023-04-13 17:24:53 +0100
  • 5025a760a5 fix: drop "known" from "You must answer UPRN known" Sam Seed 2023-04-11 15:02:33 +0100
  • 5a1404e5de test: that validate_nulls gets header if check_answer_label is missing Sam Seed 2023-04-06 15:21:37 +0100
  • 0578c86d47 feat: show qu header on BU error template if check_answer_label missing Sam Seed 2023-04-06 11:52:44 +0100
  • 6de65fcb39 test: make UPRN<=12 chars test more specific Sam Seed 2023-04-04 12:34:26 +0100
  • 8698497b12 test: add tests for UPRN/address fields Sam Seed 2023-04-04 12:33:55 +0100
  • be781903fd feat: add validation to check UPRN exists if address doesn't Sam Seed 2023-04-03 17:33:09 +0100
  • 81a80235c6
    Improve typography for collection resources (#1582) kosiakkatrina 2023-04-24 10:00:43 +0100
  • 5a4d979d04 Improve typography for collection resources Paul Robert Lloyd 2023-04-23 12:28:55 +0100
  • 5de5900f43 test: update natdeanlewissoftwire 2023-04-24 09:10:22 +0100
  • c315f6f17c Address comments Jack S 2023-04-24 09:04:52 +0100
  • 440748b13d feat: merge with main natdeanlewissoftwire 2023-04-24 08:50:57 +0100
  • 398b8668eb Merge branch 'main' into CLDC-2010-discounted-income-soft-max natdeanlewissoftwire 2023-04-24 08:50:35 +0100
  • b816968104
    CLDC-2272 Fix UPRN income validation bug (#1553) natdeanlewissoftwire 2023-04-24 08:44:11 +0100
  • a1d064ed75 Improve typography for collection resources Paul Robert Lloyd 2023-04-23 12:28:55 +0100
  • 50b2b210fc feat: move la vals to shared and move and add tests natdeanlewissoftwire 2023-04-21 17:28:54 +0100
  • 8e27f70b4a feat: add postcode validation back natdeanlewissoftwire 2023-04-21 17:08:32 +0100
  • fb10e02ff4 send the correct emails Kat 2023-04-21 16:25:00 +0100
  • d7102b6a7b Move sales created_by page and question out of common Jack S 2023-04-20 13:35:52 +0100
  • 32e8b4fc52 Remove managing_for_other_user_enabled Jack S 2023-04-19 15:15:09 +0100
  • 5366ce9af5 Scope user selection when data coordinator Jack S 2023-04-18 14:34:23 +0100
  • 92e3bb938e [CLDC-2202] Allow coordinators to set created_by Jack S 2023-04-12 17:49:30 +0100
  • 59f71398d9 Add sales resume and summary pages Kat 2023-04-21 15:07:01 +0100
  • 70f9a4374c Merge branch 'main' into CLDC-2272-uprn-income-validations-bug natdeanlewissoftwire 2023-04-21 15:02:33 +0100
  • b2714cd75b feat: make combined_income nil safe natdeanlewissoftwire 2023-04-21 14:55:24 +0100
  • da218e073b
    CLDC-2274 Fix buyer 2 nationality routing bug (#1546) natdeanlewissoftwire 2023-04-21 14:49:33 +0100