baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Commit Graph

  • fe3e6e8c83 Validate no housing needs answers for 2023 Kat 2023-05-10 09:57:47 +0100
  • 0797da33ea Validate no housing needs answers for 2022 Kat 2023-05-10 09:57:43 +0100
  • 1053607ed8
         CLDC-2287 Bulk upload setup errors (#1585) Phil Lee 2023-05-10 10:00:39 +0100
  • 884eca37db Check new telephone number when there's an error Jack S 2023-05-09 13:15:31 +0100
  • ecdfab1c88
         Update more validations upon import (#1609) kosiakkatrina 2023-05-09 15:46:37 +0100
  • 70f51a413c Clear frombeds if it's out of range Kat 2023-05-09 15:27:56 +0100
  • 360efecd4f Remove mscharge if it is under minimum Kat 2023-05-09 14:59:05 +0100
  • 2ac9ba3887 Fix import with income 2 outside of london validation Kat 2023-05-09 13:00:53 +0100
  • 36fede356d Clear invalid format previous postcode Kat 2023-05-09 12:57:30 +0100
  • 40cf0c10c2
         CLDC-1633 build feature csv download of sales logs (#1568) Arthur Campbell 2023-05-09 11:50:38 +0100
  • 9455be06f7 tweak fixtures after rebase containing alterations to the factory defaults Arthur Campbell 2023-05-09 11:35:10 +0100
  • 7d4a8f90eb
         Update import to handle validations (#1605) kosiakkatrina 2023-05-09 11:19:13 +0100
  • 197924c29b update bundler 2.3.14 => 2.4.12 Phil Lee 2023-05-09 11:15:42 +0100
  • b9f7fbd17a refactor after code review Arthur Campbell 2023-05-03 12:10:47 +0100
  • 055888c689 minor alterations after rebase to account for changes made on other branches Arthur Campbell 2023-05-02 16:05:54 +0100
  • 90bf0c0ef8 fix linter complaints Arthur Campbell 2023-05-02 15:03:39 +0100
  • e82b54edaf write further tests on the manipulation of questions into the csv headers, update factories of form constituents to allow the creation of forms with richer questions Arthur Campbell 2023-04-28 17:09:37 +0100
  • 829b7880a5 remove reminder comments Arthur Campbell 2023-04-27 14:42:07 +0100
  • 9e50bcedd4 correct minor bug to ensure that "Return to logs" link returns to the correct index page Arthur Campbell 2023-04-27 12:52:03 +0100
  • 5e53d23f0f use that fact that params is always available in controllers and don't pass it around, inline some methods calls Arthur Campbell 2023-04-27 11:09:26 +0100
  • dc34f2042d some refactoring in the testing of the csv service Arthur Campbell 2023-04-26 17:35:55 +0100
  • 1cba256088 refactor all tests of :ordered_sales_questions_for_all_years to use new factories Arthur Campbell 2023-04-26 15:23:42 +0100
  • 3639815eb3 second pass Arthur Campbell 2023-04-26 12:56:55 +0100
  • b48a7a0860 first pass at implementing flexible code-based form fixtures for testing Arthur Campbell 2023-04-26 11:13:56 +0100
  • 4bf1f81c79 refactor :ordered_sales_questions_for_all_years Arthur Campbell 2023-04-25 14:04:53 +0100
  • 9673c49479 various corrections from first pass at PO, tech review, linter, etc Arthur Campbell 2023-04-24 15:33:32 +0100
  • d73c7dfa51 minor correction after rubocop's kind suggestion' Arthur Campbell 2023-04-24 13:44:36 +0100
  • 8886990667 write request tests for the new functionality in the sales log controller, define authorisation in the controller Arthur Campbell 2023-04-24 13:43:16 +0100
  • c424c2436e update organisations controller requests spec file to cover new functionality and make a minor amendment to authentication scope in the controller after error found in testing Arthur Campbell 2023-04-24 09:32:02 +0100
  • 845f1229d8 correct minor routing error to ensure correct url is shown and tab selected after requesting csv email Arthur Campbell 2023-04-21 17:04:31 +0100
  • bcd6d15d5b update tests to include a test of a full export and all values in teh csv Arthur Campbell 2023-04-21 16:54:15 +0100
  • e067d6e388 refactoring of csv service after some tech review and some UI testing in review app Arthur Campbell 2023-04-21 16:52:40 +0100
  • c7065a7000 undo my 'clever' refactor that broke things Arthur Campbell 2023-04-21 09:41:44 +0100
  • b217bc6576 minor amendment to add old_id and reorder early columns Arthur Campbell 2023-04-20 17:38:37 +0100
  • 072bc8bbbc correct various linter complaints and tech review suggestions Arthur Campbell 2023-04-20 17:31:12 +0100
  • 621289abb7
         remove chart.js (#1606) Phil Lee 2023-05-09 11:12:12 +0100
  • dcf46cffa5 Extract charges attributes into a variable Kat 2023-05-09 11:05:51 +0100
  • cac82dfce0 Refactor sale import validations to be consistent with lettings Kat 2023-05-09 11:04:11 +0100
  • 88fe0b296e add relevant links in the UI and pipe everything together in controllers amend organisations controller to have flexibility to download logs of either type add necessary methods to sales log controller, raising shared method to logs controller update routing for amendments and additions extract helper method to build urls for downloading logs within an organisation Arthur Campbell 2023-04-20 15:16:11 +0100
  • b4a9ca3db8 create the SalesLogCsvService create a necessary method on the log to enable submission method to be included on the csv derive values for the two halves of previous postcode for export Arthur Campbell 2023-04-19 17:18:13 +0100
  • 2c440cf2b9 write tests to cover the desired functionality of the SalesLogCsvService Arthur Campbell 2023-04-19 17:17:03 +0100
  • 4ee2aa60d1 update csv email job to accomodate sales log export as well as lettings add to tests to reflec the changes made Arthur Campbell 2023-04-19 17:14:57 +0100
  • b1e040ac5a create a method on the FormHandler that returns the sales form questions for all years in the order that they appear in the form Arthur Campbell 2023-04-19 16:31:15 +0100
  • bc16388a71 remove chart.js Phil Lee 2023-05-09 10:44:29 +0100
  • 3dea3c2a10 Clear income on over_hard_max_for_london validation Kat 2023-05-09 10:33:16 +0100
  • dfb6fb429f Rounds savings to the nearest 10 Kat 2023-05-09 10:21:20 +0100
  • a6d720298c Round earnings value upon import Kat 2023-05-09 10:16:47 +0100
  • 42aa07cc39
         Bump webpack from 5.74.0 to 5.76.0 (#1414) dependabot[bot] 2023-05-09 09:44:10 +0100
  • 6bf582a9a6
         Bump nunjucks from 3.2.3 to 3.2.4 (#1577) dependabot[bot] 2023-05-09 09:43:10 +0100
  • 1409eed9a8 Clear all the charges if the error is on tcharge Kat 2023-05-09 09:26:51 +0100
  • f51ed02276 feat: replace la with uprn, postoce_full, la in all interruption_screen_question_ids natdeanlewissoftwire 2023-05-05 16:44:07 +0100
  • 8a431bf931 feat: update to new soft val designs natdeanlewissoftwire 2023-05-05 15:55:53 +0100
  • c32503b290 Merge branch 'main' into CLDC-2010-discounted-income-soft-max natdeanlewissoftwire 2023-05-05 15:22:34 +0100
  • 6251e302d1 refactor: lint natdeanlewissoftwire 2023-05-05 15:02:00 +0100
  • 2100b87443 feat: update tests natdeanlewissoftwire 2023-05-05 14:54:45 +0100
  • 37eb5cfb74 BU collection window now a setup error Phil Lee 2023-05-05 14:11:02 +0100
  • a3235af4d5 BU invalid options for setup fields Phil Lee 2023-05-05 12:59:21 +0100
  • dafc3e04e3 feat: add new telephone page with failing error tests natdeanlewissoftwire 2023-05-05 12:33:16 +0100
  • e49aa315d9 fix rebase issues Phil Lee 2023-05-05 10:44:50 +0100
  • be2b3911a2 fix 2023 lettings setup errors Phil Lee 2023-04-24 16:50:57 +0100
  • feaefcdd5d fix setup errors for bulk upload validation Phil Lee 2023-04-21 15:52:21 +0100
  • 99cb26b934
         CLDC-2296 Display soft validation errors on bulk upload (#1594) v0.3.18 kosiakkatrina 2023-05-04 17:57:41 +0100
  • 4244752f71 Rebase fix Kat 2023-05-04 17:29:52 +0100
  • 4e489b5300
         CLDC-2288 ensure derived answers cleared when renewal changed from yes to no (#1596) Arthur Campbell 2023-05-04 17:26:42 +0100
  • b75a551145 Update test based on new validation messages Kat 2023-05-02 17:22:05 +0100
  • bbecf25681 Import helper methods Kat 2023-04-28 10:57:14 +0100
  • 34ca2484f7 Only add soft validations once Kat 2023-04-28 09:47:26 +0100
  • 356f026eba Add errors for optional soft validations Kat 2023-04-28 09:23:10 +0100
  • ffc38f18a6 Add soft validations to lettings logs 23/24 bulk upload Kat 2023-04-27 16:04:08 +0100
  • ea45229317 Add soft validations to sales bulk upload Kat 2023-04-27 16:03:41 +0100
  • 056bb823c4 Use interruption_screen_question_ids to set soft validation errors on relevant fields Kat 2023-04-27 15:05:30 +0100
  • a92d66143d Update is_referrer_interruption_screen? check and naming Kat 2023-04-27 09:09:30 +0100
  • ede7aa21db Add affected_question_ids to pregnancy check Kat 2023-04-24 15:14:16 +0100
  • 284d460d87 feat: run clearing twice in case first clear creates different errors natdeanlewissoftwire 2023-05-04 17:05:34 +0100
  • fe8333b3f4 minor changes after tech review Arthur Campbell 2023-05-03 14:25:14 +0100
  • c41591ef86 remove some tests which are now duplicated above, refactor tests using Jack's wonderful :change suggestion, add in tests about logic deriving vacdays that was not previously covered Arthur Campbell 2023-05-02 14:54:53 +0100
  • def9c57148 refactor derivation logic to share functionality with sales logs where possible Arthur Campbell 2023-04-28 15:23:22 +0100
  • 96a4e53c5f update lettings log tests around derivations related to renewal Arthur Campbell 2023-04-28 12:41:52 +0100
  • 6c22ea8b55 extract reusable logic from SalesLogVariables to independent module Arthur Campbell 2023-04-28 07:29:26 +0100
  • 358edce566 remove comment Arthur Campbell 2023-04-21 14:40:18 +0100
  • b16a390319 show related method in diff Arthur Campbell 2023-04-19 09:45:15 +0100
  • 84420a15ec add a validation to prevent an inconsistent combination of values and tests for this validation Arthur Campbell 2023-04-19 09:15:11 +0100
  • 745e1e7e4b
         CLDC-2248 Improve soft validations (#1584) kosiakkatrina 2023-05-04 16:49:33 +0100
  • 89c1fc542b
         ensure that validation errors about tenancy length are added to needstype (#1599) Arthur Campbell 2023-05-04 16:45:27 +0100
  • b6ff1b9d29
         CLDC-2060 Add new organisation address question (#1602) kosiakkatrina 2023-05-04 14:52:03 +0100
  • 1dc53457d1 Merge remote-tracking branch 'origin/CLDC-2262-clear-validations-data-when-correcting' into CLDC-2262-clear-validations-data-when-correcting natdeanlewissoftwire 2023-05-04 14:47:50 +0100
  • c382882c2f feat: clear errors natdeanlewissoftwire 2023-05-04 14:47:28 +0100
  • 91010e51b0 update sidekiq natdeanlewissoftwire 2023-05-04 14:47:28 +0100
  • 4ba31837ae Merge branch 'main' into CLDC-2262-clear-validations-data-when-correcting natdeanlewissoftwire 2023-05-04 14:14:33 +0100
  • 317d935b32 Merge branch 'main' into CLDC-2262-clear-validations-data-when-correcting natdeanlewissoftwire 2023-05-04 13:42:55 +0100
  • 4b02d43885 close the div Kat 2023-05-04 12:57:20 +0100
  • c965b0d8b3 Add new organisation telephone number placeholder page Kat 2023-05-04 12:46:36 +0100
  • feb6c83aac Add new organisation address page Kat 2023-05-04 12:44:04 +0100
  • 80eb1acd63 Add new organisation address fields to merge requests Kat 2023-05-04 12:16:39 +0100
  • d8a67040b3
         CLDC-2058 Add merging organisation name question (#1598) kosiakkatrina 2023-05-04 12:48:56 +0100
  • 9463410c03 Update which field we add the errors to Kat 2023-05-03 11:38:47 +0100
  • 0985b36e9b Extract some validations to the model Kat 2023-05-03 11:19:11 +0100
  • 86f65b41d1 Refactor error messages Kat 2023-05-03 09:19:19 +0100
  • fa885d9cc0 Add existing organisation name validation Kat 2023-05-02 16:16:31 +0100
  • 77ed03fd72 Add placeholder new_organisation_address page Kat 2023-05-02 16:02:45 +0100