Browse Source

BU invalid options for setup fields

now categorised as setup errors
pull/1585/head
Phil Lee 3 years ago
parent
commit
a3235af4d5
  1. 6
      app/services/bulk_upload/lettings/year2022/row_parser.rb
  2. 6
      app/services/bulk_upload/lettings/year2023/row_parser.rb
  3. 10
      spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb
  4. 8
      spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

6
app/services/bulk_upload/lettings/year2022/row_parser.rb

@ -455,7 +455,11 @@ private
fields = field_mapping_for_errors[question_id.to_sym] || []
fields.each do |field|
errors.add(field, I18n.t("validations.invalid_option", question: QUESTIONS[field]))
if setup_question?(question)
errors.add(field, I18n.t("validations.invalid_option", question: QUESTIONS[field]), category: :setup)
else
errors.add(field, I18n.t("validations.invalid_option", question: QUESTIONS[field]))
end
end
end
end

6
app/services/bulk_upload/lettings/year2023/row_parser.rb

@ -472,7 +472,11 @@ private
fields = field_mapping_for_errors[question_id.to_sym] || []
fields.each do |field|
errors.add(field, I18n.t("validations.invalid_option", question: QUESTIONS[field]))
if setup_question?(question)
errors.add(field, I18n.t("validations.invalid_option", question: QUESTIONS[field]), category: :setup)
else
errors.add(field, I18n.t("validations.invalid_option", question: QUESTIONS[field]))
end
end
end
end

10
spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb

@ -949,6 +949,16 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do
end
end
describe "#field_134" do # renewal
context "when none possible option selected" do
let(:attributes) { setup_section_params.merge({ field_134: "101" }) }
it "adds a setup error" do
expect(parser.errors.where(:field_134, category: :setup).map(&:message)).to include("Enter a valid value for Is this letting a renewal?")
end
end
end
describe "soft validations" do
context "when soft validation is triggered" do
let(:attributes) { setup_section_params.merge({ field_12: 22, field_35: 5 }) }

8
spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

@ -903,6 +903,14 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do
expect(parser.errors.where(:field_6, category: :setup).map(&:message)).to eql(["You must answer property renewal"])
end
end
context "when none possible option selected" do
let(:attributes) { setup_section_params.merge({ field_6: "101" }) }
it "adds a setup error" do
expect(parser.errors.where(:field_6, category: :setup).map(&:message)).to include("Enter a valid value for Is this letting a renewal?")
end
end
end
describe "#field_18" do # UPRN

Loading…
Cancel
Save