Remove return statement to ensure fallback redirection

2 years ago · f971dcae31
2 changed files with 2 additions and 2 deletions
--- a/app/controllers/bulk_upload_lettings_logs_controller.rb
+++ b/app/controllers/bulk_upload_lettings_logs_controller.rb
@ -3,7 +3,7 @@ class BulkUploadLettingsLogsController < ApplicationController
  before_action :validate_data_protection_agrement_signed!

  def start
-    support_user_redirection and return if current_user.support?
+    support_user_redirection if current_user.support?

    if have_choice_of_year?
      redirect_to bulk_upload_lettings_log_path(id: "year")
--- a/app/controllers/bulk_upload_sales_logs_controller.rb
+++ b/app/controllers/bulk_upload_sales_logs_controller.rb
@ -3,7 +3,7 @@ class BulkUploadSalesLogsController < ApplicationController
  before_action :validate_data_protection_agrement_signed!

  def start
-    support_user_redirection and return if current_user.support?
+    support_user_redirection if current_user.support?

    if have_choice_of_year?
      redirect_to bulk_upload_sales_log_path(id: "year")