From f971dcae31c3759fe7c9ec85703f186bcd9bea3c Mon Sep 17 00:00:00 2001 From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com> Date: Wed, 11 Sep 2024 12:02:39 +0100 Subject: [PATCH] Remove return statement to ensure fallback redirection --- app/controllers/bulk_upload_lettings_logs_controller.rb | 2 +- app/controllers/bulk_upload_sales_logs_controller.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/bulk_upload_lettings_logs_controller.rb b/app/controllers/bulk_upload_lettings_logs_controller.rb index 93c5541f4..42046ca07 100644 --- a/app/controllers/bulk_upload_lettings_logs_controller.rb +++ b/app/controllers/bulk_upload_lettings_logs_controller.rb @@ -3,7 +3,7 @@ class BulkUploadLettingsLogsController < ApplicationController before_action :validate_data_protection_agrement_signed! def start - support_user_redirection and return if current_user.support? + support_user_redirection if current_user.support? if have_choice_of_year? redirect_to bulk_upload_lettings_log_path(id: "year") diff --git a/app/controllers/bulk_upload_sales_logs_controller.rb b/app/controllers/bulk_upload_sales_logs_controller.rb index 1efa22499..61dc8b86f 100644 --- a/app/controllers/bulk_upload_sales_logs_controller.rb +++ b/app/controllers/bulk_upload_sales_logs_controller.rb @@ -3,7 +3,7 @@ class BulkUploadSalesLogsController < ApplicationController before_action :validate_data_protection_agrement_signed! def start - support_user_redirection and return if current_user.support? + support_user_redirection if current_user.support? if have_choice_of_year? redirect_to bulk_upload_sales_log_path(id: "year")