Browse Source

memoize #valid? method call

pull/1334/head
Phil Lee 3 years ago
parent
commit
bb37d3bc21
  1. 6
      app/services/bulk_upload/lettings/year2022/row_parser.rb
  2. 6
      app/services/bulk_upload/lettings/year2023/row_parser.rb

6
app/services/bulk_upload/lettings/year2022/row_parser.rb

@ -339,9 +339,11 @@ class BulkUpload::Lettings::Year2022::RowParser
end end
def valid? def valid?
return @valid if @valid
errors.clear errors.clear
return true if blank_row? return @valid = true if blank_row?
super(:before_log) super(:before_log)
before_errors = errors.dup before_errors = errors.dup
@ -361,7 +363,7 @@ class BulkUpload::Lettings::Year2022::RowParser
end end
end end
errors.blank? @valid = errors.blank?
end end
def blank_row? def blank_row?

6
app/services/bulk_upload/lettings/year2023/row_parser.rb

@ -344,9 +344,11 @@ class BulkUpload::Lettings::Year2023::RowParser
end end
def valid? def valid?
return @valid if @valid
errors.clear errors.clear
return true if blank_row? return @valid = true if blank_row?
super(:before_log) super(:before_log)
before_errors = errors.dup before_errors = errors.dup
@ -366,7 +368,7 @@ class BulkUpload::Lettings::Year2023::RowParser
end end
end end
errors.blank? @valid = errors.blank?
end end
def blank_row? def blank_row?

Loading…
Cancel
Save