From bb37d3bc212cad10008c01dc1659a4091caae78f Mon Sep 17 00:00:00 2001 From: Phil Lee Date: Wed, 12 Apr 2023 11:35:58 +0100 Subject: [PATCH] memoize #valid? method call --- app/services/bulk_upload/lettings/year2022/row_parser.rb | 6 ++++-- app/services/bulk_upload/lettings/year2023/row_parser.rb | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/app/services/bulk_upload/lettings/year2022/row_parser.rb b/app/services/bulk_upload/lettings/year2022/row_parser.rb index e828015e6..a3fbbc5af 100644 --- a/app/services/bulk_upload/lettings/year2022/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2022/row_parser.rb @@ -339,9 +339,11 @@ class BulkUpload::Lettings::Year2022::RowParser end def valid? + return @valid if @valid + errors.clear - return true if blank_row? + return @valid = true if blank_row? super(:before_log) before_errors = errors.dup @@ -361,7 +363,7 @@ class BulkUpload::Lettings::Year2022::RowParser end end - errors.blank? + @valid = errors.blank? end def blank_row? diff --git a/app/services/bulk_upload/lettings/year2023/row_parser.rb b/app/services/bulk_upload/lettings/year2023/row_parser.rb index 918361638..c2e21346b 100644 --- a/app/services/bulk_upload/lettings/year2023/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/row_parser.rb @@ -344,9 +344,11 @@ class BulkUpload::Lettings::Year2023::RowParser end def valid? + return @valid if @valid + errors.clear - return true if blank_row? + return @valid = true if blank_row? super(:before_log) before_errors = errors.dup @@ -366,7 +368,7 @@ class BulkUpload::Lettings::Year2023::RowParser end end - errors.blank? + @valid = errors.blank? end def blank_row?