Browse Source

correct linting errors

pull/1776/head
Arthur Campbell 3 years ago committed by Kat
parent
commit
aa0c4c5c14
  1. 4
      app/controllers/duplicate_logs_controller.rb
  2. 4
      spec/requests/duplicate_logs_controller_spec.rb

4
app/controllers/duplicate_logs_controller.rb

@ -29,8 +29,8 @@ class DuplicateLogsController < ApplicationController
@duplicates = params.permit(duplicates: {})[:duplicates]&.to_h || duplicates_for_user(current_user)
return render_not_found unless @duplicates
@duplicates[:lettings] ||= []
@duplicates[:sales] ||= []
@duplicates[:lettings] ||= {}
@duplicates[:sales] ||= {}
@duplicate_sets_count = @duplicates[:lettings].count + @duplicates[:sales].count
end

4
spec/requests/duplicate_logs_controller_spec.rb

@ -352,6 +352,7 @@ RSpec.describe DuplicateLogsController, type: :request do
}
end
# rubocop:disable RSpec/AnyInstance
context "when duplicates are not provided in the params" do
before do
allow_any_instance_of(DuplicateLogsHelper).to receive(:duplicates_for_user).and_return duplicates
@ -365,7 +366,7 @@ RSpec.describe DuplicateLogsController, type: :request do
context "when duplicates are provided in the params" do
it "does not call the helper method" do
expect_any_instance_of(DuplicateLogsHelper).not_to receive :duplicates_for_user # rubocop:disable RSpec/AnyInstance
expect_any_instance_of(DuplicateLogsHelper).not_to receive :duplicates_for_user
get duplicate_logs_path(duplicates:)
end
@ -377,6 +378,7 @@ RSpec.describe DuplicateLogsController, type: :request do
end
end
end
# rubocop:enable RSpec/AnyInstance
describe "viewing the page" do
before do

Loading…
Cancel
Save