From aa0c4c5c14c504c951271e560b8b14579b20632b Mon Sep 17 00:00:00 2001 From: Arthur Campbell Date: Fri, 21 Jul 2023 09:50:40 +0100 Subject: [PATCH] correct linting errors --- app/controllers/duplicate_logs_controller.rb | 4 ++-- spec/requests/duplicate_logs_controller_spec.rb | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/controllers/duplicate_logs_controller.rb b/app/controllers/duplicate_logs_controller.rb index cb97d56cf..34656f4a8 100644 --- a/app/controllers/duplicate_logs_controller.rb +++ b/app/controllers/duplicate_logs_controller.rb @@ -29,8 +29,8 @@ class DuplicateLogsController < ApplicationController @duplicates = params.permit(duplicates: {})[:duplicates]&.to_h || duplicates_for_user(current_user) return render_not_found unless @duplicates - @duplicates[:lettings] ||= [] - @duplicates[:sales] ||= [] + @duplicates[:lettings] ||= {} + @duplicates[:sales] ||= {} @duplicate_sets_count = @duplicates[:lettings].count + @duplicates[:sales].count end diff --git a/spec/requests/duplicate_logs_controller_spec.rb b/spec/requests/duplicate_logs_controller_spec.rb index d9520eba3..123a7117b 100644 --- a/spec/requests/duplicate_logs_controller_spec.rb +++ b/spec/requests/duplicate_logs_controller_spec.rb @@ -352,6 +352,7 @@ RSpec.describe DuplicateLogsController, type: :request do } end + # rubocop:disable RSpec/AnyInstance context "when duplicates are not provided in the params" do before do allow_any_instance_of(DuplicateLogsHelper).to receive(:duplicates_for_user).and_return duplicates @@ -365,7 +366,7 @@ RSpec.describe DuplicateLogsController, type: :request do context "when duplicates are provided in the params" do it "does not call the helper method" do - expect_any_instance_of(DuplicateLogsHelper).not_to receive :duplicates_for_user # rubocop:disable RSpec/AnyInstance + expect_any_instance_of(DuplicateLogsHelper).not_to receive :duplicates_for_user get duplicate_logs_path(duplicates:) end @@ -377,6 +378,7 @@ RSpec.describe DuplicateLogsController, type: :request do end end end + # rubocop:enable RSpec/AnyInstance describe "viewing the page" do before do