Browse Source

refactor: linting

pull/1378/head
natdeanlewissoftwire 3 years ago
parent
commit
9416bc3986
  1. 15
      spec/services/imports/lettings_logs_import_service_spec.rb

15
spec/services/imports/lettings_logs_import_service_spec.rb

@ -1,7 +1,9 @@
require "rails_helper" require "rails_helper"
RSpec.describe Imports::LettingsLogsImportService do RSpec.describe Imports::LettingsLogsImportService do
context "in 21/22" do context "with 21/22 logs" do
subject(:lettings_log_service) { described_class.new(storage_service, logger) }
around do |example| around do |example|
Timecop.freeze(Time.zone.local(2022, 1, 1)) do Timecop.freeze(Time.zone.local(2022, 1, 1)) do
Singleton.__init__(FormHandler) Singleton.__init__(FormHandler)
@ -11,8 +13,6 @@ RSpec.describe Imports::LettingsLogsImportService do
Singleton.__init__(FormHandler) Singleton.__init__(FormHandler)
end end
subject(:lettings_log_service) { described_class.new(storage_service, logger) }
let(:storage_service) { instance_double(Storage::S3Service) } let(:storage_service) { instance_double(Storage::S3Service) }
let(:logger) { instance_double(ActiveSupport::Logger) } let(:logger) { instance_double(ActiveSupport::Logger) }
@ -448,7 +448,9 @@ RSpec.describe Imports::LettingsLogsImportService do
end end
end end
context "in 22/23" do context "with 22/23 logs" do
subject(:lettings_log_service) { described_class.new(storage_service, logger) }
around do |example| around do |example|
Timecop.freeze(Time.zone.local(2023, 1, 1)) do Timecop.freeze(Time.zone.local(2023, 1, 1)) do
Singleton.__init__(FormHandler) Singleton.__init__(FormHandler)
@ -458,8 +460,6 @@ RSpec.describe Imports::LettingsLogsImportService do
Singleton.__init__(FormHandler) Singleton.__init__(FormHandler)
end end
subject(:lettings_log_service) { described_class.new(storage_service, logger) }
let(:storage_service) { instance_double(Storage::S3Service) } let(:storage_service) { instance_double(Storage::S3Service) }
let(:logger) { instance_double(ActiveSupport::Logger) } let(:logger) { instance_double(ActiveSupport::Logger) }
@ -527,7 +527,7 @@ RSpec.describe Imports::LettingsLogsImportService do
it "only updates existing lettings logs" do it "only updates existing lettings logs" do
expect(logger).not_to receive(:error) expect(logger).not_to receive(:error)
expect(logger).not_to receive(:warn) expect(logger).not_to receive(:warn)
expect(logger).to receive(:info).with(/Updating lettings log/).exactly(1).times expect(logger).to receive(:info).with(/Updating lettings log/).once
expect { 2.times { lettings_log_service.create_logs(remote_folder) } } expect { 2.times { lettings_log_service.create_logs(remote_folder) } }
.to change(LettingsLog, :count).by(1) .to change(LettingsLog, :count).by(1)
end end
@ -540,5 +540,4 @@ RSpec.describe Imports::LettingsLogsImportService do
end end
end end
end end
end end

Loading…
Cancel
Save