From 9416bc398664e082430890e8120cc52e65023eca Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Tue, 14 Mar 2023 09:23:04 +0000 Subject: [PATCH] refactor: linting --- .../lettings_logs_import_service_spec.rb | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/spec/services/imports/lettings_logs_import_service_spec.rb b/spec/services/imports/lettings_logs_import_service_spec.rb index fde8e22a5..bfd907620 100644 --- a/spec/services/imports/lettings_logs_import_service_spec.rb +++ b/spec/services/imports/lettings_logs_import_service_spec.rb @@ -1,7 +1,9 @@ require "rails_helper" RSpec.describe Imports::LettingsLogsImportService do - context "in 21/22" do + context "with 21/22 logs" do + subject(:lettings_log_service) { described_class.new(storage_service, logger) } + around do |example| Timecop.freeze(Time.zone.local(2022, 1, 1)) do Singleton.__init__(FormHandler) @@ -11,8 +13,6 @@ RSpec.describe Imports::LettingsLogsImportService do Singleton.__init__(FormHandler) end - subject(:lettings_log_service) { described_class.new(storage_service, logger) } - let(:storage_service) { instance_double(Storage::S3Service) } let(:logger) { instance_double(ActiveSupport::Logger) } @@ -393,7 +393,7 @@ RSpec.describe Imports::LettingsLogsImportService do hard_max: 1500, soft_min: 500, hard_min: 100, - ) + ) end it "completes the log" do @@ -448,7 +448,9 @@ RSpec.describe Imports::LettingsLogsImportService do end end - context "in 22/23" do + context "with 22/23 logs" do + subject(:lettings_log_service) { described_class.new(storage_service, logger) } + around do |example| Timecop.freeze(Time.zone.local(2023, 1, 1)) do Singleton.__init__(FormHandler) @@ -458,8 +460,6 @@ RSpec.describe Imports::LettingsLogsImportService do Singleton.__init__(FormHandler) end - subject(:lettings_log_service) { described_class.new(storage_service, logger) } - let(:storage_service) { instance_double(Storage::S3Service) } let(:logger) { instance_double(ActiveSupport::Logger) } @@ -527,7 +527,7 @@ RSpec.describe Imports::LettingsLogsImportService do it "only updates existing lettings logs" do expect(logger).not_to receive(:error) expect(logger).not_to receive(:warn) - expect(logger).to receive(:info).with(/Updating lettings log/).exactly(1).times + expect(logger).to receive(:info).with(/Updating lettings log/).once expect { 2.times { lettings_log_service.create_logs(remote_folder) } } .to change(LettingsLog, :count).by(1) end @@ -540,5 +540,4 @@ RSpec.describe Imports::LettingsLogsImportService do end end end - end