Browse Source

feat: avoid duplicated errors

pull/1570/head
natdeanlewissoftwire 3 years ago
parent
commit
8bfbcb9426
  1. 2
      app/models/lettings_log.rb
  2. 2
      app/models/log.rb
  3. 2
      app/models/sales_log.rb

2
app/models/lettings_log.rb

@ -521,10 +521,8 @@ class LettingsLog < Log
def blank_compound_invalid_non_setup_fields! def blank_compound_invalid_non_setup_fields!
super super
validate_property_postcode(self)
self.postcode_known = nil if errors.of_kind?(:postcode_full, :wrong_format) self.postcode_known = nil if errors.of_kind?(:postcode_full, :wrong_format)
validate_net_income(self)
if errors.of_kind?(:earnings, :under_hard_min) if errors.of_kind?(:earnings, :under_hard_min)
self.earnings = nil self.earnings = nil
self.incfreq = nil self.incfreq = nil

2
app/models/log.rb

@ -141,10 +141,8 @@ class Log < ApplicationRecord
end end
def blank_compound_invalid_non_setup_fields! def blank_compound_invalid_non_setup_fields!
validate_previous_accommodation_postcode(self)
self.ppcodenk = nil if errors.of_kind?(:ppostcode_full, :wrong_format) self.ppcodenk = nil if errors.of_kind?(:ppostcode_full, :wrong_format)
process_uprn_change!
if errors.of_kind?(:uprn, :uprn_error) if errors.of_kind?(:uprn, :uprn_error)
self.uprn_known = 0 self.uprn_known = 0
self.uprn_confirmed = nil self.uprn_confirmed = nil

2
app/models/sales_log.rb

@ -359,10 +359,8 @@ class SalesLog < Log
def blank_compound_invalid_non_setup_fields! def blank_compound_invalid_non_setup_fields!
super super
validate_property_postcode(self)
self.pcodenk = nil if errors.of_kind?(:postcode_full, :wrong_format) self.pcodenk = nil if errors.of_kind?(:postcode_full, :wrong_format)
validate_previous_postcode(self)
if errors.of_kind?(:postcode_full, :postcodes_not_matching) if errors.of_kind?(:postcode_full, :postcodes_not_matching)
self.ppcodenk = nil self.ppcodenk = nil
end end

Loading…
Cancel
Save