From 8bfbcb9426b4741c6270c18d0399963e946d0243 Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
Date: Wed, 26 Apr 2023 11:44:41 +0100
Subject: [PATCH] feat: avoid duplicated errors

---
 app/models/lettings_log.rb | 2 --
 app/models/log.rb          | 2 --
 app/models/sales_log.rb    | 2 --
 3 files changed, 6 deletions(-)

diff --git a/app/models/lettings_log.rb b/app/models/lettings_log.rb
index b168cffa5..ae1760c67 100644
--- a/app/models/lettings_log.rb
+++ b/app/models/lettings_log.rb
@@ -521,10 +521,8 @@ class LettingsLog < Log
   def blank_compound_invalid_non_setup_fields!
     super
 
-    validate_property_postcode(self)
     self.postcode_known = nil if errors.of_kind?(:postcode_full, :wrong_format)
 
-    validate_net_income(self)
     if errors.of_kind?(:earnings, :under_hard_min)
       self.earnings = nil
       self.incfreq = nil
diff --git a/app/models/log.rb b/app/models/log.rb
index 9089f82f2..8012f8a43 100644
--- a/app/models/log.rb
+++ b/app/models/log.rb
@@ -141,10 +141,8 @@ class Log < ApplicationRecord
   end
 
   def blank_compound_invalid_non_setup_fields!
-    validate_previous_accommodation_postcode(self)
     self.ppcodenk = nil if errors.of_kind?(:ppostcode_full, :wrong_format)
 
-    process_uprn_change!
     if errors.of_kind?(:uprn, :uprn_error)
       self.uprn_known = 0
       self.uprn_confirmed = nil
diff --git a/app/models/sales_log.rb b/app/models/sales_log.rb
index d8ed31f0b..1b5deea75 100644
--- a/app/models/sales_log.rb
+++ b/app/models/sales_log.rb
@@ -359,10 +359,8 @@ class SalesLog < Log
   def blank_compound_invalid_non_setup_fields!
     super
 
-    validate_property_postcode(self)
     self.pcodenk = nil if errors.of_kind?(:postcode_full, :wrong_format)
 
-    validate_previous_postcode(self)
     if errors.of_kind?(:postcode_full, :postcodes_not_matching)
       self.ppcodenk = nil
     end