Browse Source

Initialize service with organisation instead of a hash

pull/1953/head
Kat 3 years ago
parent
commit
6db0fd0907
  1. 2
      app/jobs/email_missing_addresses_csv_job.rb
  2. 4
      spec/jobs/email_missing_addresses_csv_job_spec.rb

2
app/jobs/email_missing_addresses_csv_job.rb

@ -4,7 +4,7 @@ class EmailMissingAddressesCsvJob < ApplicationJob
BYTE_ORDER_MARK = "\uFEFF".freeze # Required to ensure Excel always reads CSV as UTF-8 BYTE_ORDER_MARK = "\uFEFF".freeze # Required to ensure Excel always reads CSV as UTF-8
def perform(user_ids, organisation, log_type) def perform(user_ids, organisation, log_type)
csv_service = Csv::MissingAddressesCsvService.new(organisation:) csv_service = Csv::MissingAddressesCsvService.new(organisation)
case log_type case log_type
when "lettings" when "lettings"
csv_string = csv_service.create_missing_lettings_addresses_csv csv_string = csv_service.create_missing_lettings_addresses_csv

4
spec/jobs/email_missing_addresses_csv_job_spec.rb

@ -33,7 +33,7 @@ describe EmailMissingAddressesCsvJob do
end end
it "creates a MissingAddressesCsvService with the correct organisation and calls create missing lettings logs adresses csv" do it "creates a MissingAddressesCsvService with the correct organisation and calls create missing lettings logs adresses csv" do
expect(Csv::MissingAddressesCsvService).to receive(:new).with(organisation:) expect(Csv::MissingAddressesCsvService).to receive(:new).with(organisation)
expect(missing_addresses_csv_service).to receive(:create_missing_lettings_addresses_csv) expect(missing_addresses_csv_service).to receive(:create_missing_lettings_addresses_csv)
job.perform(users.map(&:id), organisation, "lettings") job.perform(users.map(&:id), organisation, "lettings")
end end
@ -52,7 +52,7 @@ describe EmailMissingAddressesCsvJob do
end end
it "creates a MissingAddressesCsvService with the correct organisation and calls create missing sales logs adresses csv" do it "creates a MissingAddressesCsvService with the correct organisation and calls create missing sales logs adresses csv" do
expect(Csv::MissingAddressesCsvService).to receive(:new).with(organisation:) expect(Csv::MissingAddressesCsvService).to receive(:new).with(organisation)
expect(missing_addresses_csv_service).to receive(:create_missing_sales_addresses_csv) expect(missing_addresses_csv_service).to receive(:create_missing_sales_addresses_csv)
job.perform(users.map(&:id), organisation, "sales") job.perform(users.map(&:id), organisation, "sales")
end end

Loading…
Cancel
Save