From 6db0fd0907b62ca0e189b87063645a35e9d1d0a7 Mon Sep 17 00:00:00 2001 From: Kat Date: Tue, 3 Oct 2023 08:40:07 +0100 Subject: [PATCH] Initialize service with organisation instead of a hash --- app/jobs/email_missing_addresses_csv_job.rb | 2 +- spec/jobs/email_missing_addresses_csv_job_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/jobs/email_missing_addresses_csv_job.rb b/app/jobs/email_missing_addresses_csv_job.rb index 181d7414f..23af581c4 100644 --- a/app/jobs/email_missing_addresses_csv_job.rb +++ b/app/jobs/email_missing_addresses_csv_job.rb @@ -4,7 +4,7 @@ class EmailMissingAddressesCsvJob < ApplicationJob BYTE_ORDER_MARK = "\uFEFF".freeze # Required to ensure Excel always reads CSV as UTF-8 def perform(user_ids, organisation, log_type) - csv_service = Csv::MissingAddressesCsvService.new(organisation:) + csv_service = Csv::MissingAddressesCsvService.new(organisation) case log_type when "lettings" csv_string = csv_service.create_missing_lettings_addresses_csv diff --git a/spec/jobs/email_missing_addresses_csv_job_spec.rb b/spec/jobs/email_missing_addresses_csv_job_spec.rb index 6b22ce121..a6dfb235b 100644 --- a/spec/jobs/email_missing_addresses_csv_job_spec.rb +++ b/spec/jobs/email_missing_addresses_csv_job_spec.rb @@ -33,7 +33,7 @@ describe EmailMissingAddressesCsvJob do end it "creates a MissingAddressesCsvService with the correct organisation and calls create missing lettings logs adresses csv" do - expect(Csv::MissingAddressesCsvService).to receive(:new).with(organisation:) + expect(Csv::MissingAddressesCsvService).to receive(:new).with(organisation) expect(missing_addresses_csv_service).to receive(:create_missing_lettings_addresses_csv) job.perform(users.map(&:id), organisation, "lettings") end @@ -52,7 +52,7 @@ describe EmailMissingAddressesCsvJob do end it "creates a MissingAddressesCsvService with the correct organisation and calls create missing sales logs adresses csv" do - expect(Csv::MissingAddressesCsvService).to receive(:new).with(organisation:) + expect(Csv::MissingAddressesCsvService).to receive(:new).with(organisation) expect(missing_addresses_csv_service).to receive(:create_missing_sales_addresses_csv) job.perform(users.map(&:id), organisation, "sales") end