Browse Source

feat: don't display error row components for rows with no errors

pull/2235/head
natdeanlewissoftwire 2 years ago
parent
commit
613bdaa2e8
  1. 4
      app/views/bulk_upload_lettings_resume/deletion_report.html.erb
  2. 2
      app/views/bulk_upload_sales_resume/deletion_report.html.erb

4
app/views/bulk_upload_lettings_resume/deletion_report.html.erb

@ -18,7 +18,9 @@
<div class="govuk-grid-row"> <div class="govuk-grid-row">
<div class="govuk-grid-column-full"> <div class="govuk-grid-column-full">
<% @bulk_upload.bulk_upload_errors.order_by_row.order_by_cell.group_by(&:row).each do |_row, errors_for_row| %> <% @bulk_upload.bulk_upload_errors.order_by_row.order_by_cell.group_by(&:row).each do |_row, errors_for_row| %>
<%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: all_answers_to_be_cleared(errors_for_row)) %> <% if all_answers_to_be_cleared(errors_for_row).present? %>
<%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: all_answers_to_be_cleared(errors_for_row)) if errors_for_row.present? %>
<% end %>
<% end %> <% end %>
</div> </div>
</div> </div>

2
app/views/bulk_upload_sales_resume/deletion_report.html.erb

@ -18,8 +18,10 @@
<div class="govuk-grid-row"> <div class="govuk-grid-row">
<div class="govuk-grid-column-full"> <div class="govuk-grid-column-full">
<% @bulk_upload.bulk_upload_errors.order_by_row.order_by_cell.group_by(&:row).each do |_row, errors_for_row| %> <% @bulk_upload.bulk_upload_errors.order_by_row.order_by_cell.group_by(&:row).each do |_row, errors_for_row| %>
<% if all_answers_to_be_cleared(errors_for_row).present? %>
<%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: all_answers_to_be_cleared(errors_for_row)) %> <%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: all_answers_to_be_cleared(errors_for_row)) %>
<% end %> <% end %>
<% end %>
</div> </div>
</div> </div>

Loading…
Cancel
Save