From 613bdaa2e8dd95f2b65d76a74cc58eca2c567385 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Mon, 12 Feb 2024 16:36:21 +0000 Subject: [PATCH] feat: don't display error row components for rows with no errors --- .../bulk_upload_lettings_resume/deletion_report.html.erb | 4 +++- app/views/bulk_upload_sales_resume/deletion_report.html.erb | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/views/bulk_upload_lettings_resume/deletion_report.html.erb b/app/views/bulk_upload_lettings_resume/deletion_report.html.erb index 2624012d4..58518bda5 100644 --- a/app/views/bulk_upload_lettings_resume/deletion_report.html.erb +++ b/app/views/bulk_upload_lettings_resume/deletion_report.html.erb @@ -18,7 +18,9 @@
<% @bulk_upload.bulk_upload_errors.order_by_row.order_by_cell.group_by(&:row).each do |_row, errors_for_row| %> - <%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: all_answers_to_be_cleared(errors_for_row)) %> + <% if all_answers_to_be_cleared(errors_for_row).present? %> + <%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: all_answers_to_be_cleared(errors_for_row)) if errors_for_row.present? %> + <% end %> <% end %>
diff --git a/app/views/bulk_upload_sales_resume/deletion_report.html.erb b/app/views/bulk_upload_sales_resume/deletion_report.html.erb index 3b6088c3c..299cff4f4 100644 --- a/app/views/bulk_upload_sales_resume/deletion_report.html.erb +++ b/app/views/bulk_upload_sales_resume/deletion_report.html.erb @@ -18,7 +18,9 @@
<% @bulk_upload.bulk_upload_errors.order_by_row.order_by_cell.group_by(&:row).each do |_row, errors_for_row| %> - <%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: all_answers_to_be_cleared(errors_for_row)) %> + <% if all_answers_to_be_cleared(errors_for_row).present? %> + <%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: all_answers_to_be_cleared(errors_for_row)) %> + <% end %> <% end %>