Browse Source

CLDC-2863: update 'maintenance' to 'service unavailable' in tests

pull/2022/head
Sam Seed 3 years ago
parent
commit
4b5fdf7262
  1. 4
      spec/controllers/maintenance_controller_spec.rb
  2. 4
      spec/features/user_spec.rb
  3. 4
      spec/requests/content_controller_spec.rb
  4. 4
      spec/requests/cookies_controller_spec.rb
  5. 18
      spec/requests/maintenance_controller_spec.rb

4
spec/controllers/maintenance_controller_spec.rb

@ -4,7 +4,7 @@ RSpec.describe MaintenanceController do
let(:user) { FactoryBot.create(:user) } let(:user) { FactoryBot.create(:user) }
describe "GET #service_unavailable" do describe "GET #service_unavailable" do
context "when maintenance mode is enabled" do context "when the service is unavailable" do
it "logs the user out" do it "logs the user out" do
allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) allow(FeatureToggle).to receive(:service_unavailable?).and_return(true)
sign_in user sign_in user
@ -14,7 +14,7 @@ RSpec.describe MaintenanceController do
end end
end end
context "when maintenance mode is disabled" do context "when the service is available" do
it "doesn't log the user out" do it "doesn't log the user out" do
allow(FeatureToggle).to receive(:service_unavailable?).and_return(false) allow(FeatureToggle).to receive(:service_unavailable?).and_return(false)
sign_in user sign_in user

4
spec/features/user_spec.rb

@ -140,7 +140,7 @@ RSpec.describe "User Features" do
expect(page).to have_content("Sign in to your account to submit CORE data") expect(page).to have_content("Sign in to your account to submit CORE data")
end end
it "does not show 'Sign in' link if maintenance mode is enabled" do it "does not show 'Sign in' link when the service is unavailable" do
allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) allow(FeatureToggle).to receive(:service_unavailable?).and_return(true)
visit("/lettings-logs") visit("/lettings-logs")
expect(page).not_to have_link("Sign in") expect(page).not_to have_link("Sign in")
@ -331,7 +331,7 @@ RSpec.describe "User Features" do
expect(page).to have_selector('[data-qa="change-key-contact"]') expect(page).to have_selector('[data-qa="change-key-contact"]')
end end
it "does not show 'Your account' or 'Sign out' links if maintenance mode is enabled" do it "does not show 'Your account' or 'Sign out' links when the service is unavailable" do
allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) allow(FeatureToggle).to receive(:service_unavailable?).and_return(true)
visit("/lettings-logs") visit("/lettings-logs")
expect(page).not_to have_link("Your account") expect(page).not_to have_link("Your account")

4
spec/requests/content_controller_spec.rb

@ -4,7 +4,7 @@ RSpec.describe ContentController, type: :request do
let(:headers) { { "Accept" => "text/html" } } let(:headers) { { "Accept" => "text/html" } }
let(:page) { Capybara::Node::Simple.new(response.body) } let(:page) { Capybara::Node::Simple.new(response.body) }
describe "when maintenance mode is disabled" do describe "when the service is available" do
describe "render privacy notice content page" do describe "render privacy notice content page" do
before do before do
get "/privacy-notice", headers:, params: {} get "/privacy-notice", headers:, params: {}
@ -48,7 +48,7 @@ RSpec.describe ContentController, type: :request do
end end
end end
describe "when maintenance mode is enabled" do describe "when the service is unavailable" do
before do before do
allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) allow(FeatureToggle).to receive(:service_unavailable?).and_return(true)
end end

4
spec/requests/cookies_controller_spec.rb

@ -4,7 +4,7 @@ RSpec.describe CookiesController, type: :request do
let(:headers) { { "Accept" => "text/html" } } let(:headers) { { "Accept" => "text/html" } }
let(:page) { Capybara::Node::Simple.new(response.body) } let(:page) { Capybara::Node::Simple.new(response.body) }
describe "when maintenance mode is disabled" do describe "when the service is available" do
describe "render cookies page" do describe "render cookies page" do
before do before do
get "/cookies", headers:, params: {} get "/cookies", headers:, params: {}
@ -20,7 +20,7 @@ RSpec.describe CookiesController, type: :request do
end end
end end
describe "when maintenance mode is enabled" do describe "when the service is unavailable" do
before do before do
allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) allow(FeatureToggle).to receive(:service_unavailable?).and_return(true)
end end

18
spec/requests/maintenance_controller_spec.rb

@ -8,17 +8,17 @@ RSpec.describe MaintenanceController, type: :request do
sign_in user sign_in user
end end
describe "when maintenance mode is enabled" do describe "when the service is unavailable" do
before do before do
allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) allow(FeatureToggle).to receive(:service_unavailable?).and_return(true)
end end
context "when a user visits a page other than the maintenance page" do context "when a user visits a page other than the service unavailable page" do
before do before do
get "/lettings-logs" get "/lettings-logs"
end end
it "redirects the user to the maintenance page" do it "redirects the user to the service unavailable page" do
expect(response).to redirect_to(service_unavailable_path) expect(response).to redirect_to(service_unavailable_path)
follow_redirect! follow_redirect!
expect(page).to have_content("Sorry, the service is unavailable") expect(page).to have_content("Sorry, the service is unavailable")
@ -30,12 +30,12 @@ RSpec.describe MaintenanceController, type: :request do
end end
end end
context "when a user visits the maintenance page" do context "when a user visits the service unavailable page" do
before do before do
get "/service-unavailable" get "/service-unavailable"
end end
it "keeps the user on the maintenance page" do it "keeps the user on the service unavailable page" do
expect(response).not_to redirect_to(service_unavailable_path) expect(response).not_to redirect_to(service_unavailable_path)
expect(page).to have_content("Sorry, the service is unavailable") expect(page).to have_content("Sorry, the service is unavailable")
end end
@ -46,17 +46,17 @@ RSpec.describe MaintenanceController, type: :request do
end end
end end
describe "when maintenance mode is disabled" do describe "when the service is available" do
before do before do
allow(FeatureToggle).to receive(:service_unavailable?).and_return(false) allow(FeatureToggle).to receive(:service_unavailable?).and_return(false)
end end
context "when a user visits a page other than the maintenance page" do context "when a user visits a page other than the service unavailable page" do
before do before do
get "/lettings-logs" get "/lettings-logs"
end end
it "doesn't redirect the user to the maintenance page" do it "doesn't redirect the user to the service unavailable page" do
expect(response).not_to redirect_to(service_unavailable_path) expect(response).not_to redirect_to(service_unavailable_path)
expect(page).to have_content("Create a new lettings log") expect(page).to have_content("Create a new lettings log")
end end
@ -66,7 +66,7 @@ RSpec.describe MaintenanceController, type: :request do
end end
end end
context "when a user visits the maintenance page" do context "when a user visits the service unavailable page" do
before do before do
get "/service-unavailable" get "/service-unavailable"
end end

Loading…
Cancel
Save