From 4b5fdf72622faa757d85df0a8d3adc7189181bf8 Mon Sep 17 00:00:00 2001 From: Sam Seed Date: Mon, 6 Nov 2023 17:50:01 +0000 Subject: [PATCH] CLDC-2863: update 'maintenance' to 'service unavailable' in tests --- .../controllers/maintenance_controller_spec.rb | 4 ++-- spec/features/user_spec.rb | 4 ++-- spec/requests/content_controller_spec.rb | 4 ++-- spec/requests/cookies_controller_spec.rb | 4 ++-- spec/requests/maintenance_controller_spec.rb | 18 +++++++++--------- 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/spec/controllers/maintenance_controller_spec.rb b/spec/controllers/maintenance_controller_spec.rb index 8d27f1588..7318927ea 100644 --- a/spec/controllers/maintenance_controller_spec.rb +++ b/spec/controllers/maintenance_controller_spec.rb @@ -4,7 +4,7 @@ RSpec.describe MaintenanceController do let(:user) { FactoryBot.create(:user) } describe "GET #service_unavailable" do - context "when maintenance mode is enabled" do + context "when the service is unavailable" do it "logs the user out" do allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) sign_in user @@ -14,7 +14,7 @@ RSpec.describe MaintenanceController do end end - context "when maintenance mode is disabled" do + context "when the service is available" do it "doesn't log the user out" do allow(FeatureToggle).to receive(:service_unavailable?).and_return(false) sign_in user diff --git a/spec/features/user_spec.rb b/spec/features/user_spec.rb index 285ddef27..f691b07ad 100644 --- a/spec/features/user_spec.rb +++ b/spec/features/user_spec.rb @@ -140,7 +140,7 @@ RSpec.describe "User Features" do expect(page).to have_content("Sign in to your account to submit CORE data") end - it "does not show 'Sign in' link if maintenance mode is enabled" do + it "does not show 'Sign in' link when the service is unavailable" do allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) visit("/lettings-logs") expect(page).not_to have_link("Sign in") @@ -331,7 +331,7 @@ RSpec.describe "User Features" do expect(page).to have_selector('[data-qa="change-key-contact"]') end - it "does not show 'Your account' or 'Sign out' links if maintenance mode is enabled" do + it "does not show 'Your account' or 'Sign out' links when the service is unavailable" do allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) visit("/lettings-logs") expect(page).not_to have_link("Your account") diff --git a/spec/requests/content_controller_spec.rb b/spec/requests/content_controller_spec.rb index 35068682b..dda4ebf25 100644 --- a/spec/requests/content_controller_spec.rb +++ b/spec/requests/content_controller_spec.rb @@ -4,7 +4,7 @@ RSpec.describe ContentController, type: :request do let(:headers) { { "Accept" => "text/html" } } let(:page) { Capybara::Node::Simple.new(response.body) } - describe "when maintenance mode is disabled" do + describe "when the service is available" do describe "render privacy notice content page" do before do get "/privacy-notice", headers:, params: {} @@ -48,7 +48,7 @@ RSpec.describe ContentController, type: :request do end end - describe "when maintenance mode is enabled" do + describe "when the service is unavailable" do before do allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) end diff --git a/spec/requests/cookies_controller_spec.rb b/spec/requests/cookies_controller_spec.rb index ef530c930..24ebda135 100644 --- a/spec/requests/cookies_controller_spec.rb +++ b/spec/requests/cookies_controller_spec.rb @@ -4,7 +4,7 @@ RSpec.describe CookiesController, type: :request do let(:headers) { { "Accept" => "text/html" } } let(:page) { Capybara::Node::Simple.new(response.body) } - describe "when maintenance mode is disabled" do + describe "when the service is available" do describe "render cookies page" do before do get "/cookies", headers:, params: {} @@ -20,7 +20,7 @@ RSpec.describe CookiesController, type: :request do end end - describe "when maintenance mode is enabled" do + describe "when the service is unavailable" do before do allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) end diff --git a/spec/requests/maintenance_controller_spec.rb b/spec/requests/maintenance_controller_spec.rb index 1e8251518..7f808c927 100644 --- a/spec/requests/maintenance_controller_spec.rb +++ b/spec/requests/maintenance_controller_spec.rb @@ -8,17 +8,17 @@ RSpec.describe MaintenanceController, type: :request do sign_in user end - describe "when maintenance mode is enabled" do + describe "when the service is unavailable" do before do allow(FeatureToggle).to receive(:service_unavailable?).and_return(true) end - context "when a user visits a page other than the maintenance page" do + context "when a user visits a page other than the service unavailable page" do before do get "/lettings-logs" end - it "redirects the user to the maintenance page" do + it "redirects the user to the service unavailable page" do expect(response).to redirect_to(service_unavailable_path) follow_redirect! expect(page).to have_content("Sorry, the service is unavailable") @@ -30,12 +30,12 @@ RSpec.describe MaintenanceController, type: :request do end end - context "when a user visits the maintenance page" do + context "when a user visits the service unavailable page" do before do get "/service-unavailable" end - it "keeps the user on the maintenance page" do + it "keeps the user on the service unavailable page" do expect(response).not_to redirect_to(service_unavailable_path) expect(page).to have_content("Sorry, the service is unavailable") end @@ -46,17 +46,17 @@ RSpec.describe MaintenanceController, type: :request do end end - describe "when maintenance mode is disabled" do + describe "when the service is available" do before do allow(FeatureToggle).to receive(:service_unavailable?).and_return(false) end - context "when a user visits a page other than the maintenance page" do + context "when a user visits a page other than the service unavailable page" do before do get "/lettings-logs" end - it "doesn't redirect the user to the maintenance page" do + it "doesn't redirect the user to the service unavailable page" do expect(response).not_to redirect_to(service_unavailable_path) expect(page).to have_content("Create a new lettings log") end @@ -66,7 +66,7 @@ RSpec.describe MaintenanceController, type: :request do end end - context "when a user visits the maintenance page" do + context "when a user visits the service unavailable page" do before do get "/service-unavailable" end