refactor: gsub not tr

3 years ago · 2a51340ed4
4 changed files with 4 additions and 4 deletions
--- a/app/services/bulk_upload/lettings/year2022/csv_parser.rb
+++ b/app/services/bulk_upload/lettings/year2022/csv_parser.rb
@ -93,7 +93,7 @@ private
    @normalised_string = File.read(path, encoding: "bom|utf-8")
    @normalised_string.gsub!("\r\n", "\n")
    @normalised_string.gsub!("\r\r", "\n")
-    @normalised_string.tr!("\r", "\n")
+    @normalised_string.gsub!("\r", "\n")
    @normalised_string.scrub!("")

    @normalised_string
--- a/app/services/bulk_upload/lettings/year2023/csv_parser.rb
+++ b/app/services/bulk_upload/lettings/year2023/csv_parser.rb
@ -98,7 +98,7 @@ private
    @normalised_string = File.read(path, encoding: "bom|utf-8")
    @normalised_string.gsub!("\r\n", "\n")
    @normalised_string.gsub!("\r\r", "\n")
-    @normalised_string.tr!("\r", "\n")
+    @normalised_string.gsub!("\r", "\n")
    @normalised_string.scrub!("")

    @normalised_string
--- a/app/services/bulk_upload/sales/year2022/csv_parser.rb
+++ b/app/services/bulk_upload/sales/year2022/csv_parser.rb
@ -67,7 +67,7 @@ private
    @normalised_string = File.read(path, encoding: "bom|utf-8")
    @normalised_string.gsub!("\r\n", "\n")
    @normalised_string.gsub!("\r\r", "\n")
-    @normalised_string.tr!("\r", "\n")
+    @normalised_string.gsub!("\r", "\n")
    @normalised_string.scrub!("")

    @normalised_string
--- a/app/services/bulk_upload/sales/year2023/csv_parser.rb
+++ b/app/services/bulk_upload/sales/year2023/csv_parser.rb
@ -93,7 +93,7 @@ private
    @normalised_string = File.read(path, encoding: "bom|utf-8")
    @normalised_string.gsub!("\r\n", "\n")
    @normalised_string.gsub!("\r\r", "\n")
-    @normalised_string.tr!("\r", "\n")
+    @normalised_string.gsub!("\r", "\n")
    @normalised_string.scrub!("")

    @normalised_string