From 2a51340ed45deb6b8350b0ab3bfe42404e401f83 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Mon, 5 Jun 2023 11:59:38 +0100 Subject: [PATCH] refactor: gsub not tr --- app/services/bulk_upload/lettings/year2022/csv_parser.rb | 2 +- app/services/bulk_upload/lettings/year2023/csv_parser.rb | 2 +- app/services/bulk_upload/sales/year2022/csv_parser.rb | 2 +- app/services/bulk_upload/sales/year2023/csv_parser.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/services/bulk_upload/lettings/year2022/csv_parser.rb b/app/services/bulk_upload/lettings/year2022/csv_parser.rb index 2ff3fa0db..4015a9784 100644 --- a/app/services/bulk_upload/lettings/year2022/csv_parser.rb +++ b/app/services/bulk_upload/lettings/year2022/csv_parser.rb @@ -93,7 +93,7 @@ private @normalised_string = File.read(path, encoding: "bom|utf-8") @normalised_string.gsub!("\r\n", "\n") @normalised_string.gsub!("\r\r", "\n") - @normalised_string.tr!("\r", "\n") + @normalised_string.gsub!("\r", "\n") @normalised_string.scrub!("") @normalised_string diff --git a/app/services/bulk_upload/lettings/year2023/csv_parser.rb b/app/services/bulk_upload/lettings/year2023/csv_parser.rb index 0538c994f..f5cea8f24 100644 --- a/app/services/bulk_upload/lettings/year2023/csv_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/csv_parser.rb @@ -98,7 +98,7 @@ private @normalised_string = File.read(path, encoding: "bom|utf-8") @normalised_string.gsub!("\r\n", "\n") @normalised_string.gsub!("\r\r", "\n") - @normalised_string.tr!("\r", "\n") + @normalised_string.gsub!("\r", "\n") @normalised_string.scrub!("") @normalised_string diff --git a/app/services/bulk_upload/sales/year2022/csv_parser.rb b/app/services/bulk_upload/sales/year2022/csv_parser.rb index d0b79b29b..5f857c135 100644 --- a/app/services/bulk_upload/sales/year2022/csv_parser.rb +++ b/app/services/bulk_upload/sales/year2022/csv_parser.rb @@ -67,7 +67,7 @@ private @normalised_string = File.read(path, encoding: "bom|utf-8") @normalised_string.gsub!("\r\n", "\n") @normalised_string.gsub!("\r\r", "\n") - @normalised_string.tr!("\r", "\n") + @normalised_string.gsub!("\r", "\n") @normalised_string.scrub!("") @normalised_string diff --git a/app/services/bulk_upload/sales/year2023/csv_parser.rb b/app/services/bulk_upload/sales/year2023/csv_parser.rb index 23549e561..27fd98ae3 100644 --- a/app/services/bulk_upload/sales/year2023/csv_parser.rb +++ b/app/services/bulk_upload/sales/year2023/csv_parser.rb @@ -93,7 +93,7 @@ private @normalised_string = File.read(path, encoding: "bom|utf-8") @normalised_string.gsub!("\r\n", "\n") @normalised_string.gsub!("\r\r", "\n") - @normalised_string.tr!("\r", "\n") + @normalised_string.gsub!("\r", "\n") @normalised_string.scrub!("") @normalised_string