Browse Source

refactor: linting

pull/1378/head
natdeanlewissoftwire 3 years ago
parent
commit
28627bd24c
  1. 1
      spec/helpers/tasklist_helper_spec.rb
  2. 1
      spec/models/lettings_log_spec.rb
  3. 12
      spec/requests/lettings_logs_controller_spec.rb

1
spec/helpers/tasklist_helper_spec.rb

@ -34,7 +34,6 @@ RSpec.describe TasklistHelper do
allow(FormHandler.instance).to receive(:get_form).and_return(fake_2021_2022_form) allow(FormHandler.instance).to receive(:get_form).and_return(fake_2021_2022_form)
end end
it "returns the total of sections if no status is given" do it "returns the total of sections if no status is given" do
expect(get_subsections_count(empty_lettings_log)).to eq(8) expect(get_subsections_count(empty_lettings_log)).to eq(8)
end end

1
spec/models/lettings_log_spec.rb

@ -1989,7 +1989,6 @@ RSpec.describe LettingsLog do
Timecop.unfreeze Timecop.unfreeze
end end
context "and a scheme with a single log is selected" do context "and a scheme with a single log is selected" do
before do before do
Timecop.freeze(2022, 4, 2) Timecop.freeze(2022, 4, 2)

12
spec/requests/lettings_logs_controller_spec.rb

@ -829,9 +829,6 @@ RSpec.describe LettingsLogsController, type: :request do
before do before do
sign_in user sign_in user
get "/lettings-logs/#{lettings_log.id}", headers:, params: {} get "/lettings-logs/#{lettings_log.id}", headers:, params: {}
end
before do
Timecop.freeze(2021, 4, 1) Timecop.freeze(2021, 4, 1)
completed_lettings_log.update!(startdate: Time.zone.local(2021, 4, 1), voiddate: Time.zone.local(2021, 4, 1), mrcdate: Time.zone.local(2021, 4, 1)) completed_lettings_log.update!(startdate: Time.zone.local(2021, 4, 1), voiddate: Time.zone.local(2021, 4, 1), mrcdate: Time.zone.local(2021, 4, 1))
completed_lettings_log.reload completed_lettings_log.reload
@ -931,6 +928,9 @@ RSpec.describe LettingsLogsController, type: :request do
Timecop.freeze(2021, 4, 1) Timecop.freeze(2021, 4, 1)
completed_lettings_log.update!(startdate: Time.zone.local(2021, 4, 1), voiddate: Time.zone.local(2021, 4, 1), mrcdate: Time.zone.local(2021, 4, 1)) completed_lettings_log.update!(startdate: Time.zone.local(2021, 4, 1), voiddate: Time.zone.local(2021, 4, 1), mrcdate: Time.zone.local(2021, 4, 1))
Timecop.unfreeze Timecop.unfreeze
stub_request(:get, /api.postcodes.io/)
.to_return(status: 200, body: "{\"status\":200,\"result\":{\"admin_district\":\"Manchester\", \"codes\":{\"admin_district\": \"E08000003\"}}}", headers: {})
sign_in user
end end
let(:postcode_lettings_log) do let(:postcode_lettings_log) do
@ -941,12 +941,6 @@ RSpec.describe LettingsLogsController, type: :request do
let(:id) { postcode_lettings_log.id } let(:id) { postcode_lettings_log.id }
let(:completed_lettings_log) { FactoryBot.create(:lettings_log, :completed, owning_organisation: user.organisation, managing_organisation: user.organisation, created_by: user) } let(:completed_lettings_log) { FactoryBot.create(:lettings_log, :completed, owning_organisation: user.organisation, managing_organisation: user.organisation, created_by: user) }
before do
stub_request(:get, /api.postcodes.io/)
.to_return(status: 200, body: "{\"status\":200,\"result\":{\"admin_district\":\"Manchester\", \"codes\":{\"admin_district\": \"E08000003\"}}}", headers: {})
sign_in user
end
it "shows the inferred la" do it "shows the inferred la" do
lettings_log = FactoryBot.create(:lettings_log, lettings_log = FactoryBot.create(:lettings_log,
created_by: user, created_by: user,

Loading…
Cancel
Save