From 28627bd24c5be81b42a504437fe943ec4e72d65e Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Thu, 16 Mar 2023 09:42:39 +0000 Subject: [PATCH] refactor: linting --- spec/helpers/tasklist_helper_spec.rb | 9 ++++----- spec/models/lettings_log_spec.rb | 1 - spec/requests/lettings_logs_controller_spec.rb | 12 +++--------- 3 files changed, 7 insertions(+), 15 deletions(-) diff --git a/spec/helpers/tasklist_helper_spec.rb b/spec/helpers/tasklist_helper_spec.rb index 1343eca81..22f5abcb6 100644 --- a/spec/helpers/tasklist_helper_spec.rb +++ b/spec/helpers/tasklist_helper_spec.rb @@ -34,7 +34,6 @@ RSpec.describe TasklistHelper do allow(FormHandler.instance).to receive(:get_form).and_return(fake_2021_2022_form) end - it "returns the total of sections if no status is given" do expect(get_subsections_count(empty_lettings_log)).to eq(8) end @@ -112,8 +111,8 @@ RSpec.describe TasklistHelper do it "returns relevant text" do expect(review_log_text(lettings_log)).to eq( - "You can #{govuk_link_to 'review and make changes to this log', review_lettings_log_path(lettings_log)} until 1 July 2023.".html_safe, - ) + "You can #{govuk_link_to 'review and make changes to this log', review_lettings_log_path(lettings_log)} until 1 July 2023.".html_safe, + ) end end @@ -123,8 +122,8 @@ RSpec.describe TasklistHelper do it "returns relevant text" do expect(review_log_text(lettings_log)).to eq( - "You can #{govuk_link_to 'review and make changes to this log', review_lettings_log_path(lettings_log)} until 9 July 2024.".html_safe, - ) + "You can #{govuk_link_to 'review and make changes to this log', review_lettings_log_path(lettings_log)} until 9 July 2024.".html_safe, + ) end end end diff --git a/spec/models/lettings_log_spec.rb b/spec/models/lettings_log_spec.rb index 7e0d78403..ba0967270 100644 --- a/spec/models/lettings_log_spec.rb +++ b/spec/models/lettings_log_spec.rb @@ -1989,7 +1989,6 @@ RSpec.describe LettingsLog do Timecop.unfreeze end - context "and a scheme with a single log is selected" do before do Timecop.freeze(2022, 4, 2) diff --git a/spec/requests/lettings_logs_controller_spec.rb b/spec/requests/lettings_logs_controller_spec.rb index 74b6eac96..b06cdecab 100644 --- a/spec/requests/lettings_logs_controller_spec.rb +++ b/spec/requests/lettings_logs_controller_spec.rb @@ -829,9 +829,6 @@ RSpec.describe LettingsLogsController, type: :request do before do sign_in user get "/lettings-logs/#{lettings_log.id}", headers:, params: {} - end - - before do Timecop.freeze(2021, 4, 1) completed_lettings_log.update!(startdate: Time.zone.local(2021, 4, 1), voiddate: Time.zone.local(2021, 4, 1), mrcdate: Time.zone.local(2021, 4, 1)) completed_lettings_log.reload @@ -931,6 +928,9 @@ RSpec.describe LettingsLogsController, type: :request do Timecop.freeze(2021, 4, 1) completed_lettings_log.update!(startdate: Time.zone.local(2021, 4, 1), voiddate: Time.zone.local(2021, 4, 1), mrcdate: Time.zone.local(2021, 4, 1)) Timecop.unfreeze + stub_request(:get, /api.postcodes.io/) + .to_return(status: 200, body: "{\"status\":200,\"result\":{\"admin_district\":\"Manchester\", \"codes\":{\"admin_district\": \"E08000003\"}}}", headers: {}) + sign_in user end let(:postcode_lettings_log) do @@ -941,12 +941,6 @@ RSpec.describe LettingsLogsController, type: :request do let(:id) { postcode_lettings_log.id } let(:completed_lettings_log) { FactoryBot.create(:lettings_log, :completed, owning_organisation: user.organisation, managing_organisation: user.organisation, created_by: user) } - before do - stub_request(:get, /api.postcodes.io/) - .to_return(status: 200, body: "{\"status\":200,\"result\":{\"admin_district\":\"Manchester\", \"codes\":{\"admin_district\": \"E08000003\"}}}", headers: {}) - sign_in user - end - it "shows the inferred la" do lettings_log = FactoryBot.create(:lettings_log, created_by: user,