Browse Source

set no cache headers

pull/1670/head
Phil Lee 3 years ago committed by Kat
parent
commit
24e13b9156
  1. 5
      app/controllers/bulk_upload_lettings_resume_controller.rb
  2. 12
      spec/requests/bulk_upload_lettings_resume_controller_spec.rb

5
app/controllers/bulk_upload_lettings_resume_controller.rb

@ -1,5 +1,10 @@
class BulkUploadLettingsResumeController < ApplicationController class BulkUploadLettingsResumeController < ApplicationController
before_action :authenticate_user! before_action :authenticate_user!
before_action :set_no_cache_headers
def set_no_cache_headers
response.set_header("Cache-Control", "no-store")
end
def start def start
@bulk_upload = current_user.bulk_uploads.find(params[:id]) @bulk_upload = current_user.bulk_uploads.find(params[:id])

12
spec/requests/bulk_upload_lettings_resume_controller_spec.rb

@ -30,6 +30,12 @@ RSpec.describe BulkUploadLettingsResumeController, type: :request do
expect(response.body).not_to include("Cancel") expect(response.body).not_to include("Cancel")
end end
it "sets no cache headers" do
get "/lettings-logs/bulk-upload-resume/#{bulk_upload.id}/fix-choice"
expect(response.headers["Cache-Control"]).to eql("no-store")
end
context "and previosuly told us to fix inline" do context "and previosuly told us to fix inline" do
let(:bulk_upload) { create(:bulk_upload, :lettings, user:, bulk_upload_errors:, choice: "create-fix-inline") } let(:bulk_upload) { create(:bulk_upload, :lettings, user:, bulk_upload_errors:, choice: "create-fix-inline") }
@ -93,6 +99,12 @@ RSpec.describe BulkUploadLettingsResumeController, type: :request do
expect(response.body).to include("Are you sure") expect(response.body).to include("Are you sure")
end end
it "sets no cache headers" do
get "/lettings-logs/bulk-upload-resume/#{bulk_upload.id}/confirm"
expect(response.headers["Cache-Control"]).to eql("no-store")
end
context "and previosuly told us to fix inline" do context "and previosuly told us to fix inline" do
let(:bulk_upload) { create(:bulk_upload, :lettings, user:, bulk_upload_errors:, choice: "create-fix-inline") } let(:bulk_upload) { create(:bulk_upload, :lettings, user:, bulk_upload_errors:, choice: "create-fix-inline") }

Loading…
Cancel
Save