From 24e13b9156e2974fca9e64d7816da41bc9bf73da Mon Sep 17 00:00:00 2001 From: Phil Lee Date: Thu, 25 May 2023 14:27:19 +0100 Subject: [PATCH] set no cache headers --- .../bulk_upload_lettings_resume_controller.rb | 5 +++++ .../bulk_upload_lettings_resume_controller_spec.rb | 12 ++++++++++++ 2 files changed, 17 insertions(+) diff --git a/app/controllers/bulk_upload_lettings_resume_controller.rb b/app/controllers/bulk_upload_lettings_resume_controller.rb index 29a7c90aa..132ca095b 100644 --- a/app/controllers/bulk_upload_lettings_resume_controller.rb +++ b/app/controllers/bulk_upload_lettings_resume_controller.rb @@ -1,5 +1,10 @@ class BulkUploadLettingsResumeController < ApplicationController before_action :authenticate_user! + before_action :set_no_cache_headers + + def set_no_cache_headers + response.set_header("Cache-Control", "no-store") + end def start @bulk_upload = current_user.bulk_uploads.find(params[:id]) diff --git a/spec/requests/bulk_upload_lettings_resume_controller_spec.rb b/spec/requests/bulk_upload_lettings_resume_controller_spec.rb index 0197a79cc..1fc94bb1c 100644 --- a/spec/requests/bulk_upload_lettings_resume_controller_spec.rb +++ b/spec/requests/bulk_upload_lettings_resume_controller_spec.rb @@ -30,6 +30,12 @@ RSpec.describe BulkUploadLettingsResumeController, type: :request do expect(response.body).not_to include("Cancel") end + it "sets no cache headers" do + get "/lettings-logs/bulk-upload-resume/#{bulk_upload.id}/fix-choice" + + expect(response.headers["Cache-Control"]).to eql("no-store") + end + context "and previosuly told us to fix inline" do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, bulk_upload_errors:, choice: "create-fix-inline") } @@ -93,6 +99,12 @@ RSpec.describe BulkUploadLettingsResumeController, type: :request do expect(response.body).to include("Are you sure") end + it "sets no cache headers" do + get "/lettings-logs/bulk-upload-resume/#{bulk_upload.id}/confirm" + + expect(response.headers["Cache-Control"]).to eql("no-store") + end + context "and previosuly told us to fix inline" do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, bulk_upload_errors:, choice: "create-fix-inline") }