baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Commit Graph

  • 0ccfbc874e correct linting errors Arthur Campbell 2023-06-15 12:16:13 +0100
  • a954bcb617 feat: update tests natdeanlewissoftwire 2023-06-15 12:09:58 +0100
  • 7971079a8f feat: fix error labels for address questions and update row parsers natdeanlewissoftwire 2023-06-15 12:09:52 +0100
  • 285e158782 CLDC-1507: 'Rent Type' headed added above question Aaron Spencer 2023-06-15 12:04:30 +0100
  • c2b9c7048f respond to PO feedback the log id in the delte logs table should be a link to the log the delete logs button should be visible when the user is in a bulk upload journey updated associated tests Arthur Campbell 2023-06-15 11:17:16 +0100
  • 4e3000daac Validate managing and owning org DPC presence Jack S 2023-06-15 09:22:23 +0100
  • 789bf1fc77 CLDC-1507: rent explanation added to rent type question page. Aaron Spencer 2023-06-15 10:42:14 +0100
  • f75fa4c949 feat: fix error labels for address questions natdeanlewissoftwire 2023-06-15 10:34:28 +0100
  • 6880db1fe6 Only set @interruption_page_id if http referrer is provided Kat 2023-06-15 10:16:31 +0100
  • 38da80d902 add tests for calculate_status that implicitly also check if the factory traits for copmleted are working also some minor renaming and refactoring Arthur Campbell 2023-06-15 09:53:49 +0100
  • 90ec300681 fix linting Phil Lee 2023-05-25 15:24:00 +0100
  • ab54241690 set no cache headers for sales Phil Lee 2023-05-25 15:00:57 +0100
  • d18e3c46fb add chosen to sales journey Phil Lee 2023-05-25 14:57:58 +0100
  • 24e13b9156 set no cache headers Phil Lee 2023-05-25 14:27:19 +0100
  • 8da99eb51a fix choice decision persisted Phil Lee 2023-05-25 14:24:05 +0100
  • 5e7ca8670e persist how to fix choice Phil Lee 2023-05-25 10:29:47 +0100
  • d6d046904f protect against stack level errors in the case where a log has the status in progress but due to changes in the form should now have the status completed further update the lettings log factory as the :completed trait was producing logs that were not copmlete Arthur Campbell 2023-06-14 18:00:38 +0100
  • a9de740914 feat: update some tests natdeanlewissoftwire 2023-06-14 17:19:19 +0100
  • c9b8a60c79 feat: update cya sales natdeanlewissoftwire 2023-06-14 17:11:44 +0100
  • cbea66760a feat: update cya design lettings natdeanlewissoftwire 2023-06-14 17:09:40 +0100
  • acb4b09fec CLDC-2328: Flash now shows email address, Button moved. Aaron Spencer 2023-06-14 16:44:53 +0100
  • db3d8e4b0c feat: test ALL possibilities natdeanlewissoftwire 2023-06-14 15:11:14 +0100
  • da43274b27 feat: update tests natdeanlewissoftwire 2023-06-14 14:20:09 +0100
  • ca58ed8b44 feat: fix bug natdeanlewissoftwire 2023-06-14 14:04:51 +0100
  • dd0f996339 lint: add new line at end of file Arthur Campbell 2023-06-14 14:03:20 +0100
  • 6ea3557db5 minor change in the reset confirmation method to avoid errors if email in params is nil Arthur Campbell 2023-06-14 12:59:00 +0100
  • 2ce4489be2 write tests for the delete logs form object Arthur Campbell 2023-06-14 12:19:21 +0100
  • 7e32f6c71f temp Arthur Campbell 2023-06-14 10:01:29 +0100
  • cd38461927 minor refactors after rebasing onto Nat's work Arthur Campbell 2023-06-13 16:21:15 +0100
  • f753846a18 minor refactor of lettings log feature spec setup, replicate happy path for sales Arthur Campbell 2023-06-13 11:24:32 +0100
  • c96db5251e replicate request specs from lettings for sales and organisations controllers Arthur Campbell 2023-06-13 11:24:06 +0100
  • 820ad60d79 simplify tests for whether delete logs button appears on index page Arthur Campbell 2023-06-12 16:22:22 +0100
  • 47b782834f revert change, causing errors and outside the scope of this ticket Arthur Campbell 2023-06-09 15:58:02 +0100
  • 99f45cf909 minor linting corrections Arthur Campbell 2023-06-09 14:20:45 +0100
  • c154febda0 ensure delete logs button is always visible on log lists when in the organisations tab Arthur Campbell 2023-06-09 14:06:22 +0100
  • c3d527e3bb implement dirty fiddle to get the checkboxes smaller and also not misaligned Arthur Campbell 2023-06-09 13:56:59 +0100
  • 7cb90c6210 test new helper methods Arthur Campbell 2023-06-09 13:42:31 +0100
  • 99613aea6f remove unnecessary untested arguments Arthur Campbell 2023-06-09 13:42:11 +0100
  • 91533d0308 refactor delete logs controller after tech review improve the private method that builds the form object so that it has the flexibility to do so for all controller methods ensure that the search term is passed to the delete logs controller when navigating through the organisations tab ensure that noly logs for that organisation are displayed when navigating to delete logs through the organisations tab Arthur Campbell 2023-06-07 14:16:46 +0100
  • 080a3e6952 extract tables for lettings and sales to own partials Arthur Campbell 2023-06-07 14:14:05 +0100
  • 4c76b12da9 minor refactor to delete logs controller: ensure session filters are only fetched from teh session when needed and extract discard logs method to private method Arthur Campbell 2023-06-05 16:58:41 +0100
  • 980550f45b merge the delete pages for lettings logs and sales logs, add to the tests for the lettings page to test sales specific content Arthur Campbell 2023-06-05 14:49:03 +0100
  • eabf668ec5 implement the story for lettings and sales logs under the organisation tab routing and controller methods testing for deleting sales logs, lettings or sales logs for an organisation move storage of relevant routes inside the form object as a comprehensive view model Arthur Campbell 2023-06-05 12:26:32 +0100
  • a9f5086c56 implement same work for sales as for lettings Arthur Campbell 2023-06-01 17:22:39 +0100
  • 9883e94198 extract controller methods and associated tests to do with the delete logs feature into their own controller, amend routes accordingly Arthur Campbell 2023-06-01 15:50:05 +0100
  • c7f5eff0f7 alter config to allow creating controllers from the command line with associated spec files that matches how we test Arthur Campbell 2023-06-01 13:38:52 +0100
  • e44aa5a8d2 comprehensive reworking after code review ensure that we are not passing lists of ids through params in the query string, risking overflowing the maximum URL length, adjust tests accordingly, do not attempt to reuse the same table for sales and lettings Arthur Campbell 2023-06-01 13:22:28 +0100
  • 296289c59d create request tests for the DELETE delete-logs path Arthur Campbell 2023-05-25 14:43:44 +0100
  • afeee2b035 create request tests for the GET delete-logs-confirmation path Arthur Campbell 2023-05-25 11:57:30 +0100
  • 347846b324 create request tests for the GET delete-logs path Arthur Campbell 2023-05-25 08:45:31 +0100
  • 9750eed5d3 create basic tests for the view component for listing logs to delete Arthur Campbell 2023-05-25 08:44:55 +0100
  • 92a96a9f3c write a happy path feature test for the entire journey Arthur Campbell 2023-05-22 09:42:51 +0100
  • cbec8d2f94 test appearance of delete logs button on index page for lettings logs Arthur Campbell 2023-05-19 14:21:16 +0100
  • b10fd31369 correct indentation from 4 spaces to 2 in view file Arthur Campbell 2023-05-17 14:19:27 +0100
  • ddf079047c add a button to the logs list to delete multiple logs style and position of button helpers for displaying the button conditionally depending on user role and what filters and search are active Arthur Campbell 2023-05-11 10:44:29 +0100
  • 825076a522
         CLDC-2456 Sales collection year test fixes (#1689) v0.3.29 natdeanlewissoftwire 2023-06-14 12:27:07 +0100
  • 9d98c391a5 CLDC-2372 Remove sales bulk upload feature flag (#1693) natdeanlewissoftwire 2023-06-14 11:40:04 +0100
  • 6053eb18c3
         CLDC-2372 Update bulk upload resources (#1671) kosiakkatrina 2023-06-14 11:39:15 +0100
  • 240e8a03b5
         Cldc 2445 increase offered max (#1692) natdeanlewissoftwire 2023-06-14 11:12:25 +0100
  • debe7c60d0 refactor: update matadata helper natdeanlewissoftwire 2023-06-14 11:09:05 +0100
  • 6941de0b28 Add Data Protection Confirmation on log change Jack S 2023-06-14 09:52:43 +0100
  • ef09edb202 refactor: lint natdeanlewissoftwire 2023-06-14 09:38:14 +0100
  • 352f3125c6 feat: add test for property_number_of_times_relet natdeanlewissoftwire 2023-06-14 09:36:49 +0100
  • 9e0df790b3 feat: remove sales bu feature flag natdeanlewissoftwire 2023-06-14 09:30:54 +0100
  • 7eb3c93c77 feat: revert feature flag removal (will put in a separate PR) natdeanlewissoftwire 2023-06-14 09:28:34 +0100
  • b3935315ce CLDC-2328: Email test refactor. Aaron Spencer 2023-06-13 17:35:15 +0100
  • af7456fb23 feat: update tests natdeanlewissoftwire 2023-06-13 17:07:48 +0100
  • e753e76fee feat: combine identical offered questions natdeanlewissoftwire 2023-06-13 16:41:43 +0100
  • bd87653df8 CLDC-2328: Invite button only appears for support users. Aaron Spencer 2023-06-13 15:46:26 +0100
  • 0621b26aec CLDC-2328: Button uses post instead of get, tests reflect this. Aaron Spencer 2023-06-13 15:45:32 +0100
  • 6d7ce8af16
         CLDC-2319 prevent log creation (#1684) Jack 2023-06-13 14:04:36 +0100
  • c4b2548e63 Address PO review Jack S 2023-06-13 12:28:10 +0100
  • eb4e3dd4c1 feat: add tests for helper natdeanlewissoftwire 2023-06-13 12:21:33 +0100
  • 7aa327149e refactor: erblinting natdeanlewissoftwire 2023-06-13 11:51:06 +0100
  • 4753587667 refactor: lint natdeanlewissoftwire 2023-06-13 11:45:16 +0100
  • 5124f15698 feat: remove sales bu feature toggoe natdeanlewissoftwire 2023-06-13 11:42:26 +0100
  • 625e86cbcb feat: update files, add 22/23 lettings form to local storage and add collection resources helper natdeanlewissoftwire 2023-06-13 11:42:19 +0100
  • 3011311795 Prevent access to bulk upload pages when DPC not signed Jack S 2023-06-13 11:23:22 +0100
  • 2b1b345f66 feat: update previous years natdeanlewissoftwire 2023-06-13 10:31:34 +0100
  • fc31a809f7 rubocop Jack S 2023-06-13 10:25:08 +0100
  • bc5695cca7 Address code review Jack S 2023-06-13 08:05:46 +0100
  • 54584a5949 Use data_protection_confirmed? method Jack S 2023-06-12 14:27:49 +0100
  • 277e3a2e01 Add tests for display_organisation_attributes Jack S 2023-06-12 14:22:33 +0100
  • 5ea21e212e Make tests more generic Jack S 2023-06-08 11:14:30 +0100
  • 491495384a start adapting to data protection confirmation Jack S 2023-06-09 14:10:27 +0100
  • c023a9f0bb Put validation behind feature flag Jack S 2023-06-08 16:33:20 +0100
  • 6c867d7377 Fix factory Jack S 2023-06-08 16:25:54 +0100
  • 94c2ba28fc fix log component Jack S 2023-06-08 09:59:56 +0100
  • f8b46e4faf Add model validation Jack S 2023-06-08 09:07:28 +0100
  • 9e1bac6335 Add banner Jack S 2023-06-02 16:16:40 +0100
  • 204a8e9e1f Add spacing above actions in data sharing agreement Jack S 2023-06-08 09:06:34 +0100
  • e701c7b168 Remove bulk_upload_lettings_logs flag Jack S 2023-06-05 09:14:45 +0100
  • e32354dfca feat: update max and add new spec natdeanlewissoftwire 2023-06-12 16:40:42 +0100
  • b0271ea0ec
         CLDC-2257 Refactor filters (#1675) v0.3.28 natdeanlewissoftwire 2023-06-12 15:45:23 +0100
  • 40a07c3f57
         Reduce Sentry sample rate so that we don't hit our quota (#1691) James Rose 2023-06-12 15:17:06 +0100
  • 2d50657f31 CLDC-2328: Testing of sent emails Aaron Spencer 2023-06-12 14:23:18 +0100
  • 0bde65d6bb feat: update tests natdeanlewissoftwire 2023-06-09 18:00:20 +0100
  • 528dfd0039 feat: revert change to filter manager natdeanlewissoftwire 2023-06-12 12:49:33 +0100
  • 9fdd80e9f2 Merge branch 'main' into CLDC-2257-refactor-filters-3 natdeanlewissoftwire 2023-06-12 12:31:26 +0100
  • d7df68eda7 Reduce Sentry sample rate so that we don't hit our quota James Rose 2023-06-12 11:50:36 +0100