Browse Source

correct linting errors

pull/1698/head
Arthur Campbell 3 years ago
parent
commit
0ccfbc874e
  1. 2
      app/models/form.rb
  2. 2
      spec/models/form_spec.rb
  3. 1
      spec/models/log_spec.rb

2
app/models/form.rb

@ -127,7 +127,7 @@ class Form
if log.status == "completed"
return first_question_in_last_subsection(subsection_ids)
elsif log.calculate_status == "completed"
log.update(status: "completed")
log.update!(status: "completed")
return first_question_in_last_subsection(subsection_ids)
end

2
spec/models/form_spec.rb

@ -210,7 +210,7 @@ RSpec.describe Form, type: :model do
FormHandler.instance.use_real_forms!
end
it "should not raise a Stack Error" do
it "does not raise a Stack Error" do
expect { form.next_incomplete_section_redirect_path(subsection, lettings_log) }.not_to raise_error
end
end

1
spec/models/log_spec.rb

@ -19,7 +19,6 @@ RSpec.describe Log, type: :model do
it "returns the correct status for a completed lettings log" do
complete_lettings_log = create(:lettings_log, :completed, status: nil)
binding.pry
expect(complete_lettings_log.calculate_status).to eq "completed"
end

Loading…
Cancel
Save