From 0ccfbc874e5db3176613a924e0b7a4296a9d3217 Mon Sep 17 00:00:00 2001 From: Arthur Campbell Date: Thu, 15 Jun 2023 12:16:13 +0100 Subject: [PATCH] correct linting errors --- app/models/form.rb | 2 +- spec/models/form_spec.rb | 2 +- spec/models/log_spec.rb | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app/models/form.rb b/app/models/form.rb index 5e33cc94b..1b99dec3a 100644 --- a/app/models/form.rb +++ b/app/models/form.rb @@ -127,7 +127,7 @@ class Form if log.status == "completed" return first_question_in_last_subsection(subsection_ids) elsif log.calculate_status == "completed" - log.update(status: "completed") + log.update!(status: "completed") return first_question_in_last_subsection(subsection_ids) end diff --git a/spec/models/form_spec.rb b/spec/models/form_spec.rb index b113e1c05..439cd24b1 100644 --- a/spec/models/form_spec.rb +++ b/spec/models/form_spec.rb @@ -210,7 +210,7 @@ RSpec.describe Form, type: :model do FormHandler.instance.use_real_forms! end - it "should not raise a Stack Error" do + it "does not raise a Stack Error" do expect { form.next_incomplete_section_redirect_path(subsection, lettings_log) }.not_to raise_error end end diff --git a/spec/models/log_spec.rb b/spec/models/log_spec.rb index 80cc7f813..fb686e744 100644 --- a/spec/models/log_spec.rb +++ b/spec/models/log_spec.rb @@ -19,7 +19,6 @@ RSpec.describe Log, type: :model do it "returns the correct status for a completed lettings log" do complete_lettings_log = create(:lettings_log, :completed, status: nil) - binding.pry expect(complete_lettings_log.calculate_status).to eq "completed" end