fc6689defe
feat: fix typo
3 years ago
7861db285e
Merge branch 'main' into CLDC-868-purchase-price-validations
...
# Conflicts:
# app/models/form/sales/subsections/shared_ownership_scheme.rb
# app/models/sales_log.rb
# app/models/validations/sales/soft_validations.rb
# db/schema.rb
# spec/models/form/sales/subsections/shared_ownership_scheme_spec.rb
# spec/models/form_handler_spec.rb
3 years ago
7bd76c4d32
CLDC-1575 Add shared ownership validations ( #1217 )
...
* Add income error to ownership type and ecstat fields
* Add shared_ownership_deposit_value_check field
* Add shared_ownership_deposit_invalid? soft validation
* Add shared ownership deposit check pages and questions
* Add pages to the subsection and update validation message
* tests
* Update validation to only trigger if la is given
* Run the soft validation when mortgage isn't used or cash discount isn't given
* test
3 years ago
b0cc241926
feat: update docs
3 years ago
2787815a9d
CLDC-878 Validate basic monthly rent ( #1228 )
...
* Validate basic monthly rent
* Make the test description clearer
3 years ago
d65b18d48f
persist column for bulk upload errors ( #1239 )
3 years ago
cdae8964c6
feat: improve currency interruption screen display
3 years ago
9513e1179d
CLDC-1764 Bulk upload filter ( #1223 )
...
* refactor with extract method
* can filter logs by bulk upload
* hide log creation button when viewing bulk upload
- this affects the logs index page filtering logs from a specific bulk
upload
* add info banner to bulk upload logs
* placeholder for bulk upload logs header
* when resuming bulk upload set filters
* fill place holder with remaining logs to fix
* add interstitial to resume if logs resolved
* after resolving bulk upload logs show interstitial
* fix linting error
* extract view variable to helper method
3 years ago
cbbe65cf30
tests: update after merge
3 years ago
8e084d0c61
Add more specs ( #1243 )
3 years ago
9d80f6d245
Add max range to mortgage length ( #1245 )
3 years ago
2f64c66aa9
Merge branch 'main' into CLDC-868-purchase-price-validations
...
# Conflicts:
# app/models/validations/sales/sale_information_validations.rb
# app/models/validations/sales/soft_validations.rb
# config/locales/en.yml
# db/schema.rb
# spec/models/form_handler_spec.rb
# spec/models/validations/sales/sale_information_validations_spec.rb
# spec/models/validations/sales/soft_validations_spec.rb
3 years ago
740f4cbdd4
CLDC-1843 Hide download csv link for sales logs ( #1230 )
...
* Hide download csv link for sales logs
* refactor
3 years ago
0f17eab3fe
CLDC 882 add validation against grant ( #1220 )
...
* fix rebase conflicts
* fix rebase conflicts
* fix rebase conflicts
* implement soft validation of grant value
* fix rebase conflicts
* fix rebase conflicts
* fix rebase conflicts
* fix rebase conflicts
* fix final test from added page
* update test after rebase
3 years ago
99c87f1eb5
feat: respond to PR comments
3 years ago
4659a3efcf
CLDC-1899 Add discounted ownership value validation ( #1229 )
...
* Add validation for discounted ownership value
* Fix tests
* Update validations to work with different routing
* update error message
3 years ago
cd9d0a3755
refactor: revert unnecessary change
3 years ago
4e15a119b9
CLDC-1765 Remove managing organisation for sales log from ui and backend ( #1169 )
...
* feat: remove sales log managing_organisation_id
* feat: move shared managing org behaviour from general log to lettings log, update tests
* refator: linting
* revert change to create
* feat: tech review comments
* db:update
* tests: respond to comment
* feat: revert change to avoid nil issue
* test: update
* feat: add validation and update db
* feat: revert last commit
* db:update
* refactor: use safe navigation and lettings?
* refactor: move safe navigator and add shared org_params to log
3 years ago
a4fbb99a3f
CLDC-1583 Add extra borrowing validation ( #1201 )
...
* feat: add condition-less soft validation and update db
* feat: add validation condition and update tests
* feat: update validation
* feat: update validation
* feat: add tests
* db: update
* test: update
* refactor: linting
* test: update
* feat: update text, remove separate redundant function, add value check page everywhere
* feat: leave value check at end
* test: update
* feat: add value check everywhere
* tests: update
* db:update
* feat: only appear at end
* test: update
* feat: add soft validation everywhere smoothly
* test: update
3 years ago
d67e4710c8
CLDC-861 Add length of stay validations ( #1218 )
...
* faet: add validation and tests
* refactor: linting
* feat: respond to PR comments
3 years ago
1d624131d6
Use interruption_screen? method ( #1238 )
...
More safe than checking whether the question included value_check in their name
3 years ago
4b43e5cb68
CLDC-1848 Update income hint text ( #1236 )
...
* Remove old income guidance text
* Add income hint text
3 years ago
f87023a5f1
Update number of others in the property header ( #1234 )
3 years ago
a235782911
Update rent ranges for 2022 ( #1222 )
...
- The hard max values for rent ranges in 2022 are too conservative and it blocks logs from being migrated from old CORE.
- We can replace this file with correct value as re-run `Imports::RentRangesService` to upsert the existing values.
3 years ago
c2c1b4dbb0
Add mortgage length hint ( #1237 )
3 years ago
56a9cb4bdf
CLDC-864 Add contract exchange date validations ( #1231 )
...
* CLDC-864 Add exdate validations
* Raise missing translation errors
* Fix missing translation
* Remove unused method
* Remove redundant check
3 years ago
9533659a88
Merge branch 'main' into CLDC-868-purchase-price-validations
...
# Conflicts:
# app/models/validations/sales/sale_information_validations.rb
# spec/models/validations/sales/sale_information_validations_spec.rb
3 years ago
1a5a64e18e
handle bulk upload files with boms ( #1233 )
3 years ago
6ca9f851d3
refactor: linting
3 years ago
8ca9cbfb49
Change numeric validation to display prefixes in error message ( #1227 )
...
* change numeric validation
* Fix test, add delimiter and suffix to the numeric error mesage
3 years ago
9475cfc50b
refactor: pratical -> practical
3 years ago
16b6913e00
feat: update i18n
3 years ago
b6bfd1fb6f
feat: use i18n
3 years ago
9271c969a0
feat: allow translation text and title text to display currency formatting even when not a log field
3 years ago
e65d8070d3
refactor: linting
3 years ago
1c677cce3c
test: add purchase price rangeimport service tests
3 years ago
18aa0f4901
test: add validation tests
3 years ago
e0525dc169
feat: update tests
3 years ago
f33b2ec332
refactor: linting
3 years ago
9ef3b38886
refactor: remove duplicated behaviour
3 years ago
ce6f1c7b36
refactor: linting
3 years ago
c5bb9c6eaf
feat: add min and max conditional text
3 years ago
a1681d0a7f
feat: more saledate -> exdate fixing
3 years ago
02281ef12a
db:update
3 years ago
b9557c19d9
Merge branch 'main' into CLDC-868-purchase-price-validations
...
# Conflicts:
# db/schema.rb
3 years ago
be38ac3e39
feat: fix hodate validation and use purchase price ranges
3 years ago
10536ae13f
Update reson answer options ( #1209 )
3 years ago
3308d86a10
Last settled accommodation and discounted ownership property postcodes must match ( #1213 )
3 years ago
cf92c9559c
Add disability and wheelchair questions validation ( #1215 )
...
* Add Page#interruption_screen? method
* Use form helper method
* Validate household disability questions
* Update CYA
3 years ago
45b098ad4b
CLDC-1457 Update checkbox validation message ( #1207 )
3 years ago
natdeanlewissoftwire
kosiakkatrina
Phil Lee
Jack
Arthur Campbell
natdeanlewissoftwire
James Rose