Arthur Campbell
fb48453063
fix test and ensure schema correct after rebase
3 years ago
Arthur Campbell
82c924eed9
fix tests after rebasing
3 years ago
Arthur Campbell
f2f63451b9
amend tests after rebasing
3 years ago
Arthur Campbell
9f1ac16bc2
remove hard validation of range for discount question and allow shared validation of numeric questions to handle this case
3 years ago
Arthur Campbell
2db9d9f9f3
add mortgage to derived variables so that mortgage value is set to 0 if a mortgage is not being used in the sale
3 years ago
Arthur Campbell
fb60ea4f7e
alter order of before validation methods on sales log so that derived fields are calculated after invalidated dependent fields are cleared, fix tests broken by this change
3 years ago
Arthur Campbell
02c918398c
Update config/locales/en.yml
...
Co-authored-by: James Rose <james@jbpr.net>
3 years ago
Arthur Campbell
83e434dc8f
fix rebase conflicts
3 years ago
Arthur Campbell
694df30a61
remove comment
3 years ago
Arthur Campbell
35f9ca3ff3
fix rebase conflicts
3 years ago
Arthur Campbell
d4ce51e155
fix rebase conflicts
3 years ago
Arthur Campbell
10a050e261
implement before validation check to ensure that if the user declares no mortgage will be used, mortgage value is set to 0
3 years ago
Arthur Campbell
98512a311a
fix rebase conflicts
3 years ago
Arthur Campbell
2a47e776ab
fix rebase conflicts
3 years ago
Arthur Campbell
54e18260e3
fix rebase conflicts
3 years ago
Arthur Campbell
a3f32f7577
fix rebase conflicts
3 years ago
Arthur Campbell
ce4d7cb919
fix rebase conflicts
3 years ago
natdeanlewissoftwire
5519fd9839
test: update
3 years ago
Arthur Campbell
4dd73d7685
fix rebase conflicts
3 years ago
Arthur Campbell
86c30810d7
fix rebase conflicts
3 years ago
natdeanlewissoftwire
b00e0675d0
feat: update validation
3 years ago
Arthur Campbell
3a436a5e4e
fix rebase conflicts
3 years ago
Arthur Campbell
a30503fd90
fix rebase conflicts
3 years ago
kosiakkatrina
ea58c8ba95
CLDC-845 Update validation type from hard validation to soft validation ( #1224 )
...
* Add old_persons_shared_ownership_value_check to sales table
* Move hard validation method to soft validation
* Add old persons shared ownership value check page and question
* Add pages to the household characteristics
* Add soft validation after ownership type
* update a test
* make old_persons_shared_ownership_value_check optional because it's in the setup section
* typo
3 years ago
kosiakkatrina
6f1566bbc1
Update household section name ( #1246 )
3 years ago
kosiakkatrina
7bd76c4d32
CLDC-1575 Add shared ownership validations ( #1217 )
...
* Add income error to ownership type and ecstat fields
* Add shared_ownership_deposit_value_check field
* Add shared_ownership_deposit_invalid? soft validation
* Add shared ownership deposit check pages and questions
* Add pages to the subsection and update validation message
* tests
* Update validation to only trigger if la is given
* Run the soft validation when mortgage isn't used or cash discount isn't given
* test
3 years ago
kosiakkatrina
2787815a9d
CLDC-878 Validate basic monthly rent ( #1228 )
...
* Validate basic monthly rent
* Make the test description clearer
3 years ago
Phil Lee
d65b18d48f
persist column for bulk upload errors ( #1239 )
3 years ago
Phil Lee
9513e1179d
CLDC-1764 Bulk upload filter ( #1223 )
...
* refactor with extract method
* can filter logs by bulk upload
* hide log creation button when viewing bulk upload
- this affects the logs index page filtering logs from a specific bulk
upload
* add info banner to bulk upload logs
* placeholder for bulk upload logs header
* when resuming bulk upload set filters
* fill place holder with remaining logs to fix
* add interstitial to resume if logs resolved
* after resolving bulk upload logs show interstitial
* fix linting error
* extract view variable to helper method
3 years ago
Jack
8e084d0c61
Add more specs ( #1243 )
3 years ago
Jack
9d80f6d245
Add max range to mortgage length ( #1245 )
3 years ago
kosiakkatrina
740f4cbdd4
CLDC-1843 Hide download csv link for sales logs ( #1230 )
...
* Hide download csv link for sales logs
* refactor
3 years ago
Arthur Campbell
0f17eab3fe
CLDC 882 add validation against grant ( #1220 )
...
* fix rebase conflicts
* fix rebase conflicts
* fix rebase conflicts
* implement soft validation of grant value
* fix rebase conflicts
* fix rebase conflicts
* fix rebase conflicts
* fix rebase conflicts
* fix final test from added page
* update test after rebase
3 years ago
kosiakkatrina
4659a3efcf
CLDC-1899 Add discounted ownership value validation ( #1229 )
...
* Add validation for discounted ownership value
* Fix tests
* Update validations to work with different routing
* update error message
3 years ago
natdeanlewissoftwire
4e15a119b9
CLDC-1765 Remove managing organisation for sales log from ui and backend ( #1169 )
...
* feat: remove sales log managing_organisation_id
* feat: move shared managing org behaviour from general log to lettings log, update tests
* refator: linting
* revert change to create
* feat: tech review comments
* db:update
* tests: respond to comment
* feat: revert change to avoid nil issue
* test: update
* feat: add validation and update db
* feat: revert last commit
* db:update
* refactor: use safe navigation and lettings?
* refactor: move safe navigator and add shared org_params to log
3 years ago
natdeanlewissoftwire
a4fbb99a3f
CLDC-1583 Add extra borrowing validation ( #1201 )
...
* feat: add condition-less soft validation and update db
* feat: add validation condition and update tests
* feat: update validation
* feat: update validation
* feat: add tests
* db: update
* test: update
* refactor: linting
* test: update
* feat: update text, remove separate redundant function, add value check page everywhere
* feat: leave value check at end
* test: update
* feat: add value check everywhere
* tests: update
* db:update
* feat: only appear at end
* test: update
* feat: add soft validation everywhere smoothly
* test: update
3 years ago
natdeanlewissoftwire
d67e4710c8
CLDC-861 Add length of stay validations ( #1218 )
...
* faet: add validation and tests
* refactor: linting
* feat: respond to PR comments
3 years ago
Jack
1d624131d6
Use interruption_screen? method ( #1238 )
...
More safe than checking whether the question included value_check in their name
3 years ago
kosiakkatrina
4b43e5cb68
CLDC-1848 Update income hint text ( #1236 )
...
* Remove old income guidance text
* Add income hint text
3 years ago
kosiakkatrina
f87023a5f1
Update number of others in the property header ( #1234 )
3 years ago
James Rose
a235782911
Update rent ranges for 2022 ( #1222 )
...
- The hard max values for rent ranges in 2022 are too conservative and it blocks logs from being migrated from old CORE.
- We can replace this file with correct value as re-run `Imports::RentRangesService` to upsert the existing values.
3 years ago
Jack
c2c1b4dbb0
Add mortgage length hint ( #1237 )
3 years ago
Jack
56a9cb4bdf
CLDC-864 Add contract exchange date validations ( #1231 )
...
* CLDC-864 Add exdate validations
* Raise missing translation errors
* Fix missing translation
* Remove unused method
* Remove redundant check
3 years ago
Phil Lee
1a5a64e18e
handle bulk upload files with boms ( #1233 )
3 years ago
kosiakkatrina
8ca9cbfb49
Change numeric validation to display prefixes in error message ( #1227 )
...
* change numeric validation
* Fix test, add delimiter and suffix to the numeric error mesage
3 years ago
kosiakkatrina
10536ae13f
Update reson answer options ( #1209 )
3 years ago
kosiakkatrina
3308d86a10
Last settled accommodation and discounted ownership property postcodes must match ( #1213 )
3 years ago
Jack
cf92c9559c
Add disability and wheelchair questions validation ( #1215 )
...
* Add Page#interruption_screen? method
* Use form helper method
* Validate household disability questions
* Update CYA
3 years ago
Jack
45b098ad4b
CLDC-1457 Update checkbox validation message ( #1207 )
3 years ago
Arthur Campbell
1cced31e27
hard validation on value of cash discount ( #1221 )
3 years ago