f7a0eb01dd
Merge remote-tracking branch 'origin/CLDC-2140-scheme-typeahead-with-inactive-locations' into CLDC-2140-scheme-typeahead-with-inactive-locations
3 years ago
d569e78d57
refactor: complete -> confirm
3 years ago
1d7dc1c774
feat: add unconfirmed scope
3 years ago
c0f9088251
feat: only confirm locations if complete (old) AND save button clicked (new)
3 years ago
6a4605394c
feat: reject incomplete locations
3 years ago
005b21a2b4
feat: update scheme typeahead text
3 years ago
7d20066d6f
feat: improve copy
3 years ago
9d961acb20
feat: show completed/incomplete locations and validate when completed == 0
3 years ago
14e2346e12
feat: reject incomplete locations
3 years ago
90be5bff57
feat: update scheme typeahead text
3 years ago
20326fd55b
feat: fix tests
3 years ago
86c4b06ddc
refactor: complete -> confirm
3 years ago
91fea69aef
Merge remote-tracking branch 'origin/CLDC-2140-scheme-typeahead-with-inactive-locations' into CLDC-2140-scheme-typeahead-with-inactive-locations
...
# Conflicts:
# app/models/form/lettings/questions/location_id.rb
# app/models/scheme.rb
3 years ago
5f1f147811
feat: add unconfirmed scope
3 years ago
2d60f81887
feat: only confirm locations if complete (old) AND save button clicked (new)
3 years ago
c7901162c9
feat: reject incomplete locations
3 years ago
931a772771
feat: update scheme typeahead text
3 years ago
ba44f3b056
feat: improve copy
3 years ago
d77e936fb0
feat: show completed/incomplete locations and validate when completed == 0
3 years ago
315ddef0c3
feat: reject incomplete locations
3 years ago
4ffa4f45e7
feat: update scheme typeahead text
3 years ago
1b44165cb0
feat: change to confirmed to add clarification in code
3 years ago
7774b5eff9
Merge remote-tracking branch 'origin/CLDC-2140-scheme-typeahead-with-inactive-locations' into CLDC-2140-scheme-typeahead-with-inactive-locations
3 years ago
65540e35ee
feat: improve copy
3 years ago
222e011116
feat: show completed/incomplete locations and validate when completed == 0
3 years ago
f56fd73148
feat: reject incomplete locations
3 years ago
4be034cf8a
feat: update scheme typeahead text
3 years ago
0d81d10247
feat: change active -> completed
3 years ago
99dd7548e2
feat: improve copy
3 years ago
fdf230928f
feat: show completed/incomplete locations and validate when completed == 0
3 years ago
c4dfcbcd77
feat: reject incomplete locations
3 years ago
0402339dd9
feat: update scheme typeahead text
3 years ago
adc3461caa
feat: update scheme status so incomplete unless has active locations
3 years ago
e66e27f6de
fix: show "Most recent let type" qu for both needs types ( #1418 )
3 years ago
f29e41bb2c
Value validation ( #1429 )
...
* Add discounted_sale_value_check to sales
* Add DiscountedSaleValueCheck pages and questions
* Add value check to the form
* Only run validate_discounted_ownership_value as a hard validation on and after 24/25
* Rebase fix
* Fix form spec
* Update discounted_ownership_value_invalid?
* update validation
* Update soft validation content
* PR comments
* typo
* lint
* Default discounted_sale_value_check on import
3 years ago
3acd57c255
Student child validation ( #1441 )
...
* Move household validation to soft validaiton
* Add student_not_child_value_check column
* Add soft validation pages
* Update import service
* typo
* Change class names and fix a typo
* More typos
3 years ago
867a70a393
CLDC-2143 Set default and optional missing import fields ( #1443 )
...
* Make mortlen optional for 22/23
* Set extrabor to don't know it is not answered
* Make mortgage lender and othtype optional
* Add hidden don't know options to soctenant and fromprop
* Make frombeds optional
* Display soctenant questions if soctenant is don't know
* infer soctenant values if not given
3 years ago
0a74ee7562
Return correct type if no LAs found for location ( #1439 )
...
* Default to location code if LocalAuthority is not found by location code
* Set local authority before validation
3 years ago
81765d857d
CLDC-2143 Address import validations ( #1425 )
...
* Do not run discounted ownership validation if mortgageused is don't know
* Clear previuos postcode if import hits postcodes_not_matching error
* Remove child income validation for 22/23
* Remove invalid exchange date
* Clear income 1 if it's over allowed non london threshold
3 years ago
d38c2a3867
CLDC-2134 Bulk upload tabs ( #1436 )
...
* tweak bulk upload email copy formatting
* change bulk upload summary error report
- this is now tabbed with the full report
- also summary report has now changed from single table to multiple
tables
* bulk upload cannot navigate to summary report
- as when sent to view full report the user does not have enough
errors that need summarising
3 years ago
c4cb2ecd2e
Seed la data before links ( #1435 )
...
* seed la data before links
* lint
* Only seed LAs once for tests
3 years ago
5606d06491
CLDC-1917 test flakiness fix ( #1437 )
...
* feat: add validation with feature flag, typo fix and update tests
* feat: flip feature toggle
* feat: update feature toggle name
* feat: fix form handler inequality
* refactor: linting
* refactor: use between in form handler
* feat: remove feature toggle
* feat: add dynamic date to lettings log factory
* feat: fix log_summary_component_spec.rb tests
* feat: update lettings_log.rb and start fixing lettings_log_spec.rb
* feat: fix more tests
* feat: fix more tests
* feat: fix lettings log import service
* refactor: linting
* feat: fix checkboxes_spec.rb
* feat: fix interruption_screen_helper_spec.rb
* feat: fix check_answers_helper_spec.rb
* feat: fix page_routing_spec.rb
* feat: fix lettings_logs_field_import_service_spec.rb
* feat: fix lettings_log_spec.rb
* feat: fix question_spec.rb
* feat: fix lettings_logs_controller_spec.rb
* feat: fix check_answers_page_lettings_logs_spec.rb
* feat: fix tenancy_validations_spec.rb
* feat: fix validations_spec.rb
* feat: fix accessible_autocomplete_spec.rb
* feat: fix form_navigation_spec.rb
* feat: fix soft_validations_spec.rb
* feat: fix lettings_log_export_service_spec.rb
* feat: fix saving_data_spec.rb
* feat: fix page_spec.rb
* feat: fix form_controller_spec.rb
* refactor: linting
* feat: fix subsection_spec.rb
* feat: fix lettings_log_spec.rb
* feat: fix financial_validations_spec.rb
* feat: fix tasklist_page_spec.rb
* feat: fix conditional_questions_spec.rb
* feat: fix form_page_error_helper_spec.rb and log_summary_component_spec.rb
* feat: fix lettings_log_csv_service_spec.rb
* feat: fix tasklist_helper_spec.rb
* refactor: linting
* refactor: linting
* feat: fix lettings_log_spec.rb
* refactor: linting
* refactor: replace financial year with collection yaer
* feat: respond to PR comments pt. 1
* feat: respond to PR comments pt. 2
* feat: unfreeze all timecop freezes
3 years ago
18f40d5c15
CLDC-2025 Add equity range validation to sales logs ( #1400 )
...
* feat: add validation behaviour
* feat: add tests
* feat: respond to pr comments
* refactor: lint
* feat: fix tests
* feat: fix tests
* feat: respond to PR comments
3 years ago
f758d598c4
CLDC-1917 Add Startdate Validation ( #1378 )
...
* feat: add validation with feature flag, typo fix and update tests
* feat: flip feature toggle
* feat: update feature toggle name
* feat: fix form handler inequality
* refactor: linting
* refactor: use between in form handler
* feat: remove feature toggle
* feat: add dynamic date to lettings log factory
* feat: fix log_summary_component_spec.rb tests
* feat: update lettings_log.rb and start fixing lettings_log_spec.rb
* feat: fix more tests
* feat: fix more tests
* feat: fix lettings log import service
* refactor: linting
* feat: fix checkboxes_spec.rb
* feat: fix interruption_screen_helper_spec.rb
* feat: fix check_answers_helper_spec.rb
* feat: fix page_routing_spec.rb
* feat: fix lettings_logs_field_import_service_spec.rb
* feat: fix lettings_log_spec.rb
* feat: fix question_spec.rb
* feat: fix lettings_logs_controller_spec.rb
* feat: fix check_answers_page_lettings_logs_spec.rb
* feat: fix tenancy_validations_spec.rb
* feat: fix validations_spec.rb
* feat: fix accessible_autocomplete_spec.rb
* feat: fix form_navigation_spec.rb
* feat: fix soft_validations_spec.rb
* feat: fix lettings_log_export_service_spec.rb
* feat: fix saving_data_spec.rb
* feat: fix page_spec.rb
* feat: fix form_controller_spec.rb
* refactor: linting
* feat: fix subsection_spec.rb
* feat: fix lettings_log_spec.rb
* feat: fix financial_validations_spec.rb
* feat: fix tasklist_page_spec.rb
* feat: fix conditional_questions_spec.rb
* feat: fix form_page_error_helper_spec.rb and log_summary_component_spec.rb
* feat: fix lettings_log_csv_service_spec.rb
* feat: fix tasklist_helper_spec.rb
* refactor: linting
* refactor: linting
* feat: fix lettings_log_spec.rb
* refactor: linting
* refactor: replace financial year with collection yaer
* feat: respond to PR comments pt. 1
* feat: respond to PR comments pt. 2
3 years ago
ebe0e2a5ee
CLDC-1999 Add local authority links and select correct LA from location ( #1402 )
...
* Add local authority links
* Display all local authorities for location
* set correct LA for log based on year
* Format local authorities for locations
* Rename variable
* Add import task for la links
* look at form start date because log start date might not be given
* Update app/models/lettings_log.rb
Co-authored-by: James Rose <james@jbpr.net>
* Update app/helpers/locations_helper.rb
Co-authored-by: James Rose <james@jbpr.net>
* Refactor
* Seed review app
* Change dates format
* Update the local authority link data
* Typo
* update mapping in Lettings logs
---------
Co-authored-by: James Rose <james@jbpr.net>
3 years ago
0ae75a27b9
Change the search string to a more complex one ( #1431 )
3 years ago
cff4cc45bc
CLDC-2068 request, validate UPRN and retrieve address ( #1370 )
...
* Add OS_DATA_KEY env var
* Add new UPRN and address columns to logs
* Bugfix: use dynamic optional fields
* Update optional fields
* Add UPRN validation
* Add UPRN Client
* Add UPRN Presenter
* UPRN questions and flows
* Skip to non addresss questions if UPRN unknown
* Address PO review comments and add missing specs
* Display LA correctly
3 years ago
e2032edd88
Filter on the subset of logs in tests ( #1430 )
3 years ago
74a75d3d3d
fix bulk upload email timestamp formatting ( #1426 )
3 years ago
c862423adf
CLDC-1864 single log numbering ( #1381 )
...
* feat: add initial question number behaviour
* feat: add initial CYA behaviour
* feat: number sales setup section
* refactor: lint
* feat: property information numbering
* feat: household characteristics section and typo fix
* feat: household characteristics numbering
* feat: household situation numbering
* feat: other household info numbering
* feat: income, benefits and outgoings numbering
* feat: shared ownership scheme numbering
* feat: shared, discount and outright numbering
* feat: fix income duplication bug, add numbers to other questions
* feat: typo fix
* feat: add lettings setup numbering
* feat: add property info numbering
* feat: add household char numbering
* feat: add household needs numbering
* feat: add household situ numbering
* feat: add income numbering
* feat: update tests
* refactor: cleanup and disable on 2022 and before logs
* feat: add test for q numbers in 23/24 year only
* refactor: highlight multiplication in brackets
* feat: show rent and charge questions individually on cya
* feat: number new previous tenure q
* feat: delete old prevten file
* feat: update card numbers after merge
* feat: add q60 ands 61 sales
* refactor: delete empty files
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
3 years ago
natdeanlewissoftwire
SamSeed-Softwire
kosiakkatrina
Phil Lee
natdeanlewissoftwire
Jack