ebaa96ac10
test: improve test context descriptions in lettings_log_spec
4 years ago
a5a29671eb
feat: don't set log owning org as user's org if that org doesn't hold stock
4 years ago
12575b902a
test: artificially reference org_rel2 to avoid lint offense
4 years ago
37c39956e7
test: add line breaks and start context descriptions with and (not if)
4 years ago
ea8fbdbbe0
test: check owning & managing orgs set correctly when a log is created
4 years ago
7f0e5a5aac
test: update lettings log feature tests
...
to differentiate between different numbers of stock owners when acting as a data coordinator
4 years ago
0ca575457a
lint
4 years ago
9a3752797f
fix: define log and current_user instance vars in label_from_value (housing prov.)
4 years ago
d9e6df5f6c
test: check housing prov. still selectable after deleting relationship
4 years ago
2a34de7194
test: refactor housing providers opts tests (not support user)
4 years ago
7e10b0d69e
test: make context definition more human-readable
4 years ago
930db0c9a5
style: add space after user definition
4 years ago
06dcc09702
feat: update housing provider answer opts to include current HP in db
4 years ago
3d40e564c0
test: update housing provider opts tests for non-support user
4 years ago
67acd0d5b9
test: pass in log and user in housing provider opts test for support user
4 years ago
67661e6cdc
lint
4 years ago
a186adf4ef
refactor: ensure label_from_value always accepts log & nil as args
4 years ago
9c4cd6f5f7
style: reorder instance vars and remove old comments in managing_organisation.rb
4 years ago
05ac541815
fix: don't call user in get_answer_label in CYA component
4 years ago
a3232be3d8
test: refactor managing orgs opts tests for support user case
4 years ago
39540b415c
test: add "(with hint)" to managing org opts test descriptions
4 years ago
3e5f099b04
test: make relationship deletion test consistent with other tests
4 years ago
d16fb81ab7
test: improve managing orgs opts tests when support
4 years ago
92a33087e2
test: improve managing orgs opts test when not support
4 years ago
b3656cf250
wip
4 years ago
13801994de
feat: check if managing org exists before trying to show it
4 years ago
7efcab2790
feat: add current managing org to answer opts
4 years ago
aecebc4c50
test: check managing org not gone from answer opts when relationship deleted
4 years ago
1bf8373a74
CLDC-867 Add previous bedrooms validations ( #1219 )
...
* Add previous property bedsit validations
* Add min and max for frombeds
4 years ago
f0868b8173
CLDC-1898 Bulk upload headers ( #1210 )
...
* fix bulk upload age data types
* bulk upload handles both with and without headers
- headers are from the spreadsheet template
- otherwise assume cell A1 is start of the dataset
4 years ago
0009d535fe
CLDC-1896 Bulk upload line endings ( #1208 )
...
* add class to create logs from bulk upload
* create logs when processing bulk uploads
* remove bulk_upload_id from csv output
* create bulk upload logs only if all valid
- this will be changed later to allow for partial logs
- and only to create logs when a threshold has been met
* add method to blank invalid non setup fields
* bulk upload log creation blanks invalid fields
* fix incorrect logic for bulk upload renewal
* fix linting
* bulk upload log creation fail logs to sentry
* fix bulk upload line ending parsing
* extract bulk uploading csv parsing to class
* use csv parser in log creator
* change handle line endings mechanism
- we now strip all windows line endings for unix based line endings
- this normalises things making it simpler
4 years ago
d2afa46946
CLDC-1461 add validation ensure postcodes match if discounted ownership purchase ( #1200 )
...
* new property validation file for sales logs with postcode validation regarding discounted ownership, tests also
* linting problem
4 years ago
c035b905f5
Number of bedrooms must be between 1 and 9 ( #1212 )
4 years ago
da8d6c0f74
CLDC-848 Add household details validations ( #1199 )
...
* Add min and max to age2 + questions
* validate that under 16s are economic children
* Update factory
* Update test
* Update ecstat, relationship and age validation
4 years ago
adebe409f6
tweak blank error message for bulk upload ( #1211 )
4 years ago
d4e8e64c28
CLDC-863 Add practical completion/handover date validations ( #1198 )
...
* [CLDC-863] Add hard validation for hodate
* Add soft validation
4 years ago
d9a57ec1cb
CLDC-1627 Enable multiple inferred answers ( #1077 )
...
* Enable multiple inferred check answers values
* lint and add new conditions to check answers for age1
* Rename method
* Refactor inferred answer value
* rebase update
* update inferred_check_answers_value after rebase
* Move the method to private
* Add a missing test
* rebase changes
* Add prefers not to say as the displayed value for all household members
* update [0] to .first
* replace [0] with .first
4 years ago
9e9ff8a4e2
CLDC-850 Add relationship to buyer 1 validation to sales log ( #1178 )
...
* feat: add sales partner count validation
* test: update tests
* test: add new test
* refactor: DRYing
* feat: DRY general household member validation
* feat: add tests
* db: update
* feat: update shared validations
* test: update tests
* feat: add more validations
* feat: add more validation and update tests
* feat: add update method test
* test: update sales_log factory
* refactor: linting
* feat: remove numbering
* test: update tests
* feat: rename i18n vars, add validations everywhere
* tests: add new tests for new validation occurences
* db: update
* feat: add partner number validation to relevant fields rather than base
* test: update tests
* tests: refactor
* test: update
4 years ago
96b3aa4765
Gem upgrades ( #1206 )
...
* Update rack
* update globalid
* Update rails
4 years ago
ced6457a19
CLDC-1878 Add hint to mortgage amount question ( #1203 )
4 years ago
47ddf87282
CLDC-1858 Add new collection resources design ( #1204 )
...
* feat: update collection resources with new lettings log link and design
* refactor: linting
* feat: update size (previously was using in browser size not post-download)
4 years ago
45710ed661
CLDC 911 add hard validation to cash deposit ( #1186 )
...
* Tidy up test file
* Add hard validation to cash deposit
* Load validations
4 years ago
826eaf22f1
CLDC-1746 Show Handover question also on not on resale ( #1183 )
4 years ago
c07dde6794
fix: correct no-stock user names + update emails to prevent duplicates ( #1185 )
4 years ago
0099f7f46f
feat: remove association ( #1196 )
4 years ago
ecdc4d99c5
CLDC-1726 Update scheme and location display pages ( #1190 )
...
* feat: update scheme and log displays
* test: update tests
* test: update tests
4 years ago
daed7965e2
CLDC-1751 add extra borrowing question ( #1165 )
...
* feat: add page, tests, and update db
* feat: add depends on behaviour
* refactor: linting
* db: update
* db: update
4 years ago
1ae79eefa3
CLDC-1741 Remove scheme support provider question ( #1173 )
...
* feat: remove support services provider question page
* tests: update tests
* tests: update tests
* tests: update tests
* refactor: linting
* test: update tests
* db: migration to remove field
* test: update tests and more removal of managing_organisation from schemes
* refactor: linting
* db: update
4 years ago
64f245d066
Consider everyone below 18 a child ( #1195 )
4 years ago
52abc23c70
Cldc 808 derived sales variables ( #1184 )
...
* Add derived household fields
* Derive household variables for sales logs
* Refactor and fix wrong test names
* Count everyone under 20 as children if relationship is "C"
4 years ago
Sam Seed
Phil Lee
kosiakkatrina
Arthur Campbell
Jack
natdeanlewissoftwire
SamSeed-Softwire