submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	d9f2bcd8c0	fix merge conflicts	3 years ago
Arthur Campbell	0705944de0	fix merge conflicts	3 years ago
Phil Lee	01b957cc10	better validation on bulk upload start year (#1319 )	4 years ago
James Rose	b24ab538ce	Update collection year end dates for 2022 onwards (#1312 ) The source of truth for this update is: https://digital.dclg.gov.uk/confluence/pages/viewpage.action?spaceKey=MC&title=CORE+And+Collection+Years	4 years ago
Phil Lee	5490e2ecb0	CLDC-1892 Bulk upload validation for managing organisation (#1315 ) * bulk upload validation for owning org * block log creation at row parser level * bubble up block_log_creation so it blocks logs * owning org id looks up serveral fields * validate bulk upload managing org	4 years ago
James Rose	7c62d8b4a6	Change CDS export archive names from quarter to financial year (#1309 ) - We previously pushed logs into archives categorised by the quarter that they were created for. - CDS requested that instead we push everything into a larger bucket seperated by FY.	4 years ago
Phil Lee	02d8247f59	tweak bulk upload validation (#1302 ) - LA referral not permitted if general needs and now also if owning org is an LA	4 years ago
James Rose	c19b200e84	Add arcturus.net to whitelisted delivery domains (#1316 ) - We whitelist domains that we will deliver to in non-production environments - This adds arcturus.net so that they can conduct their pentest	4 years ago
Phil Lee	26aa5244bb	mass update gems used by docs (#1313 )	4 years ago
Jack	b6ff8bf896	CLDC-1909 Add 2023-2024 collection year filter (#1314 )	4 years ago
Jack	65bde2b7f5	CLDC-1903 Infer first time property let question (#1300 )	4 years ago
Jack	d8689c30a2	CLDC-1968 Add review page for Sales logs (#1292 ) * CLDC-1968 Add review page for Sales logs * use log#sales? * Do not use type checking	4 years ago
James Rose	293077695c	Allow issues/pull-request write permissions for GitHub token (#1310 )	4 years ago
kosiakkatrina	b973e8348e	CLDC-1861 Update options order for lead tenant's working situation (#1289 ) * Switch the first two options so Full time comes before Part time * Enable dates validations on staging	4 years ago
natdeanlewissoftwire	ef0fc992e7	CLDC-1906 infer offered (#1298 ) * feat: infer offered if renewal * feat: update test * db:update	4 years ago
Jack	be3e782a0e	Add 2023 sales validations (#1305 )	4 years ago
James Rose	2b918a09d7	Rename lettings log export field `form` to `formid` (#1306 )	4 years ago
Phil Lee	02f04fde60	CLDC-1884 Bulk upload disability access fields and validations (#1299 ) * bulk upload considers housing needs fields * bulk upload only permits one housing needs type * add bulk upload validation - no disabled needs cannot be selected in conjunction with a disabled need * add bulk upload validation - dont know disabled needs cannot be selected in conjunction with a disabled need * add bulk upload validation - no and don't know disabled access needs cannot be selected together	4 years ago
kosiakkatrina	00cb234797	CLDC-1811 Add buyer 2 ethnicity question for 23/24 form (#1287 ) * Add buyer 2 ethnic questions and pages * Add ethnic fields for buyer 2 * Add the new questions to the correct year	4 years ago
kosiakkatrina	8879748f82	only load session fiters when getting or exporting the logs (#1301 )	4 years ago
SamSeed-Softwire	92029ea2a0	CLDC-859 Sales validation - bedsits cannot have more than 1 bed (#1188 ) * feat: add sales validation to check bedsits have <=1 beds * test: sales validation to check bedsits have <=1 beds * fix: typo in property validation method name * feat: add same bedsit validation to number of bedrooms question * test: fix typo propert -> property in property validations tests * test: add test for validate_property_number_of_bedrooms (sales) * feat: update wording for 'number of bedrooms' validation when bedsit * test: condense sales property validations tests * test: strengthen sales property validations error addition test * refactor: simplify sales property validations into one method * fix: update error message content to match Beth's choices * chore: lint * test: add requests test for invalid sales log params when posting * refactor: use if rather than unless... not in property validation * refactor: write method is_bedsit? on SalesLog * test: check bedsit error not added if proptype or beds is nil * lint: use update! not update * feat: update validation messages to improve readability * fix: provide valid date in request test for invalid proptype/beds * feat: make is_bedsit and validate_bedsit_number_of_beds more readable	4 years ago
natdeanlewissoftwire	6c0780291b	CLDC-1810 new staircasing followup (#1286 ) * feat: behaviour * feat: conditional year behaviour and test * refactor: linting * db: update	4 years ago
Phil Lee	ca8b797012	bulk upload ignores blank rows in csv (#1295 )	4 years ago
Phil Lee	f0a1e18325	CLDC-1885 Bulk upload type must match given needs type (#1288 ) * bulk upload type must match given needs type * refactor invert logic statement * tweak validation copy	4 years ago
kosiakkatrina	0ff387ad84	Remove nils before adding up location units (#1290 )	4 years ago
Arthur Campbell	67f61a8f92	add tests for new sales log method for formatting currency	4 years ago
Arthur Campbell	53da6aced9	correct linting errors, minor test failure and typo	4 years ago
Arthur Campbell	3cdf30feab	update interruption screen helper tests	4 years ago
Arthur Campbell	89bf3d1f13	change a variable name and correct minor rebase errors	4 years ago
Phil Lee	c481055f4d	CLDC-1965 Bulk upload correct again email (#1274 ) * tests for bulk upload mailer * bulk upload send upload again email	4 years ago
Jack	466d3fc2cf	CLDC-1809 Add prevshared question (#1269 ) * Add prevshared question * Update CYA * Add missing specs	4 years ago
Arthur Campbell	ead207eb29	rebase and fix conflicts and tests	4 years ago
Arthur Campbell	a68fe4eb3b	update evil test in form handler spec	4 years ago
Arthur Campbell	428eae8c8f	enable currency formatting of numbers for inserting into informative_text or title_text	4 years ago
Arthur Campbell	32a950694e	amend tests to reflect the chagnes in validations and copy	4 years ago
Arthur Campbell	d850ac1350	rename constant struct with same anme as existing variable	4 years ago
Arthur Campbell	0192978c3c	remove ecstat from income checks, the only ecstat we care about is child which is dealt with elsewhere	4 years ago
Arthur Campbell	ac6abe2db2	update buyer 1 and 2 income value check to be consistent	4 years ago
Arthur Campbell	b5f4294702	extract duplicate code to private method	4 years ago
Arthur Campbell	f1508b9c64	change copy for some validations, add sales log method and amend interruption screen helper to support this	4 years ago
Arthur Campbell	58f5658ed0	correct linting errors and play a little code golf	4 years ago
Arthur Campbell	1f6116b2c3	amend child income validation to reflect specifications and write tests to cover this validation	4 years ago
Arthur Campbell	fbd2f4bca8	revamp financial validations tests against income to reflect updates	4 years ago
Arthur Campbell	1c72c6bb21	move validation on child income to financial validations to stop it being triggered on lettings logs, minor amendments to tests broken by changes	4 years ago
Arthur Campbell	cdcd3f9cf5	combine duplicate methods after rebase, ensure hard validations are triggered on all relevant fields	4 years ago
David May-Miller	9bad3bf58d	CLDC-853 Actually use the validate_combined_income method	4 years ago
David May-Miller	b4ee4f37ea	CLDC-853 Move income 2 to cya card 2 and commonise combined income validation	4 years ago
David May-Miller	b1d5053048	CLDC-853 Rename migration	4 years ago
David May-Miller	5f341ddd26	CLDC-853 Fix broken sales income2 test	4 years ago
David May-Miller	f303e4d3f8	CLDC-853 Rename migration and update schema version	4 years ago

1 2 3 4 5 ...

2001 Commits (d9f2bcd8c0d2da7501b3f42ed53f254e8170eecd) All Branches Search

2001 Commits (d9f2bcd8c0d2da7501b3f42ed53f254e8170eecd)

All Branches