submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	7e32f6c71f	temp	3 years ago
Arthur Campbell	cd38461927	minor refactors after rebasing onto Nat's work	3 years ago
Arthur Campbell	f753846a18	minor refactor of lettings log feature spec setup, replicate happy path for sales	3 years ago
Arthur Campbell	c96db5251e	replicate request specs from lettings for sales and organisations controllers	3 years ago
Arthur Campbell	820ad60d79	simplify tests for whether delete logs button appears on index page	3 years ago
Arthur Campbell	47b782834f	revert change, causing errors and outside the scope of this ticket	3 years ago
Arthur Campbell	99f45cf909	minor linting corrections	3 years ago
Arthur Campbell	c154febda0	ensure delete logs button is always visible on log lists when in the organisations tab	3 years ago
Arthur Campbell	c3d527e3bb	implement dirty fiddle to get the checkboxes smaller and also not misaligned	3 years ago
Arthur Campbell	7cb90c6210	test new helper methods	3 years ago
Arthur Campbell	99613aea6f	remove unnecessary untested arguments	3 years ago
Arthur Campbell	91533d0308	refactor delete logs controller after tech review improve the private method that builds the form object so that it has the flexibility to do so for all controller methods ensure that the search term is passed to the delete logs controller when navigating through the organisations tab ensure that noly logs for that organisation are displayed when navigating to delete logs through the organisations tab	3 years ago
Arthur Campbell	080a3e6952	extract tables for lettings and sales to own partials	3 years ago
Arthur Campbell	4c76b12da9	minor refactor to delete logs controller: ensure session filters are only fetched from teh session when needed and extract discard logs method to private method	3 years ago
Arthur Campbell	980550f45b	merge the delete pages for lettings logs and sales logs, add to the tests for the lettings page to test sales specific content	3 years ago
Arthur Campbell	eabf668ec5	implement the story for lettings and sales logs under the organisation tab routing and controller methods testing for deleting sales logs, lettings or sales logs for an organisation move storage of relevant routes inside the form object as a comprehensive view model	3 years ago
Arthur Campbell	a9f5086c56	implement same work for sales as for lettings	3 years ago
Arthur Campbell	9883e94198	extract controller methods and associated tests to do with the delete logs feature into their own controller, amend routes accordingly	3 years ago
Arthur Campbell	c7f5eff0f7	alter config to allow creating controllers from the command line with associated spec files that matches how we test	3 years ago
Arthur Campbell	e44aa5a8d2	comprehensive reworking after code review ensure that we are not passing lists of ids through params in the query string, risking overflowing the maximum URL length, adjust tests accordingly, do not attempt to reuse the same table for sales and lettings	3 years ago
Arthur Campbell	296289c59d	create request tests for the DELETE delete-logs path	3 years ago
Arthur Campbell	afeee2b035	create request tests for the GET delete-logs-confirmation path	3 years ago
Arthur Campbell	347846b324	create request tests for the GET delete-logs path	3 years ago
Arthur Campbell	9750eed5d3	create basic tests for the view component for listing logs to delete	3 years ago
Arthur Campbell	92a96a9f3c	write a happy path feature test for the entire journey	3 years ago
Arthur Campbell	cbec8d2f94	test appearance of delete logs button on index page for lettings logs	3 years ago
Arthur Campbell	b10fd31369	correct indentation from 4 spaces to 2 in view file	3 years ago
Arthur Campbell	ddf079047c	add a button to the logs list to delete multiple logs style and position of button helpers for displaying the button conditionally depending on user role and what filters and search are active	3 years ago
natdeanlewissoftwire	825076a522	CLDC-2456 Sales collection year test fixes (#1689 ) * feat: setup to replicate failures to fix * feat: wip test fixes * feat: remainder of current state test fixes * feat: set form date to past to trigger errors to fix * feat: revert, don't want this in final diff * feat: fix row_parser tests * feat: sales log importer and validator fixes * feat: remainder of test fixes * refactor: lint	3 years ago
natdeanlewissoftwire	9d98c391a5	CLDC-2372 Remove sales bulk upload feature flag (#1693 ) * feat: remove sales bu feature flag * refactor: lint	3 years ago
kosiakkatrina	6053eb18c3	CLDC-2372 Update bulk upload resources (#1671 ) * Reorder resources list * Update sales 23/24 resources * Update sales 22/23 resources * Fix typo and add missing paths * Change the wording * feat: update files, add 22/23 lettings form to local storage and add collection resources helper * feat: remove sales bu feature toggoe * refactor: lint * refactor: erblinting * feat: add tests for helper * feat: revert feature flag removal (will put in a separate PR) * refactor: update matadata helper --------- Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>	3 years ago
natdeanlewissoftwire	240e8a03b5	Cldc 2445 increase offered max (#1692 ) * feat: update max and add new spec * feat: update previous years * feat: combine identical offered questions * feat: update tests * feat: add test for property_number_of_times_relet	3 years ago
Jack	6d7ce8af16	CLDC-2319 prevent log creation (#1684 ) * Remove bulk_upload_lettings_logs flag * Add spacing above actions in data sharing agreement * Add banner * Add model validation * fix log component * Fix factory * Put validation behind feature flag * start adapting to data protection confirmation * Make tests more generic * Add tests for display_organisation_attributes * Use data_protection_confirmed? method * Address code review * rubocop * Prevent access to bulk upload pages when DPC not signed * Address PO review	3 years ago
natdeanlewissoftwire	b0271ea0ec	CLDC-2257 Refactor filters (#1675 ) * feat: split lettings and sales filters * feat: remove logs filter * refactor: type -> filter_type * refactor: slight cleanup * feat: update csv download * feat: set org filters to mirror primary sales and lettings * refactor: linting * feat: fix filter types in org controller - can be changed to org specific labels in future if needed rather than copying filters from primary sales/lettings tabs * refactor: initalize filter_type * refactor: lint * refactor: combine filter_manager into filter_service * refactor: rename to filter manager * refactor: DRY session name filter logic * feat: share session filter name logic * feat: further refactor * refactor: simplify * feat: revert change to filter manager	3 years ago
James Rose	40a07c3f57	Reduce Sentry sample rate so that we don't hit our quota (#1691 ) - As we migrate more organisations onto the service we need to be more conservative. - This PR removes tracing on healthchecks entirely, whilst lowering everything else from 0.02 to 0.01.	3 years ago
natdeanlewissoftwire	19335a2367	CLDC-2438 Fix carriage return csv bug (#1685 ) * feat: add extra subs to row_parsers * feat: add tests * refactor: gsub not tr * feat: remove redundant sub * feat: simplify replacement * feat: scrub before tr to fix invalid byte error * feat: add !	3 years ago
natdeanlewissoftwire	258e7cc81e	CLDC-1908 Update lettings compound validation (#1682 ) * feat: add second half of age/relat/ecstat validation to lettings logs * feat: add tests * feat: add ecstat refused option * feat: update tests * refactor: typo * feat: add extra test, typos	3 years ago
Arthur Campbell	f9ed29804e	push back end date of forms to allow them to continue to be edited for now. Adjust the copy about the date until when logs can be edited to keep it consistent with how things have been up until now (#1688 )	3 years ago
Jack	a3b945d8e3	CLDC-2322 read and sign data sharing agreement (#1686 ) * Add data sharing agreement * Add data sharing agreement view * Add controller actions * Update details page * Rubocop fix * Fill in placeholders and persist data in table * Update agreement template	3 years ago
Phil Lee	7e80ad612f	remove cannot delete warning (#1650 )	3 years ago
Jack	38df2a5559	CLDC-2388 Map purchase prices errors to type (#1673 )	3 years ago
Phil Lee	c5842122d7	CLDC-2369 Spreadsheet dupe (#1663 ) * remove dead code * handle spreadsheet dupes in lettings * handle spreadsheet dupes in sales * update error message * use feature flag	3 years ago
Rachael Booth	ae364b66f6	Add node version and firefox notes to local setup doc (#1683 )	3 years ago
Phil Lee	3ced8390b1	ensure bulk upload answers are red (#1664 )	3 years ago
Phil Lee	29a0a3777b	remove inline sql from tests (#1677 )	3 years ago
Phil Lee	aa4a1677b2	CLDC-2383 Sidekiq graceful restart (#1674 ) * allow sidekiq to shutdown gracefully * delete existing errors before bulk upload run * fix typo	3 years ago
natdeanlewissoftwire	0959ae5338	CLDC-2415 Increase hard rent range validations (#1672 ) * feat: update rent range data * feat: amend 2022 values	3 years ago
kosiakkatrina	ee14bca6cf	CLDC-2364 Display guidance text on net income question (#1668 ) * Make sure that the guidance text is displayed on net income question * add test * Add missing guidance to earnings	3 years ago
kosiakkatrina	fad105302a	CLDC-2386 Validate the correct template for the year (#1665 ) * Validate that correct template for the year is used for sales (with headers) * Check the correct template is being used without headers * Check correct template for lettings * Update csv parser on sales * Remove redundant methods * Extract form years * Reverse year check mathod	3 years ago
kosiakkatrina	15b9ce8f35	Do not display the looping link in the review page (#1667 )	3 years ago

1 2 3 4 5 ...

2330 Commits (7e32f6c71f5842eb53d179f214bb281477442a6c) All Branches Search

2330 Commits (7e32f6c71f5842eb53d179f214bb281477442a6c)

All Branches