samyou-softwire
2f6d9329bd
fixup! CLDC-4325: Fix sales log spec in 2025
2 weeks ago
samyou-softwire
9d928009ec
CLDC-4325: Delete recalculate_reasonpref_dontknow rake
...
only needed for 2024 logs
2 weeks ago
samyou-softwire
14cf86b1cb
fixup! CLDC-4325: Fix check answers summary component
2 weeks ago
samyou-softwire
c04f10f89a
CLDC-4325: Turn the 2026 override on again
2 weeks ago
samyou-softwire
bc61f733bc
CLDC-4325: Fix lettings log derived spec in 2025
...
timecop required for the start dates to work
2 weeks ago
samyou-softwire
7e690964db
CLDC-4325: Fix sales log spec in 2025
...
need to use let rather than let! so the timecop can run first
2 weeks ago
samyou-softwire
6f5446e956
CLDC-4325: Add a corresponding return to timecop missing one
2 weeks ago
samyou-softwire
563f34fd3f
CLDC-4325: Turn off 2026 override
2 weeks ago
samyou-softwire
58d922ccd1
CLDC-4325: Run all tests now and in 2026
2 weeks ago
samyou-softwire
af822ded37
CLDC-4325: Fix guidance helper spec
2 weeks ago
samyou-softwire
dafbac8063
CLDC-4325: Use or later in all touched tests
2 weeks ago
samyou-softwire
818041d1f3
CLDC-4325: Remove 2024 rake
2 weeks ago
samyou-softwire
06b7ebd8d4
CLDC-4325: Fix check answers summary component
2 weeks ago
samyou-softwire
f9c2af53fd
CLDC-4325: Fix sales BU validator spec
2 weeks ago
samyou-softwire
50161119c6
CLDC-4325: Fix duplicate logs controller spec
...
also introduce a new helper for a dynamic way of setting year
2 weeks ago
samyou-softwire
62d24533dd
CLDC-4325: Fix hhmemb spec
2 weeks ago
samyou-softwire
21149f058c
CLDC-4325: Fix form controller spec
2 weeks ago
samyou-softwire
aea35f4bf2
CLDC-4325: Fix remaining model specs
2 weeks ago
samyou-softwire
4a41878630
CLDC-4221: Add 2026 collection deadlines
2 weeks ago
samyou-softwire
b4e5550058
CLDC-4325: Fix lettings household validations spec
2 weeks ago
samyou-softwire
527b57700c
CLDC-4325: Only add noms and org to CSV row if prp
...
in most cases this was done by default but some tests construct an invalid log
2 weeks ago
samyou-softwire
119df7cf46
CLDC-4325: Fix collection resources controller spec
2 weeks ago
samyou-softwire
95e6b6f1b1
CLDC-4325: Fix sales soft validations
2 weeks ago
samyou-softwire
64b815c436
CLDC-4325: Fix old rake task tests
2 weeks ago
samyou-softwire
e05829ae8e
CLDC-4325: Fix check answers spec
2 weeks ago
samyou-softwire
26babfe431
CLDC-4325: Fix sale information % tests
...
I'm not sure why I turned off strict post 2026, it's wanted in the same scenarios as before as shown by the failing tests
2 weeks ago
samyou-softwire
2f74fabf13
CLDC-4325: Set date to 2026
2 weeks ago
Samuel Young
b65de0c6d8
CLDC-4179: Fix duplicate logs check ( #3245 )
...
* Reapply "CLDC-4179: Amend sales duplicate log check (#3207 )" (#3241 )
This reverts commit 3bcc6627c0 .
* CLDC-4179: Enable BU duplicate log check on staging
2 weeks ago
Nat Dean-Lewis
d87aba906b
CLDC-4236: Deploy review apps manually using PR labels ( #3238 )
...
* CLDC-4263: implement minimal label-based approach
* CLDC-4263: add descriptive comment
* CLDC-4263: separate comment workflow
* CLDC-4263: add label check to code workflow
* CLDC-4263: always hint initially
* CLDC-4263: copy change test
* Revert "CLDC-4263: copy change test"
This reverts commit 09df8ab28f .
* CLDC-4263: rename review app workflows for clarity
* CLDC-4263: remove broken workflow_dispatches
* CLDC-4263: rename label
* CLDC-4236: renaming and commenting
2 weeks ago
Carolyn Barker
de4e0945a1
CLDC-4146 infer no other partners ( #3152 )
...
* CLDC-4146 infer no to multiple partners
* CLDC-4146 try removing factory change
* Simplify inference logic
* Fix not equals logic
* Improve person_partner tests
* Add tests for new not equals logic
* Improve person_lead_partner tests
* Fix inference logic
* Revert to simpler inference logic
* Correct hidden_in_check_answers logic
* Fixed derived?
* Improve lettings log variables tests
* Pull out resetting partner fields into method
* Convert 'else next' to guard clause
* Refactor infer_only_partner!
* Match updated requirements
* Fix tests
* Small tweaks
* Remove redundant logic from infer_at_most_one_relationship!
* Remove redundant `disable_clearing_if_not_routed_or_dynamic_answer_options`
* Add tests for question number
* Remove puts
* Refactor derived fields tests
* Fix lint
* After build, set nil values for `details_known` to 0
* Add details_known to tests
* Add question mark to method name
* Rewrite `is_another_person_partner?` to be `is_any_person_partner?`
* Move skip in form flow method from page to question
* Fix tests
* Fix tests after merge
---------
Co-authored-by: Carolyn <carolyn.barker@softwire.com>
Co-authored-by: oscar-richardson-softwire <oscar.richardson@softwire.com>
2 weeks ago
dependabot[bot]
c494890dea
Bump devise from 4.9.3 to 5.0.3 ( #3244 )
...
Bumps [devise](https://github.com/heartcombo/devise ) from 4.9.3 to 5.0.3.
- [Release notes](https://github.com/heartcombo/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/devise/compare/v4.9.3...v5.0.3 )
---
updated-dependencies:
- dependency-name: devise
dependency-version: 5.0.3
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 weeks ago
Nat Dean-Lewis
384435fdc6
Revert "CLDC-4246: Starter tenancy type copy updates ( #3229 )" ( #3242 )
...
This reverts commit 66dfdbfbb3 .
2 weeks ago
Samuel Young
3bcc6627c0
Revert "CLDC-4179: Amend sales duplicate log check ( #3207 )" ( #3241 )
...
This reverts commit c085cbb572 .
2 weeks ago
Samuel Young
61eb52516d
CLDC-4204: Update bulk upload fields sales ( #3223 )
...
* CLDC-4204: Renumber fields to match spec
* CLDC-4204: Update log to csv for 2026
* CLDC-4204: Cleanup BU todo commments
* CLDC-4204: Replace BU example file
* CLDC-4204: Update row parser question titles to match form
* fixup! CLDC-4204: Update row parser question titles to match form
fix sales log typo
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* fixup! CLDC-4204: Renumber fields to match spec
update dupe fields comment
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* fixup! CLDC-4204: Renumber fields to match spec
check the same field as before
---------
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
3 weeks ago
Nat Dean-Lewis
c95e33bf35
CLDC-4295: hhtype export updates ( #3232 )
...
* CLDC-4295: use correct hhtype header for 26 sales export specs
* CLDC-4295: update log var defs spec
3 weeks ago
Samuel Young
599307029d
CLDC-4215, CLDC-4216: Add mortgage used Don't Know option ( #3208 )
...
* CLDC-4215: Show Don't Know on all paths of mortgageused
* CLDC-4215: Update tests
* fixup! CLDC-4215: Show Don't Know on all paths of mortgageused
* fixup! CLDC-4215: Update tests
cover all cases
* fixup! CLDC-4215: Show Don't Know on all paths of mortgageused
* fixup! CLDC-4215: Update tests
3 weeks ago
Nat Dean-Lewis
1c4cfe5d1d
CLDC-4169, CLDC-4170, CLDC-4171, CLDC-4172: Remove VRTB discounted ownership type option from question and copy ( #3202 )
...
* CLDC-4169: remove VRTB option functionality
* CLDC-4169: remove VRTB option from copy
* CLDC-4169: update tests
* CLDC-4169: copy updates
* CLDC-4169: test updates
* CLDC-4169: test bu file updates
* CLDC-4169: test bu file updates
3 weeks ago
Nat Dean-Lewis
cd51f7c2c4
CLDC-4166: How many live in property updates ( #3194 )
...
* CLDC-4166: question updaets
* CLDC-4166: question updates
* CLDC-4166: test updates
* CLDC-4166: test updates
* CLDC-4166: test updates
* CLDC-4226: Index logs by org and ID (#3199 )
* CLDC-4226: index logs by org and id
* CLDC-4226: include teamwide non-functional schema change
* CLDC-4226: schema update
* CLDC-4176: fix failing tests
* CLDC-4176: renumber case insensitive fields test
* CLDC-4166: update csv export spec
* CLDC-4166: linting
* CLDC-4166: copy updates in fixtures
* CLDC-4166: copy updates in fixtures
* CLDC-4166: copy updates in fixtures
* CLDC-4166: var defs count update
* CLDC-4166: fixtures tweak for hhtype
* CLDC-4166: fixtures tweak for hhtype
* CLDC-4166: fixtures tweak for hhtype
* CLDC-4166: export update
* CLDC-4166: whitespace linting
* CLDC-4166: update number_of_others_in_property_spec.rb
* CLDC-4166: update log_variable_definitions_spec.rb
* CLDC-4166: update sales_log_csv_service_spec.rb
* CLDC-4166: update tests
* CLDC-4166: update tests
3 weeks ago
Samuel Young
f5f0e663e0
CLDC-4184: Update question numbers for sales ( #3221 )
...
* CLDC-4184: Consolidate logic for questions that appear in multiple subsections
* CLDC-4184: Ensure all 2025 questions have a number
* CLDC-4184: Add 2026 question numbers
* CLDC-4184: Update question numbers to match paper form
* CLDC-4184: Use the standard question hash function
* CLDC-4184: Lint
* CLDC-4184: Update tests
* fixup! CLDC-4184: Update question numbers to match paper form
* CLDC-4184: Commonise person question logic in sales
* fixup! CLDC-4184: Update question numbers to match paper form
add missing 2026 question
* fixup! CLDC-4184: Use the standard question hash function
missed nationality
* fixup! CLDC-4184: Update question numbers to match paper form
fix q111
* fixup! CLDC-4184: Update question numbers to match paper form
some missed questions
* CLDC-4184: Lint
* CLDC-4184: Fix test
3 weeks ago
Nat Dean-Lewis
ed2fdf344e
CLDC-4181: Add new sale range file ( #3228 )
...
* CLDc-4181: add 2026 sale ranges
* CLDc-4181: file cleanup
3 weeks ago
Nat Dean-Lewis
66dfdbfbb3
CLDC-4246: Starter tenancy type copy updates ( #3229 )
...
* CLDC-4249: reorder answer options
* CLDC-4246: reword question and add hint text for 25/26 and 26/27
* Revert "CLDC-4249: reorder answer options"
This reverts commit 26edc51615 .
* CLDC-4246: update tenancy type cya text and other copy
* CLDC-4246: update tenancy type cya text and other copy in 2025
3 weeks ago
Samuel Young
c085cbb572
CLDC-4179: Amend sales duplicate log check ( #3207 )
...
* CLDC-4179: Add sexrab & postcode to frontend duplicate log checks
* CLDC-4179: Add sexrab & postcode to BU duplicate log checks
* CLDC-4179: Update tests
3 weeks ago
Samuel Young
d2927f3e7a
CLDC-4212, CLDC-4213, CLDC-4214: Add 0.1% tolerance to all calculations that involve %s of a value ( #3214 )
...
* CLDC-4212: Add 0.1% tolerance to % calculations
this is to specifically allow 0.1% more or less than the calculation expects, for those that contain %s in them
this removes difficulties on adding 66.6% equity (or should it be 66.7%?)
* CLDC-4212: Remove discount soft validation
was replaced by a hard validation in CLDC-1899 so no longer serves a purpose
* CLDC-4212: Add tests
* fixup! CLDC-4212: Add 0.1% tolerance to % calculations
calculate a tolerance instead
* fixup! CLDC-4212: Add 0.1% tolerance to % calculations
update comment
3 weeks ago
Samuel Young
5ce2d0cb47
CLDC-4164, CLDC-4165: Update purchase price minimum to £15,000 for 2026 onwards ( #3198 )
...
* CLDC-4164: Update purchase price minimum to £15,000 for 2026 onwards
* CLDC-4164: Apply £15,000 minimum validation to shared ownership purchase price
* CLDC-4164: Update tests
* fixup! CLDC-4164: Update tests
add min tests for 25 and 26
3 weeks ago
Nat Dean-Lewis
a675ded32d
CLDc-4236: temporarily revert to auto review app deploy setup ( #3231 )
...
* Revert "CLDC-4236: misc pipeline updates (#3227 )"
This reverts commit cee09718fd .
* Revert "CLDC-4236: use correct sha ref for review apps"
This reverts commit 36918740f4 .
* Revert "CLDC-4236: use list-images in review app deployments"
This reverts commit 75ec4d1e75 .
* Revert "CLDC-4236: trigger review app deploys manually (#3216 )"
This reverts commit 8a186d096c .
3 weeks ago
Nat Dean-Lewis
cee09718fd
CLDC-4236: misc pipeline updates ( #3227 )
...
* CLDC-4236: remove workflow dispatch from prod pipeline
* CLDC-4236: update review pipeline flow with concurrency group, correct ref and inputs
* CLDC-4236: test copy change
* CLDC-4236: fix aws creds step
* CLDC-4236: set permissions
* Revert "CLDC-4236: test copy change"
This reverts commit c0d50b1e4b .
* empty commit
* CLDC-4136: change check if review app exists to check if review app deployment started to avoid not deploying changes made during first deployment
* CLDC-4136: don't allow manual teardown to avoid unnecessary edge cases
* CLDC-4236: add permissions to manual_review_code_pipeline.yml
3 weeks ago
Nat Dean-Lewis
36918740f4
CLDC-4236: use correct sha ref for review apps
3 weeks ago
Nat Dean-Lewis
75ec4d1e75
CLDC-4236: use list-images in review app deployments
3 weeks ago
Nat Dean-Lewis
f747034261
CLDC-4175: add new service charge question sales ( #3200 )
...
* add the question
* CLDC-4174: update question number for 2026
* CLDc-4174: update question number for 2026
* CLDc-4174: update subsection
* CLDc-4174: update question specs
* CLDC-4174: add subsection spec
* CLDc-4174: lint
* CLDc-4174: add new page test
* CLDC-4241: lint
* CLDC-4241: lint
* CLDC-4175: db updates
* CLDC-4175: add new question to ui flow
* CLDC-4175: csv label for new question
* CLDC-4175: row parser updates
* CLDC-4175: export updates
* CLDC-4174: copy updates
* CLDC-4174: add validation that new value is different
* CLDC-4174: parser updates
* CLDC-4174: migration linting
* CLDC-4174: add tests
* CLDC-4174: fixture updates
* CLDC-4174: linting
* CLDC-4175: export and test updates
* CLDC-4175: row parser field renumbering
* CLDC-4175: test fixes
* CLDC-4175: test and schema updates post merge
* CLDC-4175: lint
* CLDC-4175: lint
* CLDC-4175: lint
* CLDC-4175: add reverse validation
* CLDC-4175: cleanup sales_log_to_csv.rb
* CLDC-4226: test fixture updates
* CLDC-4175: update export spec
* CLDC-4175: update validation message
* CLDC-4175: remove redundant range validation
* CLDC-4175: test with real values in row parser
* CLDC-4175: export test updates
* CLDC-4175: update row parser spec and examples
* CLDC-4175: update row parser spec and examples
* CLDC-4175: update row parser spec and examples
* CLDC-4175: update row parser spec and examples
* CLDC-4175: update row parser spec and examples
* CLDC-4248: respond to comments
* CLDC-4175: remove newservicecharges custom call chain
* CLDC-4175: include new spec requirement
* CLDC-4175: update financial_validations_spec.rb
---------
Co-authored-by: Samuel Young <samuel.young@softwire.com>
3 weeks ago
Nat Dean-Lewis
8a186d096c
CLDC-4236: trigger review app deploys manually ( #3216 )
...
* CLDC-4236: make review deploy manual
* CLDC-4236: use pr comment trigger
* CLDC-4236: refactor
* CLDC-4236: add workflow permissions block
* CLDC-4236: add manual worflow dispatch method back in
* CLDC-4236: clarify workflow dispatch description
* CLDC-4236: rename pull_request_id input -> pr_number for consistency
3 weeks ago