feat: show completed/incomplete locations and validate when completed == 0

app/models/form/lettings/questions/location_id.rb

@@ -27,7 +27,7 @@ class Form::Lettings::Questions::LocationId < ::Form::Question
   def displayed_answer_options(lettings_log, _user = nil)
     return {} unless lettings_log.scheme
 
-    scheme_location_ids = lettings_log.scheme.locations.reject { |location| location.status_at(lettings_log.startdate || Time.zone.today) == :incomplete }.pluck(:id)
+    scheme_location_ids = lettings_log.scheme.locations.reject { |location| location.status == :incomplete }.pluck(:id)
     answer_options.select { |k, _v| scheme_location_ids.include?(k.to_i) }
   end
 

app/models/scheme.rb

@@ -166,9 +166,7 @@ class Scheme < ApplicationRecord
   end
 
   def appended_text
-    active_count = locations.count { |location| %i[active deactivating_soon].include?(location.status) }
+    "#{completed_locations_count} completed #{'location'.pluralize(completed_locations_count)}, #{incomplete_locations_count} incomplete #{'location'.pluralize(incomplete_locations_count)}"
-    inactive_count = locations.count { |location| !%i[active deactivating_soon].include?(location.status) }
-    "#{active_count} active #{'location'.pluralize(active_count)}, #{inactive_count} inactive #{'location'.pluralize(inactive_count)}"
   end
 
   def hint
@@ -237,7 +235,7 @@ class Scheme < ApplicationRecord
   end
 
   def status_at(date)
-    return :incomplete unless confirmed && has_active_locations?
+    return :incomplete unless confirmed && has_completed_locations?
     return :deactivated if open_deactivation&.deactivation_date.present? && date >= open_deactivation.deactivation_date
     return :deactivating_soon if open_deactivation&.deactivation_date.present? && date < open_deactivation.deactivation_date
     return :reactivating_soon if recent_deactivation&.reactivation_date.present? && date < recent_deactivation.reactivation_date
@@ -257,7 +255,17 @@ class Scheme < ApplicationRecord
     status == :deactivated
   end
 
-  def has_active_locations?
+  def has_completed_locations?
-    locations.count { |location| %i[active deactivating_soon].include?(location.status) }.positive?
+    completed_locations_count.positive?
+  end
+
+private
+
+  def completed_locations_count
+    locations.count { |location| location.status != :incomplete }
+  end
+
+  def incomplete_locations_count
+    locations.count { |location| location.status == :incomplete }
   end
 end

app/models/validations/setup_validations.rb

@@ -20,6 +20,14 @@ module Validations::SetupValidations
     location_during_startdate_validation(record, :location_id)
   end
 
+  def validate_scheme_has_completed_locations_validation(record)
+    return unless record.scheme
+
+    unless record.scheme.has_completed_locations?
+      record.errors.add :scheme_id, I18n.t("validations.scheme.no_completed_locations")
+    end
+  end
+
   def validate_scheme(record)
     location_during_startdate_validation(record, :scheme_id)
     scheme_during_startdate_validation(record, :scheme_id)

config/locales/en.yml

@@ -446,6 +446,7 @@ en:
         during_deactivated_period: "The scheme is already deactivated during this date, please enter a different date"
       owning_organisation:
         does_not_own_stock: "Enter an organisation that owns housing stock"
+      no_completed_locations: "This scheme cannot be chosen as it has 0 completed locations"
 
     location:
       postcode_blank: "Enter a postcode"