baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Add optional tags and remove LA from csv

pull/1953/head
Kat 3 years ago
parent
d616a3704f
commit
f8d4059a96
9 changed files with 28 additions and 34 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 22
      app/services/csv/missing_addresses_csv_service.rb
  2. 4
      spec/fixtures/files/missing_lettings_logs_addresses.csv
  3. 8
      spec/fixtures/files/missing_lettings_logs_addresses_all_issues.csv
  4. 4
      spec/fixtures/files/missing_lettings_logs_town_or_city.csv
  5. 4
      spec/fixtures/files/missing_lettings_logs_wrong_uprn.csv
  6. 4
      spec/fixtures/files/missing_sales_logs_addresses.csv
  7. 8
      spec/fixtures/files/missing_sales_logs_addresses_all_issues.csv
  8. 4
      spec/fixtures/files/missing_sales_logs_town_or_city.csv
  9. 4
      spec/fixtures/files/missing_sales_logs_wrong_uprn.csv

22
app/services/csv/missing_addresses_csv_service.rb
Unescape View File

@ -32,7 +32,7 @@ module Csv
return if logs_with_missing_addresses.empty? && logs_with_missing_town_or_city.empty? && logs_with_wrong_uprn.empty? return if logs_with_missing_addresses.empty? && logs_with_missing_town_or_city.empty? && logs_with_wrong_uprn.empty?
CSV.generate(headers: true) do |csv| CSV.generate(headers: true) do |csv|
csv << ["Issue type", "Lettings log ID", "Tenancy start date", "Tenant code", "Property code", "Log owner", "Owning organisation name", "Managing organisation name", "UPRN", "Address line 1", "Address line 2", "Town or City", "County", "Postcode", "Local authority"] csv << ["Issue type", "Lettings log ID", "Tenancy start date", "Tenant code", "Property code", "Log owner", "Owning organisation name", "Managing organisation name", "UPRN", "Address line 1", "Address line 2 (optional)", "Town or City", "County (optional)", "Postcode"]
logs_with_missing_addresses.each do |log| logs_with_missing_addresses.each do |log|
csv << ["Full address required", csv << ["Full address required",
@ -48,8 +48,7 @@ module Csv
log.address_line2, log.address_line2,
log.town_or_city, log.town_or_city,
log.county, log.county,
log.postcode_full, log.postcode_full]
log.la]
end end
logs_with_missing_town_or_city.each do |log| logs_with_missing_town_or_city.each do |log|
@ -66,8 +65,7 @@ module Csv
log.address_line2, log.address_line2,
log.town_or_city, log.town_or_city,
log.county, log.county,
log.postcode_full, log.postcode_full]
log.la]
end end
logs_with_wrong_uprn.each do |log| logs_with_wrong_uprn.each do |log|
@ -84,8 +82,7 @@ module Csv
log.address_line2, log.address_line2,
log.town_or_city, log.town_or_city,
log.county, log.county,
log.postcode_full, log.postcode_full]
log.la]
end end
end end
end end
@ -116,7 +113,7 @@ module Csv
return if logs_with_missing_addresses.empty? && logs_with_missing_town_or_city.empty? && logs_with_wrong_uprn.empty? return if logs_with_missing_addresses.empty? && logs_with_missing_town_or_city.empty? && logs_with_wrong_uprn.empty?
CSV.generate(headers: true) do |csv| CSV.generate(headers: true) do |csv|
csv << ["Issue type", "Sales log ID", "Sale completion date", "Purchaser code", "Log owner", "Owning organisation name", "UPRN", "Address line 1", "Address line 2", "Town or City", "County", "Postcode", "Local authority"] csv << ["Issue type", "Sales log ID", "Sale completion date", "Purchaser code", "Log owner", "Owning organisation name", "UPRN", "Address line 1", "Address line 2 (optional)", "Town or City", "County (optional)", "Postcode"]
logs_with_missing_addresses.each do |log| logs_with_missing_addresses.each do |log|
csv << ["Full address required", csv << ["Full address required",
@ -130,8 +127,7 @@ module Csv
log.address_line2, log.address_line2,
log.town_or_city, log.town_or_city,
log.county, log.county,
log.postcode_full, log.postcode_full]
log.la]
end end
logs_with_missing_town_or_city.each do |log| logs_with_missing_town_or_city.each do |log|
@ -146,8 +142,7 @@ module Csv
log.address_line2, log.address_line2,
log.town_or_city, log.town_or_city,
log.county, log.county,
log.postcode_full, log.postcode_full]
log.la]
end end
logs_with_wrong_uprn.each do |log| logs_with_wrong_uprn.each do |log|
@ -162,8 +157,7 @@ module Csv
log.address_line2, log.address_line2,
log.town_or_city, log.town_or_city,
log.county, log.county,
log.postcode_full, log.postcode_full]
log.la]
end end
end end
end end

4
spec/fixtures/files/missing_lettings_logs_addresses.csv vendored
Unescape View File

@ -1,2 +1,2 @@
Issue type,Lettings log ID,Tenancy start date,Tenant code,Property code,Log owner,Owning organisation name,Managing organisation name,UPRN,Address line 1,Address line 2,Town or City,County,Postcode,Local authority Issue type,Lettings log ID,Tenancy start date,Tenant code,Property code,Log owner,Owning organisation name,Managing organisation name,UPRN,Address line 1,Address line 2 (optional),Town or City,County (optional),Postcode
Full address required,{id},2023-04-05,tenancycode,propcode,testy@example.com,Address org,Address org,,,,,,, Full address required,{id},2023-04-05,tenancycode,propcode,testy@example.com,Address org,Address org,,,,,,

1 Issue type Lettings log ID Tenancy start date Tenant code Property code Log owner Owning organisation name Managing organisation name UPRN Address line 1 Address line 2 Address line 2 (optional) Town or City County County (optional) Postcode Local authority
2 Full address required {id} 2023-04-05 tenancycode propcode testy@example.com Address org Address org

8
spec/fixtures/files/missing_lettings_logs_addresses_all_issues.csv vendored
Unescape View File

@ -1,4 +1,4 @@
Issue type,Lettings log ID,Tenancy start date,Tenant code,Property code,Log owner,Owning organisation name,Managing organisation name,UPRN,Address line 1,Address line 2,Town or City,County,Postcode,Local authority Issue type,Lettings log ID,Tenancy start date,Tenant code,Property code,Log owner,Owning organisation name,Managing organisation name,UPRN,Address line 1,Address line 2 (optional),Town or City,County (optional),Postcode
Full address required,{id},2023-04-05,tenancycode,propcode,testy@example.com,Address org,Address org,,,,,,, Full address required,{id},2023-04-05,tenancycode,propcode,testy@example.com,Address org,Address org,,,,,,
Missing town or city,{id},2023-04-05,tenancycode,propcode,testy@example.com,Address org,Address org,,existing address,,,,, Missing town or city,{id},2023-04-05,tenancycode,propcode,testy@example.com,Address org,Address org,,existing address,,,,
UPRN issues,{id},2023-04-05,tenancycode,propcode,testy@example.com,Address org,Address org,123,Some Place,,Bristol,,BS1 1AD, UPRN issues,{id},2023-04-05,tenancycode,propcode,testy@example.com,Address org,Address org,123,Some Place,,Bristol,,BS1 1AD

1 Issue type Lettings log ID Tenancy start date Tenant code Property code Log owner Owning organisation name Managing organisation name UPRN Address line 1 Address line 2 Address line 2 (optional) Town or City County County (optional) Postcode Local authority
2 Full address required {id} 2023-04-05 tenancycode propcode testy@example.com Address org Address org
3 Missing town or city {id} 2023-04-05 tenancycode propcode testy@example.com Address org Address org existing address
4 UPRN issues {id} 2023-04-05 tenancycode propcode testy@example.com Address org Address org 123 Some Place Bristol BS1 1AD

4
spec/fixtures/files/missing_lettings_logs_town_or_city.csv vendored
Unescape View File

@ -1,2 +1,2 @@
Issue type,Lettings log ID,Tenancy start date,Tenant code,Property code,Log owner,Owning organisation name,Managing organisation name,UPRN,Address line 1,Address line 2,Town or City,County,Postcode,Local authority Issue type,Lettings log ID,Tenancy start date,Tenant code,Property code,Log owner,Owning organisation name,Managing organisation name,UPRN,Address line 1,Address line 2 (optional),Town or City,County (optional),Postcode
Missing town or city,{id},2023-04-05,tenancycode,propcode,testy@example.com,Address org,Address org,,existing address,,,,, Missing town or city,{id},2023-04-05,tenancycode,propcode,testy@example.com,Address org,Address org,,existing address,,,,

1 Issue type Lettings log ID Tenancy start date Tenant code Property code Log owner Owning organisation name Managing organisation name UPRN Address line 1 Address line 2 Address line 2 (optional) Town or City County County (optional) Postcode Local authority
2 Missing town or city {id} 2023-04-05 tenancycode propcode testy@example.com Address org Address org existing address

4
spec/fixtures/files/missing_lettings_logs_wrong_uprn.csv vendored
Unescape View File

@ -1,2 +1,2 @@
Issue type,Lettings log ID,Tenancy start date,Tenant code,Property code,Log owner,Owning organisation name,Managing organisation name,UPRN,Address line 1,Address line 2,Town or City,County,Postcode,Local authority Issue type,Lettings log ID,Tenancy start date,Tenant code,Property code,Log owner,Owning organisation name,Managing organisation name,UPRN,Address line 1,Address line 2 (optional),Town or City,County (optional),Postcode
UPRN issues,{id},2023-04-05,tenancycode,12,testy@example.com,Address org,Address org,12,Some Place,,Newcastle,,EC1N 2TD, UPRN issues,{id},2023-04-05,tenancycode,12,testy@example.com,Address org,Address org,12,Some Place,,Newcastle,,EC1N 2TD

1 Issue type Lettings log ID Tenancy start date Tenant code Property code Log owner Owning organisation name Managing organisation name UPRN Address line 1 Address line 2 Address line 2 (optional) Town or City County County (optional) Postcode Local authority
2 UPRN issues {id} 2023-04-05 tenancycode 12 testy@example.com Address org Address org 12 Some Place Newcastle EC1N 2TD

4
spec/fixtures/files/missing_sales_logs_addresses.csv vendored
Unescape View File

@ -1,2 +1,2 @@
Issue type,Sales log ID,Sale completion date,Purchaser code,Log owner,Owning organisation name,UPRN,Address line 1,Address line 2,Town or City,County,Postcode,Local authority Issue type,Sales log ID,Sale completion date,Purchaser code,Log owner,Owning organisation name,UPRN,Address line 1,Address line 2 (optional),Town or City,County (optional),Postcode
Full address required,{id},2023-04-05,purchaser code,testy@example.com,Address org,,,,,,, Full address required,{id},2023-04-05,purchaser code,testy@example.com,Address org,,,,,,

1 Issue type Sales log ID Sale completion date Purchaser code Log owner Owning organisation name UPRN Address line 1 Address line 2 Address line 2 (optional) Town or City County County (optional) Postcode Local authority
2 Full address required {id} 2023-04-05 purchaser code testy@example.com Address org

8
spec/fixtures/files/missing_sales_logs_addresses_all_issues.csv vendored
Unescape View File

@ -1,4 +1,4 @@
Issue type,Sales log ID,Sale completion date,Purchaser code,Log owner,Owning organisation name,UPRN,Address line 1,Address line 2,Town or City,County,Postcode,Local authority Issue type,Sales log ID,Sale completion date,Purchaser code,Log owner,Owning organisation name,UPRN,Address line 1,Address line 2 (optional),Town or City,County (optional),Postcode
Full address required,{id},2023-04-05,purchaser code,testy@example.com,Address org,,,,,,, Full address required,{id},2023-04-05,purchaser code,testy@example.com,Address org,,,,,,
Missing town or city,{id},2023-04-05,purchaser code,testy@example.com,Address org,,existing address line 1,,,,, Missing town or city,{id},2023-04-05,purchaser code,testy@example.com,Address org,,existing address line 1,,,,
UPRN issues,{id},2023-04-05,purchaser code,testy@example.com,Address org,123,Some Place,,Bristol,,BS1 1AD, UPRN issues,{id},2023-04-05,purchaser code,testy@example.com,Address org,123,Some Place,,Bristol,,BS1 1AD

1 Issue type Sales log ID Sale completion date Purchaser code Log owner Owning organisation name UPRN Address line 1 Address line 2 Address line 2 (optional) Town or City County County (optional) Postcode Local authority
2 Full address required {id} 2023-04-05 purchaser code testy@example.com Address org
3 Missing town or city {id} 2023-04-05 purchaser code testy@example.com Address org existing address line 1
4 UPRN issues {id} 2023-04-05 purchaser code testy@example.com Address org 123 Some Place Bristol BS1 1AD

4
spec/fixtures/files/missing_sales_logs_town_or_city.csv vendored
Unescape View File

@ -1,2 +1,2 @@
Issue type,Sales log ID,Sale completion date,Purchaser code,Log owner,Owning organisation name,UPRN,Address line 1,Address line 2,Town or City,County,Postcode,Local authority Issue type,Sales log ID,Sale completion date,Purchaser code,Log owner,Owning organisation name,UPRN,Address line 1,Address line 2 (optional),Town or City,County (optional),Postcode
Missing town or city,{id},2023-04-05,purchaser code,testy@example.com,Address org,,existing address line 1,,,,, Missing town or city,{id},2023-04-05,purchaser code,testy@example.com,Address org,,existing address line 1,,,,

1 Issue type Sales log ID Sale completion date Purchaser code Log owner Owning organisation name UPRN Address line 1 Address line 2 Address line 2 (optional) Town or City County County (optional) Postcode Local authority
2 Missing town or city {id} 2023-04-05 purchaser code testy@example.com Address org existing address line 1

4
spec/fixtures/files/missing_sales_logs_wrong_uprn.csv vendored
Unescape View File

@ -1,2 +1,2 @@
Issue type,Sales log ID,Sale completion date,Purchaser code,Log owner,Owning organisation name,UPRN,Address line 1,Address line 2,Town or City,County,Postcode,Local authority Issue type,Sales log ID,Sale completion date,Purchaser code,Log owner,Owning organisation name,UPRN,Address line 1,Address line 2 (optional),Town or City,County (optional),Postcode
UPRN issues,{id},2023-04-05,12,testy@example.com,Address org,12,Some Place,,Newcastle,,EC1N 2TD, UPRN issues,{id},2023-04-05,12,testy@example.com,Address org,12,Some Place,,Newcastle,,EC1N 2TD

1 Issue type Sales log ID Sale completion date Purchaser code Log owner Owning organisation name UPRN Address line 1 Address line 2 Address line 2 (optional) Town or City County County (optional) Postcode Local authority
2 UPRN issues {id} 2023-04-05 12 testy@example.com Address org 12 Some Place Newcastle EC1N 2TD
Write Preview
Loading…
Cancel
Save