Browse Source

feat: put duplicate logs check feature behind toggle

pull/1334/head
Sam Seed 3 years ago committed by Phil Lee
parent
commit
f146629095
  1. 2
      app/services/bulk_upload/lettings/validator.rb
  2. 2
      app/services/bulk_upload/lettings/year2022/row_parser.rb
  3. 2
      app/services/bulk_upload/lettings/year2023/row_parser.rb

2
app/services/bulk_upload/lettings/validator.rb

@ -43,7 +43,7 @@ class BulkUpload::Lettings::Validator
def create_logs?
return false if any_setup_errors?
return false if row_parsers.any?(&:block_log_creation?)
return false if any_logs_already_exist?
return false if any_logs_already_exist? && FeatureToggle.bulk_upload_duplicate_log_check_enabled?
return false if any_logs_invalid?
true

2
app/services/bulk_upload/lettings/year2022/row_parser.rb

@ -307,7 +307,7 @@ class BulkUpload::Lettings::Year2022::RowParser
validate :validate_no_disabled_needs_conjunction, on: :after_log
validate :validate_dont_know_disabled_needs_conjunction, on: :after_log
validate :validate_no_and_dont_know_disabled_needs_conjunction, on: :after_log
validate :validate_if_log_already_exists, on: :after_log
validate :validate_if_log_already_exists, on: :after_log, if: -> { FeatureToggle.bulk_upload_duplicate_log_check_enabled? }
validate :validate_owning_org_data_given, on: :after_log
validate :validate_owning_org_exists, on: :after_log

2
app/services/bulk_upload/lettings/year2023/row_parser.rb

@ -311,7 +311,7 @@ class BulkUpload::Lettings::Year2023::RowParser
validate :validate_no_disabled_needs_conjunction, on: :after_log
validate :validate_dont_know_disabled_needs_conjunction, on: :after_log
validate :validate_no_and_dont_know_disabled_needs_conjunction, on: :after_log
validate :validate_if_log_already_exists, on: :after_log
validate :validate_if_log_already_exists, on: :after_log, if: -> { FeatureToggle.bulk_upload_duplicate_log_check_enabled? }
validate :validate_owning_org_data_given, on: :after_log
validate :validate_owning_org_exists, on: :after_log

Loading…
Cancel
Save