From f146629095717f9cebd88a78f6e3a7487186fab4 Mon Sep 17 00:00:00 2001 From: Sam Seed Date: Thu, 30 Mar 2023 18:52:43 +0100 Subject: [PATCH] feat: put duplicate logs check feature behind toggle --- app/services/bulk_upload/lettings/validator.rb | 2 +- app/services/bulk_upload/lettings/year2022/row_parser.rb | 2 +- app/services/bulk_upload/lettings/year2023/row_parser.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/services/bulk_upload/lettings/validator.rb b/app/services/bulk_upload/lettings/validator.rb index ec18e946b..ab8120089 100644 --- a/app/services/bulk_upload/lettings/validator.rb +++ b/app/services/bulk_upload/lettings/validator.rb @@ -43,7 +43,7 @@ class BulkUpload::Lettings::Validator def create_logs? return false if any_setup_errors? return false if row_parsers.any?(&:block_log_creation?) - return false if any_logs_already_exist? + return false if any_logs_already_exist? && FeatureToggle.bulk_upload_duplicate_log_check_enabled? return false if any_logs_invalid? true diff --git a/app/services/bulk_upload/lettings/year2022/row_parser.rb b/app/services/bulk_upload/lettings/year2022/row_parser.rb index 743b40af8..d20ec9236 100644 --- a/app/services/bulk_upload/lettings/year2022/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2022/row_parser.rb @@ -307,7 +307,7 @@ class BulkUpload::Lettings::Year2022::RowParser validate :validate_no_disabled_needs_conjunction, on: :after_log validate :validate_dont_know_disabled_needs_conjunction, on: :after_log validate :validate_no_and_dont_know_disabled_needs_conjunction, on: :after_log - validate :validate_if_log_already_exists, on: :after_log + validate :validate_if_log_already_exists, on: :after_log, if: -> { FeatureToggle.bulk_upload_duplicate_log_check_enabled? } validate :validate_owning_org_data_given, on: :after_log validate :validate_owning_org_exists, on: :after_log diff --git a/app/services/bulk_upload/lettings/year2023/row_parser.rb b/app/services/bulk_upload/lettings/year2023/row_parser.rb index 61fc124f1..bd0cb984e 100644 --- a/app/services/bulk_upload/lettings/year2023/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/row_parser.rb @@ -311,7 +311,7 @@ class BulkUpload::Lettings::Year2023::RowParser validate :validate_no_disabled_needs_conjunction, on: :after_log validate :validate_dont_know_disabled_needs_conjunction, on: :after_log validate :validate_no_and_dont_know_disabled_needs_conjunction, on: :after_log - validate :validate_if_log_already_exists, on: :after_log + validate :validate_if_log_already_exists, on: :after_log, if: -> { FeatureToggle.bulk_upload_duplicate_log_check_enabled? } validate :validate_owning_org_data_given, on: :after_log validate :validate_owning_org_exists, on: :after_log