Browse Source

CLDC-3265: Duplicate whitespace row fix to sales BU

pull/2481/head
Rachael Booth 2 years ago
parent
commit
efcc6b18e1
  1. 1
      app/services/bulk_upload/sales/year2023/row_parser.rb
  2. 1
      app/services/bulk_upload/sales/year2024/row_parser.rb
  3. 11
      spec/services/bulk_upload/sales/year2023/row_parser_spec.rb
  4. 11
      spec/services/bulk_upload/sales/year2024/row_parser_spec.rb

1
app/services/bulk_upload/sales/year2023/row_parser.rb

@ -483,6 +483,7 @@ class BulkUpload::Sales::Year2023::RowParser
.to_hash .to_hash
.reject { |k, _| %w[bulk_upload block_log_creation].include?(k) } .reject { |k, _| %w[bulk_upload block_log_creation].include?(k) }
.values .values
.reject(&:blank?)
.compact .compact
.empty? .empty?
end end

1
app/services/bulk_upload/sales/year2024/row_parser.rb

@ -488,6 +488,7 @@ class BulkUpload::Sales::Year2024::RowParser
.to_hash .to_hash
.reject { |k, _| %w[bulk_upload block_log_creation].include?(k) } .reject { |k, _| %w[bulk_upload block_log_creation].include?(k) }
.values .values
.reject(&:blank?)
.compact .compact
.empty? .empty?
end end

11
spec/services/bulk_upload/sales/year2023/row_parser_spec.rb

@ -133,6 +133,17 @@ RSpec.describe BulkUpload::Sales::Year2023::RowParser do
expect(parser).not_to be_blank_row expect(parser).not_to be_blank_row
end end
end end
context "when the only populated fields are empty strings or whitespace" do
before do
parser.field_6 = " "
parser.field_19 = ""
end
it "returns true" do
expect(parser).to be_blank_row
end
end
end end
describe "purchaser_code" do describe "purchaser_code" do

11
spec/services/bulk_upload/sales/year2024/row_parser_spec.rb

@ -141,6 +141,17 @@ RSpec.describe BulkUpload::Sales::Year2024::RowParser do
expect(parser).not_to be_blank_row expect(parser).not_to be_blank_row
end end
end end
context "when the only populated fields are empty strings or whitespace" do
before do
parser.field_6 = " "
parser.field_19 = ""
end
it "returns true" do
expect(parser).to be_blank_row
end
end
end end
describe "purchaser_code" do describe "purchaser_code" do

Loading…
Cancel
Save