Refactor query

2 years ago · e995839ba4
1 changed files with 1 additions and 2 deletions
--- a/app/policies/scheme_policy.rb
+++ b/app/policies/scheme_policy.rb
@ -84,8 +84,7 @@ private

  def has_any_logs_in_editable_collection_period
    editable_from_date = FormHandler.instance.earliest_open_for_editing_collection_start_date
-    editable_logs = LettingsLog.where(scheme_id: scheme.id).after_date(editable_from_date)

-    LettingsLog.where(scheme_id: scheme.id, startdate: nil).any? || editable_logs.any?
+    LettingsLog.where(scheme_id: scheme.id).after_date(editable_from_date).or(LettingsLog.where(startdate: nil, scheme_id: scheme.id)).any?
  end
 end