From e995839ba4a355e723a26a7eca4d8b535a47958c Mon Sep 17 00:00:00 2001 From: Kat Date: Tue, 5 Mar 2024 11:21:13 +0000 Subject: [PATCH] Refactor query --- app/policies/scheme_policy.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/policies/scheme_policy.rb b/app/policies/scheme_policy.rb index 36a12ae2c..6b97a46de 100644 --- a/app/policies/scheme_policy.rb +++ b/app/policies/scheme_policy.rb @@ -84,8 +84,7 @@ private def has_any_logs_in_editable_collection_period editable_from_date = FormHandler.instance.earliest_open_for_editing_collection_start_date - editable_logs = LettingsLog.where(scheme_id: scheme.id).after_date(editable_from_date) - LettingsLog.where(scheme_id: scheme.id, startdate: nil).any? || editable_logs.any? + LettingsLog.where(scheme_id: scheme.id).after_date(editable_from_date).or(LettingsLog.where(startdate: nil, scheme_id: scheme.id)).any? end end