Browse Source

feat: make offered unsafe as 0.00 is an expected value

pull/1881/head
natdeanlewissoftwire 3 years ago
parent
commit
dcb493f09d
  1. 2
      app/services/imports/lettings_logs_import_service.rb
  2. 19
      spec/services/imports/lettings_logs_import_service_spec.rb

2
app/services/imports/lettings_logs_import_service.rb

@ -174,7 +174,7 @@ module Imports
0 0
end end
attributes["offered"] = safe_string_as_integer(xml_doc, "Q20") attributes["offered"] = unsafe_string_as_integer(xml_doc, "Q20")
attributes["propcode"] = string_or_nil(xml_doc, "Q21a") attributes["propcode"] = string_or_nil(xml_doc, "Q21a")
attributes["beds"] = safe_string_as_integer(xml_doc, "Q22") attributes["beds"] = safe_string_as_integer(xml_doc, "Q22")
attributes["unittype_gn"] = unsafe_string_as_integer(xml_doc, "Q23") attributes["unittype_gn"] = unsafe_string_as_integer(xml_doc, "Q23")

19
spec/services/imports/lettings_logs_import_service_spec.rb

@ -442,6 +442,25 @@ RSpec.describe Imports::LettingsLogsImportService do
end end
end end
context "and the number of times the property was relet is 0.00" do
before do
lettings_log_xml.at_xpath("//xmlns:Q20").content = "0.00"
end
it "does not raise an error" do
expect { lettings_log_service.send(:create_log, lettings_log_xml) }
.not_to raise_error
end
it "does not clear offered answer" do
lettings_log_service.send(:create_log, lettings_log_xml)
lettings_log = LettingsLog.find_by(old_id: lettings_log_id)
expect(lettings_log).not_to be_nil
expect(lettings_log.offered).to equal(0)
end
end
context "when the log being imported was manually entered" do context "when the log being imported was manually entered" do
it "sets the creation method correctly" do it "sets the creation method correctly" do
lettings_log_service.send(:create_log, lettings_log_xml) lettings_log_service.send(:create_log, lettings_log_xml)

Loading…
Cancel
Save