refactor: lint

app/services/csv/sales_log_csv_service.rb

@@ -133,7 +133,7 @@ module Csv
       "managing_organisation_id" => %w[managing_organisation_name],
     }.freeze
 
-    def SUPPORT_ONLY_ATTRIBITES = %w[address_line1_as_entered address_line2_as_entered town_or_city_as_entered county_as_entered postcode_full_as_entered la_as_entered]
+    SUPPORT_ONLY_ATTRIBITES = %w[address_line1_as_entered address_line2_as_entered town_or_city_as_entered county_as_entered postcode_full_as_entered la_as_entered].freeze
 
     def sales_log_attributes
       ordered_questions = FormHandler.instance.ordered_sales_questions_for_all_years

db/migrate/20240319092425_add_entered_address_fields_to_lettings_logs.rb

@@ -1,10 +1,12 @@
 class AddEnteredAddressFieldsToLettingsLogs < ActiveRecord::Migration[7.0]
   def change
-    add_column :lettings_logs, :address_line1_as_entered, :string
+    change_table :lettings_logs, bulk: true do |t|
-    add_column :lettings_logs, :address_line2_as_entered, :string
+      t.column :address_line1_as_entered, :string
-    add_column :lettings_logs, :town_or_city_as_entered, :string
+      t.column :address_line2_as_entered, :string
-    add_column :lettings_logs, :county_as_entered, :string
+      t.column :town_or_city_as_entered, :string
-    add_column :lettings_logs, :postcode_full_as_entered, :string
+      t.column :county_as_entered, :string
-    add_column :lettings_logs, :la_as_entered, :string
+      t.column :postcode_full_as_entered, :string
+      t.column :la_as_entered, :string
+    end
   end
 end

db/migrate/20240319115447_add_entered_address_fields_to_sales_logs.rb

@@ -1,10 +1,12 @@
 class AddEnteredAddressFieldsToSalesLogs < ActiveRecord::Migration[7.0]
   def change
-    add_column :sales_logs, :address_line1_as_entered, :string
+    change_table :sales_logs, bulk: true do |t|
-    add_column :sales_logs, :address_line2_as_entered, :string
+      t.column :address_line1_as_entered, :string
-    add_column :sales_logs, :town_or_city_as_entered, :string
+      t.column :address_line2_as_entered, :string
-    add_column :sales_logs, :county_as_entered, :string
+      t.column :town_or_city_as_entered, :string
-    add_column :sales_logs, :postcode_full_as_entered, :string
+      t.column :county_as_entered, :string
-    add_column :sales_logs, :la_as_entered, :string
+      t.column :postcode_full_as_entered, :string
+      t.column :la_as_entered, :string
+    end
   end
 end