From d8491cb7ae29e5aed58d328d21ea96122fff978a Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Tue, 19 Mar 2024 12:23:53 +0000 Subject: [PATCH] refactor: lint --- app/services/csv/sales_log_csv_service.rb | 2 +- ..._add_entered_address_fields_to_lettings_logs.rb | 14 ++++++++------ ...447_add_entered_address_fields_to_sales_logs.rb | 14 ++++++++------ 3 files changed, 17 insertions(+), 13 deletions(-) diff --git a/app/services/csv/sales_log_csv_service.rb b/app/services/csv/sales_log_csv_service.rb index 315b450b0..d1a56389e 100644 --- a/app/services/csv/sales_log_csv_service.rb +++ b/app/services/csv/sales_log_csv_service.rb @@ -133,7 +133,7 @@ module Csv "managing_organisation_id" => %w[managing_organisation_name], }.freeze - def SUPPORT_ONLY_ATTRIBITES = %w[address_line1_as_entered address_line2_as_entered town_or_city_as_entered county_as_entered postcode_full_as_entered la_as_entered] + SUPPORT_ONLY_ATTRIBITES = %w[address_line1_as_entered address_line2_as_entered town_or_city_as_entered county_as_entered postcode_full_as_entered la_as_entered].freeze def sales_log_attributes ordered_questions = FormHandler.instance.ordered_sales_questions_for_all_years diff --git a/db/migrate/20240319092425_add_entered_address_fields_to_lettings_logs.rb b/db/migrate/20240319092425_add_entered_address_fields_to_lettings_logs.rb index b02da90c2..2fa908788 100644 --- a/db/migrate/20240319092425_add_entered_address_fields_to_lettings_logs.rb +++ b/db/migrate/20240319092425_add_entered_address_fields_to_lettings_logs.rb @@ -1,10 +1,12 @@ class AddEnteredAddressFieldsToLettingsLogs < ActiveRecord::Migration[7.0] def change - add_column :lettings_logs, :address_line1_as_entered, :string - add_column :lettings_logs, :address_line2_as_entered, :string - add_column :lettings_logs, :town_or_city_as_entered, :string - add_column :lettings_logs, :county_as_entered, :string - add_column :lettings_logs, :postcode_full_as_entered, :string - add_column :lettings_logs, :la_as_entered, :string + change_table :lettings_logs, bulk: true do |t| + t.column :address_line1_as_entered, :string + t.column :address_line2_as_entered, :string + t.column :town_or_city_as_entered, :string + t.column :county_as_entered, :string + t.column :postcode_full_as_entered, :string + t.column :la_as_entered, :string + end end end diff --git a/db/migrate/20240319115447_add_entered_address_fields_to_sales_logs.rb b/db/migrate/20240319115447_add_entered_address_fields_to_sales_logs.rb index 8eb95eefc..a92aa3078 100644 --- a/db/migrate/20240319115447_add_entered_address_fields_to_sales_logs.rb +++ b/db/migrate/20240319115447_add_entered_address_fields_to_sales_logs.rb @@ -1,10 +1,12 @@ class AddEnteredAddressFieldsToSalesLogs < ActiveRecord::Migration[7.0] def change - add_column :sales_logs, :address_line1_as_entered, :string - add_column :sales_logs, :address_line2_as_entered, :string - add_column :sales_logs, :town_or_city_as_entered, :string - add_column :sales_logs, :county_as_entered, :string - add_column :sales_logs, :postcode_full_as_entered, :string - add_column :sales_logs, :la_as_entered, :string + change_table :sales_logs, bulk: true do |t| + t.column :address_line1_as_entered, :string + t.column :address_line2_as_entered, :string + t.column :town_or_city_as_entered, :string + t.column :county_as_entered, :string + t.column :postcode_full_as_entered, :string + t.column :la_as_entered, :string + end end end