Browse Source

do not block log creation if user not found

pull/1482/head
Phil Lee 3 years ago
parent
commit
d0bf0854a7
  1. 1
      app/services/bulk_upload/lettings/year2022/row_parser.rb
  2. 1
      app/services/bulk_upload/lettings/year2023/row_parser.rb
  3. 4
      spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb
  4. 4
      spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

1
app/services/bulk_upload/lettings/year2022/row_parser.rb

@ -389,7 +389,6 @@ private
return if field_112.blank?
unless created_by
block_log_creation!
errors.add(:field_112, "User with the specified email could not be found")
end
end

1
app/services/bulk_upload/lettings/year2023/row_parser.rb

@ -392,7 +392,6 @@ private
return if field_3.blank?
unless created_by
block_log_creation!
errors.add(:field_3, "User with the specified email could not be found")
end
end

4
spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb

@ -716,10 +716,6 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do
it "is not permitted" do
expect(parser.errors[:field_112]).to be_present
end
it "blocks log creation" do
expect(parser).to be_block_log_creation
end
end
context "when an unaffiliated user" do

4
spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

@ -257,10 +257,6 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do
it "is not permitted" do
expect(parser.errors[:field_3]).to be_present
end
it "blocks log creation" do
expect(parser).to be_block_log_creation
end
end
context "when an unaffiliated user" do

Loading…
Cancel
Save