From d0bf0854a78aa3ef58695cce8f105a54c09c133b Mon Sep 17 00:00:00 2001 From: Phil Lee Date: Tue, 28 Mar 2023 16:26:34 +0100 Subject: [PATCH] do not block log creation if user not found --- app/services/bulk_upload/lettings/year2022/row_parser.rb | 1 - app/services/bulk_upload/lettings/year2023/row_parser.rb | 1 - .../services/bulk_upload/lettings/year2022/row_parser_spec.rb | 4 ---- .../services/bulk_upload/lettings/year2023/row_parser_spec.rb | 4 ---- 4 files changed, 10 deletions(-) diff --git a/app/services/bulk_upload/lettings/year2022/row_parser.rb b/app/services/bulk_upload/lettings/year2022/row_parser.rb index 9659a95f6..fb392dfc7 100644 --- a/app/services/bulk_upload/lettings/year2022/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2022/row_parser.rb @@ -389,7 +389,6 @@ private return if field_112.blank? unless created_by - block_log_creation! errors.add(:field_112, "User with the specified email could not be found") end end diff --git a/app/services/bulk_upload/lettings/year2023/row_parser.rb b/app/services/bulk_upload/lettings/year2023/row_parser.rb index 921e42e89..99b9dde88 100644 --- a/app/services/bulk_upload/lettings/year2023/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/row_parser.rb @@ -392,7 +392,6 @@ private return if field_3.blank? unless created_by - block_log_creation! errors.add(:field_3, "User with the specified email could not be found") end end diff --git a/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb index 4c88e6bb5..a03516852 100644 --- a/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2022/row_parser_spec.rb @@ -716,10 +716,6 @@ RSpec.describe BulkUpload::Lettings::Year2022::RowParser do it "is not permitted" do expect(parser.errors[:field_112]).to be_present end - - it "blocks log creation" do - expect(parser).to be_block_log_creation - end end context "when an unaffiliated user" do diff --git a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb index f32876335..aff3b0516 100644 --- a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb @@ -257,10 +257,6 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do it "is not permitted" do expect(parser.errors[:field_3]).to be_present end - - it "blocks log creation" do - expect(parser).to be_block_log_creation - end end context "when an unaffiliated user" do