Browse Source

Add chosen journey for sales soft validations

pull/1670/head
Kat 3 years ago
parent
commit
cccc8dead0
  1. 9
      app/controllers/bulk_upload_sales_soft_validations_check_controller.rb
  2. 31
      app/models/forms/bulk_upload_sales_soft_validations_check/chosen.rb
  3. 21
      app/models/forms/bulk_upload_sales_soft_validations_check/confirm.rb
  4. 13
      app/models/forms/bulk_upload_sales_soft_validations_check/confirm_soft_errors.rb
  5. 14
      app/views/bulk_upload_sales_soft_validations_check/chosen.html.erb
  6. 34
      spec/requests/bulk_upload_sales_soft_validations_check_controller_spec.rb

9
app/controllers/bulk_upload_sales_soft_validations_check_controller.rb

@ -2,10 +2,17 @@ class BulkUploadSalesSoftValidationsCheckController < ApplicationController
include ActionView::Helpers::TextHelper include ActionView::Helpers::TextHelper
before_action :authenticate_user! before_action :authenticate_user!
before_action :set_no_cache_headers
def set_no_cache_headers
response.set_header("Cache-Control", "no-store")
end
def show def show
@bulk_upload = current_user.bulk_uploads.find(params[:id]) @bulk_upload = current_user.bulk_uploads.find(params[:id])
return redirect_to form.preflight_redirect unless form.preflight_valid?
render form.view_path render form.view_path
end end
@ -30,6 +37,8 @@ private
@form ||= case params[:page] @form ||= case params[:page]
when "confirm-soft-errors" when "confirm-soft-errors"
Forms::BulkUploadSalesSoftValidationsCheck::ConfirmSoftErrors.new(form_params.merge(bulk_upload: @bulk_upload)) Forms::BulkUploadSalesSoftValidationsCheck::ConfirmSoftErrors.new(form_params.merge(bulk_upload: @bulk_upload))
when "chosen"
Forms::BulkUploadSalesSoftValidationsCheck::Chosen.new(form_params.merge(bulk_upload: @bulk_upload))
when "confirm" when "confirm"
Forms::BulkUploadSalesSoftValidationsCheck::Confirm.new(form_params.merge(bulk_upload: @bulk_upload)) Forms::BulkUploadSalesSoftValidationsCheck::Confirm.new(form_params.merge(bulk_upload: @bulk_upload))
else else

31
app/models/forms/bulk_upload_sales_soft_validations_check/chosen.rb

@ -0,0 +1,31 @@
module Forms
module BulkUploadSalesSoftValidationsCheck
class Chosen
include ActiveModel::Model
include ActiveModel::Attributes
include Rails.application.routes.url_helpers
attribute :bulk_upload
def view_path
"bulk_upload_sales_soft_validations_check/chosen"
end
def back_path
sales_logs_path
end
def next_path
sales_logs_path
end
def save!
true
end
def preflight_valid?
true
end
end
end
end

21
app/models/forms/bulk_upload_sales_soft_validations_check/confirm.rb

@ -20,11 +20,28 @@ module Forms
end end
def save! def save!
processor = BulkUpload::Processor.new(bulk_upload:) ApplicationRecord.transaction do
processor.approve_and_confirm_soft_validations processor = BulkUpload::Processor.new(bulk_upload:)
processor.approve_and_confirm_soft_validations
bulk_upload.update!(choice: "bulk-confirm-soft-validations")
end
true true
end end
def preflight_valid?
bulk_upload.choice != "bulk-confirm-soft-validations" && bulk_upload.choice != "create-fix-inline"
end
def preflight_redirect
case bulk_upload.choice
when "bulk-confirm-soft-validations"
page_bulk_upload_sales_soft_validations_check_path(bulk_upload, :chosen)
when "create-fix-inline"
page_bulk_upload_sales_resume_path(bulk_upload, :chosen)
end
end
end end
end end
end end

13
app/models/forms/bulk_upload_sales_soft_validations_check/confirm_soft_errors.rb

@ -35,6 +35,19 @@ module Forms
def save! def save!
true true
end end
def preflight_valid?
bulk_upload.choice != "bulk-confirm-soft-validations" && bulk_upload.choice != "create-fix-inline"
end
def preflight_redirect
case bulk_upload.choice
when "bulk-confirm-soft-validations"
page_bulk_upload_sales_soft_validations_check_path(bulk_upload, :chosen)
when "create-fix-inline"
page_bulk_upload_sales_resume_path(bulk_upload, :chosen)
end
end
end end
end end
end end

14
app/views/bulk_upload_sales_soft_validations_check/chosen.html.erb

@ -0,0 +1,14 @@
<% content_for :before_content do %>
<%= govuk_back_link href: @form.back_path %>
<% end %>
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<span class="govuk-caption-l">Bulk upload for sales (<%= @bulk_upload.year_combo %>)</span>
<h1 class="govuk-heading-l">These logs have already been created</h1>
<p class="govuk-body">You have chosen to create logs from your recent bulk upload. To view and update these logs, return to the list of sales logs.</p>
<%= govuk_button_link_to "Return to sales logs", sales_logs_path %>
</div>
</div>

34
spec/requests/bulk_upload_sales_soft_validations_check_controller_spec.rb

@ -28,6 +28,32 @@ RSpec.describe BulkUploadSalesSoftValidationsCheckController, type: :request do
expect(response.body).to include("Purchaser code") expect(response.body).to include("Purchaser code")
expect(response.body).to include("some error") expect(response.body).to include("some error")
end end
it "sets no cache headers" do
get "/sales-logs/bulk-upload-soft-validations-check/#{bulk_upload.id}/confirm-soft-errors"
expect(response.headers["Cache-Control"]).to eql("no-store")
end
context "and previosuly told us to fix inline" do
let(:bulk_upload) { create(:bulk_upload, :sales, user:, bulk_upload_errors:, choice: "create-fix-inline") }
it "redirects to resume chosen" do
get "/sales-logs/bulk-upload-soft-validations-check/#{bulk_upload.id}/confirm-soft-errors"
expect(response).to redirect_to("/sales-logs/bulk-upload-resume/#{bulk_upload.id}/chosen")
end
end
context "and previosuly told us to bulk confirm soft validations" do
let(:bulk_upload) { create(:bulk_upload, :sales, user:, bulk_upload_errors:, choice: "bulk-confirm-soft-validations") }
it "redirects to soft validations check chosen" do
get "/sales-logs/bulk-upload-soft-validations-check/#{bulk_upload.id}/confirm-soft-errors"
expect(response).to redirect_to("/sales-logs/bulk-upload-soft-validations-check/#{bulk_upload.id}/chosen")
end
end
end end
describe "PATCH /sales-logs/bulk-upload-soft-validations-check/:ID/confirm-soft-errors" do describe "PATCH /sales-logs/bulk-upload-soft-validations-check/:ID/confirm-soft-errors" do
@ -38,6 +64,8 @@ RSpec.describe BulkUploadSalesSoftValidationsCheckController, type: :request do
expect(response).to be_successful expect(response).to be_successful
expect(response.body).to include("You must select if there are errors in these fields") expect(response.body).to include("You must select if there are errors in these fields")
expect(bulk_upload.reload.choice).to be_blank
end end
end end
@ -46,6 +74,8 @@ RSpec.describe BulkUploadSalesSoftValidationsCheckController, type: :request do
patch "/sales-logs/bulk-upload-soft-validations-check/#{bulk_upload.id}/confirm-soft-errors", params: { form: { confirm_soft_errors: "no" } } patch "/sales-logs/bulk-upload-soft-validations-check/#{bulk_upload.id}/confirm-soft-errors", params: { form: { confirm_soft_errors: "no" } }
expect(response).to redirect_to("/sales-logs/bulk-upload-resume/#{bulk_upload.id}/fix-choice?soft_errors_only=true") expect(response).to redirect_to("/sales-logs/bulk-upload-resume/#{bulk_upload.id}/fix-choice?soft_errors_only=true")
expect(bulk_upload.reload.choice).to be_blank
end end
end end
@ -56,6 +86,8 @@ RSpec.describe BulkUploadSalesSoftValidationsCheckController, type: :request do
expect(response).to redirect_to("/sales-logs/bulk-upload-soft-validations-check/#{bulk_upload.id}/confirm") expect(response).to redirect_to("/sales-logs/bulk-upload-soft-validations-check/#{bulk_upload.id}/confirm")
follow_redirect! follow_redirect!
expect(response.body).not_to include("You’ve successfully uploaded") expect(response.body).not_to include("You’ve successfully uploaded")
expect(bulk_upload.reload.choice).to be_blank
end end
end end
end end
@ -85,6 +117,8 @@ RSpec.describe BulkUploadSalesSoftValidationsCheckController, type: :request do
expect(response).to redirect_to("/sales-logs") expect(response).to redirect_to("/sales-logs")
follow_redirect! follow_redirect!
expect(response.body).to include("You’ve successfully uploaded 2 logs") expect(response.body).to include("You’ve successfully uploaded 2 logs")
expect(bulk_upload.reload.choice).to eql("bulk-confirm-soft-validations")
end end
end end
end end

Loading…
Cancel
Save