Browse Source

remove unused model methods

pull/1503/head
Phil Lee 3 years ago
parent
commit
cb4d263438
  1. 8
      app/models/organisation.rb
  2. 8
      app/models/user.rb
  3. 5
      spec/models/organisation_spec.rb
  4. 5
      spec/models/user_spec.rb

8
app/models/organisation.rb

@ -70,14 +70,6 @@ class Organisation < ApplicationRecord
SalesLog.filter_by_organisation(self)
end
def completed_lettings_logs
lettings_logs.completed
end
def not_completed_lettings_logs
lettings_logs.not_completed
end
def address_string
%i[address_line1 address_line2 postcode].map { |field| public_send(field) }.join("\n")
end

8
app/models/user.rb

@ -69,14 +69,6 @@ class User < ApplicationRecord
end
end
def completed_lettings_logs
lettings_logs.completed
end
def not_completed_lettings_logs
lettings_logs.not_completed
end
def is_key_contact?
is_key_contact
end

5
spec/models/organisation_spec.rb

@ -169,11 +169,6 @@ RSpec.describe Organisation, type: :model do
it "has lettings logs" do
expect(organisation.lettings_logs.to_a).to match_array([owned_lettings_log, managed_lettings_log])
end
it "has lettings log status helper methods" do
expect(organisation.completed_lettings_logs.to_a).to eq([owned_lettings_log])
expect(organisation.not_completed_lettings_logs.to_a).to eq([managed_lettings_log])
end
end
end

5
spec/models/user_spec.rb

@ -36,11 +36,6 @@ RSpec.describe User, type: :model do
expect(user.lettings_logs.to_a).to match_array([owned_lettings_log, managed_lettings_log])
end
it "has lettings log status helper methods" do
expect(user.completed_lettings_logs.to_a).to match_array([owned_lettings_log])
expect(user.not_completed_lettings_logs.to_a).to match_array([managed_lettings_log])
end
it "has a role" do
expect(user.role).to eq("data_provider")
expect(user.data_provider?).to be true

Loading…
Cancel
Save