Browse Source

remove bulk upload dead code

pull/1621/head
Phil Lee 3 years ago
parent
commit
c57db77ed1
  1. 16
      app/services/bulk_upload/lettings/validator.rb

16
app/services/bulk_upload/lettings/validator.rb

@ -1,9 +1,6 @@
require "csv"
class BulkUpload::Lettings::Validator
COLUMN_PERCENTAGE_ERROR_THRESHOLD = 0.6
COLUMN_ABSOLUTE_ERROR_THRESHOLD = 16
include ActiveModel::Validations
attr_reader :bulk_upload, :path
@ -61,19 +58,6 @@ class BulkUpload::Lettings::Validator
.positive?
end
def over_column_error_threshold?
fields = ("field_1".."field_134").to_a
percentage_threshold = (row_parsers.size * COLUMN_PERCENTAGE_ERROR_THRESHOLD).ceil
fields.any? do |field|
count = row_parsers.count { |row_parser| row_parser.errors[field].present? }
next if count < COLUMN_ABSOLUTE_ERROR_THRESHOLD
count > percentage_threshold
end
end
def any_logs_already_exist?
row_parsers.any?(&:log_already_exists?)
end

Loading…
Cancel
Save